fix: Envelope header bytes length #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marandaneto
reviewed
Feb 19, 2020
marandaneto
reviewed
Feb 19, 2020
bruno-garcia
force-pushed
the
fix/envelope-size
branch
from
7b0e44e to
b0d0be2
Compare
|
@marandaneto @HazAT regardless how we're fixing this (this PR or other) we need to address this since it's broken for RN users right now. |
|
I fixed the code and bumped the SDK version. I will do a release. |
|
Was able to repro it, fixed will do a release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@HazAT it was supposed to be a draft PR but.. This is an attempt (untested) to fix: getsentry/sentry-android#273
The size issue exists because currently, we use the string length which is the number of characters. The envelope spec expects the number of bytes (which in UTF-8 vary depending on the character).
Ideally, we'd implement this in Java (we need it there anyway given the new hybrid spec) and RN will just call in with the event.
Fixes: #775