-
-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add androidx
support.
#607
Conversation
- Replace `android.support` with `androidx` in import.
Hello :) Maybe we can simply remove the annotation ? Like what you did here : itinance/react-native-fs#691 Just to ensure the two-ways compatibility. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As proposed, removing the annotation would be better to make sure this package keeps support for RN versions below 0.60 and above. The annotation is not used during runtime so it is not really necessary.
Thanks @maieonbrix and @se-bastiaan ! I removed the annotation and androidx import. |
Thanks for this. We just released beta version of the new version of our SDK which has the fix already in there. If really necessary I can make a patch release. |
I think that completely depends on the planning for the v1 of the SDK. I would say that this, as a breaking change, is the perfect moment to only support react-native v0.60 and higher as you already mentioned in #612. However, if v1 takes longer than expected it would be nice to have a patch release. For now, no need imo. We'll have to wait for other packages and their updates to be able to update to RN 0.60 anyways. |
Can we merge this PR? |
I will close this PR since it's outdaten, please migrate / use our new SDK which has support for AndroidX |
android.support
withandroidx
in import.