feat: Unified API + Transport + iOS #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Body Fixes #123
HazAT
added a commit
that referenced
this pull request
Jul 3, 2019
* feat: Use @sentry/browser * feat: Moved all code into src * fix: First working version * feat: Unified API + Transport + iOS (#591) * feat: Native transport * feat: Move ios/android code * feat: Handle promises + nativeCarsh * feat: Use device context, Trim public API * feat: Make android work * fix: Remove unused transport * feat: Add native android send * fix: Use older android code * fix: Small Android changes * feat: Fetch release from native * meta: Changelog + versions * meta: Update Sentry wizard * meta: Changelog * Update CHANGELOG.md Co-Authored-By: Kamil Ogórek <[email protected]> * feat: Codereview changes
jpshelley
reviewed
Jan 16, 2020
|
|
||
| RCT_EXPORT_METHOD(setTags:(NSDictionary *_Nonnull)tags) | ||
| { | ||
| SentryClient.sharedClient.tags = [SentryJavaScriptBridgeHelper sanitizeDictionary:tags]; |
There was a problem hiding this comment.
Sorry I realize this is months old now @HazAT but it appears this was removed in the new API and therefor impacts react-native ability to report context on native crashes, see #694 - I can push up a PR if this was accidental.
However, a bit confused on how that would work in this new API, seeing as setTags is just exported directly from @sentry/core - is it possibly to create some sort of proxy so native context is added as well?
There was a problem hiding this comment.
We will fix this, instead of setting all properties individually we will just persist the Scope.
Keep an eye on the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.