Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proper windows support with default config #523

Merged
merged 1 commit into from
Jan 29, 2019
Merged

Add proper windows support with default config #523

merged 1 commit into from
Jan 29, 2019

Conversation

BrendonSled
Copy link
Contributor

This fixes issue #404

@BrendonSled BrendonSled requested a review from HazAT as a code owner December 20, 2018 22:27
@dochathuc
Copy link

@BrendonSled You save my life. Thanks

@BrendonSled
Copy link
Contributor Author

@HazAT mind reviewing? My team is having to use a fork to get windows compatibility

@OleksandrKucherenko
Copy link
Contributor

@Titozzz can you take a look? ^

@Titozzz
Copy link
Contributor

Titozzz commented Jan 29, 2019

Why me 🤔? I'm no windows expert 😛 .

Code looks fine tho.

HazAT
HazAT approved these changes Jan 29, 2019
View reviewed changes
Copy link
Member

@HazAT HazAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@HazAT HazAT merged commit 4fe35d7 into getsentry:master Jan 29, 2019
@HazAT HazAT mentioned this pull request Jan 29, 2019
Closed
5 tasks
@github-actions github-actions bot mentioned this pull request Jul 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HazAT HazAT HazAT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BrendonSled @dochathuc @OleksandrKucherenko @Titozzz @HazAT