Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(CI): Build Expo sample on CLI #4361

Merged
merged 10 commits into from
Dec 13, 2024
Merged

(CI): Build Expo sample on CLI #4361

merged 10 commits into from
Dec 13, 2024

Conversation

lucas-zimerman
Copy link
Collaborator

@lucas-zimerman lucas-zimerman commented Dec 11, 2024 •
edited
Loading

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Currently we are not testing the build phase of Expo, so this PR aims to build the expo sample on CLI using different types of settings.

💡 Motivation and Context

Implements most of the tasks written here: #3707

💚 How did you test it?

Locally and on Github Actions.

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 11, 2024 •
edited
Loading

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 448.09 ms 429.98 ms -18.11 ms
Size 17.74 MiB 20.10 MiB 2.36 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
9433f35 347.64 ms 356.22 ms 8.58 ms
ddc0552 472.92 ms 460.66 ms -12.26 ms
f54118b 441.24 ms 431.92 ms -9.32 ms
4297324 536.61 ms 542.48 ms 5.87 ms
cdf2f33 469.46 ms 462.17 ms -7.29 ms
9f0f6c8 433.91 ms 429.16 ms -4.75 ms
3ffcddd 302.92 ms 315.80 ms 12.88 ms
1c65324 426.37 ms 460.36 ms 33.99 ms
416f465 446.96 ms 454.22 ms 7.26 ms
e73d82f 475.82 ms 506.55 ms 30.73 ms

App size

Revision Plain With Sentry Diff
9433f35 17.73 MiB 19.81 MiB 2.08 MiB
ddc0552 17.74 MiB 20.09 MiB 2.35 MiB
f54118b 17.74 MiB 20.08 MiB 2.35 MiB
4297324 17.74 MiB 20.08 MiB 2.34 MiB
cdf2f33 17.74 MiB 20.08 MiB 2.34 MiB
9f0f6c8 17.74 MiB 20.08 MiB 2.35 MiB
3ffcddd 17.73 MiB 19.75 MiB 2.02 MiB
1c65324 17.73 MiB 19.95 MiB 2.21 MiB
416f465 17.74 MiB 20.09 MiB 2.35 MiB
e73d82f 17.73 MiB 20.07 MiB 2.33 MiB

Previous results on branch: lz/expo-ci-build

Startup times

Revision Plain With Sentry Diff
532d2c3 468.53 ms 452.52 ms -16.01 ms
1ec94d6 435.94 ms 418.43 ms -17.51 ms

App size

Revision Plain With Sentry Diff
532d2c3 17.74 MiB 20.09 MiB 2.35 MiB
1ec94d6 17.74 MiB 20.09 MiB 2.35 MiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 11, 2024 •
edited
Loading

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 401.56 ms 460.79 ms 59.23 ms
Size 7.15 MiB 8.37 MiB 1.22 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
4297324+dirty 385.33 ms 435.68 ms 50.35 ms
9282172+dirty 363.57 ms 399.78 ms 36.20 ms
e1ea4a8+dirty 451.98 ms 497.58 ms 45.60 ms
e540498+dirty 408.56 ms 480.00 ms 71.44 ms
db44eaf+dirty 394.26 ms 438.88 ms 44.62 ms
70e6261+dirty 395.08 ms 408.12 ms 13.04 ms
0db0c72+dirty 335.20 ms 351.06 ms 15.86 ms
457e29f+dirty 591.49 ms 612.96 ms 21.47 ms
9433f35+dirty 265.50 ms 336.08 ms 70.58 ms
61310e1+dirty 463.51 ms 511.09 ms 47.57 ms

App size

Revision Plain With Sentry Diff
4297324+dirty 7.15 MiB 8.35 MiB 1.20 MiB
9282172+dirty 7.15 MiB 8.37 MiB 1.22 MiB
e1ea4a8+dirty 7.15 MiB 8.35 MiB 1.20 MiB
e540498+dirty 7.15 MiB 8.38 MiB 1.23 MiB
db44eaf+dirty 7.15 MiB 8.36 MiB 1.21 MiB
70e6261+dirty 7.15 MiB 8.21 MiB 1.07 MiB
0db0c72+dirty 7.15 MiB 8.04 MiB 911.02 KiB
457e29f+dirty 7.15 MiB 8.10 MiB 981.29 KiB
9433f35+dirty 7.15 MiB 8.08 MiB 959.34 KiB
61310e1+dirty 7.15 MiB 8.36 MiB 1.21 MiB

Previous results on branch: lz/expo-ci-build

Startup times

Revision Plain With Sentry Diff
1ec94d6+dirty 412.09 ms 462.42 ms 50.33 ms
532d2c3+dirty 362.79 ms 408.72 ms 45.94 ms

App size

Revision Plain With Sentry Diff
1ec94d6+dirty 7.15 MiB 8.37 MiB 1.22 MiB
532d2c3+dirty 7.15 MiB 8.37 MiB 1.22 MiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 11, 2024 •
edited
Loading

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1236.20 ms 1242.96 ms 6.76 ms
Size 2.36 MiB 3.10 MiB 759.45 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
9c48b2c+dirty 1246.96 ms 1255.73 ms 8.77 ms
3853f43+dirty 1221.82 ms 1242.64 ms 20.82 ms
7fd512a+dirty 1218.78 ms 1217.25 ms -1.53 ms
457e29f+dirty 1253.94 ms 1269.18 ms 15.24 ms
ac41368+dirty 1226.65 ms 1237.90 ms 11.24 ms
9cd0e9f+dirty 1224.94 ms 1239.88 ms 14.94 ms
9282172+dirty 1237.27 ms 1242.20 ms 4.94 ms
d0bf494+dirty 1289.40 ms 1298.40 ms 9.00 ms
f06c879+dirty 1252.64 ms 1259.66 ms 7.02 ms
5a22220+dirty 1209.49 ms 1220.94 ms 11.45 ms

App size

Revision Plain With Sentry Diff
9c48b2c+dirty 2.36 MiB 2.85 MiB 495.77 KiB
3853f43+dirty 2.36 MiB 2.85 MiB 499.81 KiB
7fd512a+dirty 2.36 MiB 3.10 MiB 753.35 KiB
457e29f+dirty 2.36 MiB 2.87 MiB 520.67 KiB
ac41368+dirty 2.36 MiB 3.14 MiB 793.46 KiB
9cd0e9f+dirty 2.36 MiB 3.08 MiB 735.56 KiB
9282172+dirty 2.36 MiB 3.11 MiB 759.89 KiB
d0bf494+dirty 2.36 MiB 2.83 MiB 481.15 KiB
f06c879+dirty 2.36 MiB 2.88 MiB 530.42 KiB
5a22220+dirty 2.36 MiB 2.92 MiB 570.21 KiB

Previous results on branch: lz/expo-ci-build

Startup times

Revision Plain With Sentry Diff
532d2c3+dirty 1230.96 ms 1233.15 ms 2.19 ms
1ec94d6+dirty 1238.55 ms 1234.21 ms -4.34 ms

App size

Revision Plain With Sentry Diff
532d2c3+dirty 2.36 MiB 3.11 MiB 759.83 KiB
1ec94d6+dirty 2.36 MiB 3.11 MiB 759.82 KiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 11, 2024 •
edited
Loading

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1241.20 ms 1239.29 ms -1.92 ms
Size 2.92 MiB 3.67 MiB 771.95 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
9c48b2c+dirty 1253.39 ms 1256.30 ms 2.91 ms
3853f43+dirty 1271.74 ms 1278.04 ms 6.30 ms
7fd512a+dirty 1239.41 ms 1241.50 ms 2.09 ms
457e29f+dirty 1256.71 ms 1258.50 ms 1.79 ms
ac41368+dirty 1226.69 ms 1229.96 ms 3.27 ms
9cd0e9f+dirty 1244.61 ms 1247.43 ms 2.82 ms
9282172+dirty 1227.60 ms 1232.69 ms 5.09 ms
d0bf494+dirty 1266.20 ms 1267.52 ms 1.32 ms
f06c879+dirty 1285.14 ms 1285.86 ms 0.72 ms
5a22220+dirty 1246.18 ms 1249.61 ms 3.43 ms

App size

Revision Plain With Sentry Diff
9c48b2c+dirty 2.92 MiB 3.41 MiB 499.97 KiB
3853f43+dirty 2.92 MiB 3.41 MiB 503.54 KiB
7fd512a+dirty 2.92 MiB 3.66 MiB 758.62 KiB
457e29f+dirty 2.92 MiB 3.43 MiB 524.75 KiB
ac41368+dirty 2.92 MiB 3.69 MiB 794.29 KiB
9cd0e9f+dirty 2.92 MiB 3.64 MiB 741.23 KiB
9282172+dirty 2.92 MiB 3.67 MiB 772.46 KiB
d0bf494+dirty 2.92 MiB 3.40 MiB 488.08 KiB
f06c879+dirty 2.92 MiB 3.44 MiB 533.24 KiB
5a22220+dirty 2.92 MiB 3.48 MiB 575.81 KiB

Previous results on branch: lz/expo-ci-build

Startup times

Revision Plain With Sentry Diff
532d2c3+dirty 1234.35 ms 1231.45 ms -2.90 ms
1ec94d6+dirty 1227.86 ms 1220.04 ms -7.82 ms

App size

Revision Plain With Sentry Diff
532d2c3+dirty 2.92 MiB 3.67 MiB 772.42 KiB
1ec94d6+dirty 2.92 MiB 3.67 MiB 772.37 KiB

@lucas-zimerman lucas-zimerman mentioned this pull request Dec 11, 2024
Open
@lucas-zimerman lucas-zimerman changed the title (WIP) Build Expo sample on CLI (CI): Build Expo sample on CLI Dec 12, 2024
@lucas-zimerman lucas-zimerman marked this pull request as ready for review December 12, 2024 16:15
antonis
antonis approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both the changes and the CI executions LGTM 🚀
Thank you for adding this Lucas 🙇

@lucas-zimerman lucas-zimerman enabled auto-merge (squash) December 13, 2024 12:20
@lucas-zimerman lucas-zimerman merged commit 2fb5240 into main Dec 13, 2024
62 checks passed
@lucas-zimerman lucas-zimerman deleted the lz/expo-ci-build branch December 13, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonis antonis antonis approved these changes

@krystofwoldrich krystofwoldrich Awaiting requested review from krystofwoldrich krystofwoldrich is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucas-zimerman @antonis