-
-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(samples): Update Expo Sample export scripts #4333
Conversation
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Update Expo Sample export scripts ([#4333](https://github.com/getsentry/sentry-react-native/pull/4333)) If none of the above apply, you can opt out of this check by adding |
Android (new) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
27ef4ee+dirty | 296.71 ms | 351.00 ms | 54.29 ms |
8900e1a+dirty | 371.40 ms | 377.70 ms | 6.31 ms |
8de2810+dirty | 368.43 ms | 412.20 ms | 43.77 ms |
0db0c72+dirty | 335.20 ms | 351.06 ms | 15.86 ms |
52c0562+dirty | 401.23 ms | 435.65 ms | 34.42 ms |
e5bc97b+dirty | 409.10 ms | 471.61 ms | 62.51 ms |
d0bf494+dirty | 253.73 ms | 308.23 ms | 54.49 ms |
9c48b2c+dirty | 270.82 ms | 321.12 ms | 50.30 ms |
d2c32bb+dirty | 445.45 ms | 497.85 ms | 52.41 ms |
b95b8af+dirty | 392.94 ms | 428.00 ms | 35.06 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
27ef4ee+dirty | 7.15 MiB | 8.08 MiB | 959.49 KiB |
8900e1a+dirty | 7.15 MiB | 8.03 MiB | 901.79 KiB |
8de2810+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
0db0c72+dirty | 7.15 MiB | 8.04 MiB | 911.02 KiB |
52c0562+dirty | 7.15 MiB | 8.39 MiB | 1.24 MiB |
e5bc97b+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
d0bf494+dirty | 7.15 MiB | 8.04 MiB | 910.85 KiB |
9c48b2c+dirty | 7.15 MiB | 8.07 MiB | 947.16 KiB |
d2c32bb+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
b95b8af+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
iOS (legacy) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e5bc97b+dirty | 1230.63 ms | 1234.83 ms | 4.20 ms |
80b2ce3+dirty | 1265.92 ms | 1268.60 ms | 2.69 ms |
d7401ac+dirty | 1252.38 ms | 1275.04 ms | 22.66 ms |
b95b8af+dirty | 1221.39 ms | 1228.52 ms | 7.13 ms |
e540498+dirty | 1220.61 ms | 1212.93 ms | -7.68 ms |
f06c879+dirty | 1252.64 ms | 1259.66 ms | 7.02 ms |
e5c9b8b+dirty | 1258.57 ms | 1267.32 ms | 8.75 ms |
5bb8d5f+dirty | 1235.47 ms | 1237.39 ms | 1.92 ms |
acadc0f+dirty | 1264.38 ms | 1290.06 ms | 25.68 ms |
c2a4e9b+dirty | 1240.10 ms | 1239.22 ms | -0.88 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e5bc97b+dirty | 2.36 MiB | 3.10 MiB | 753.14 KiB |
80b2ce3+dirty | 2.36 MiB | 2.84 MiB | 486.98 KiB |
d7401ac+dirty | 2.36 MiB | 2.83 MiB | 481.14 KiB |
b95b8af+dirty | 2.36 MiB | 3.14 MiB | 793.32 KiB |
e540498+dirty | 2.36 MiB | 3.14 MiB | 793.34 KiB |
f06c879+dirty | 2.36 MiB | 2.88 MiB | 530.42 KiB |
e5c9b8b+dirty | 2.36 MiB | 2.87 MiB | 520.43 KiB |
5bb8d5f+dirty | 2.36 MiB | 2.92 MiB | 570.22 KiB |
acadc0f+dirty | 2.36 MiB | 2.83 MiB | 480.37 KiB |
c2a4e9b+dirty | 2.36 MiB | 3.08 MiB | 734.00 KiB |
iOS (new) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e5bc97b+dirty | 1229.17 ms | 1227.64 ms | -1.54 ms |
80b2ce3+dirty | 1245.12 ms | 1262.04 ms | 16.92 ms |
d7401ac+dirty | 1288.10 ms | 1289.54 ms | 1.44 ms |
b95b8af+dirty | 1235.60 ms | 1242.06 ms | 6.46 ms |
e540498+dirty | 1254.92 ms | 1247.21 ms | -7.71 ms |
f06c879+dirty | 1285.14 ms | 1285.86 ms | 0.72 ms |
e5c9b8b+dirty | 1276.90 ms | 1280.92 ms | 4.02 ms |
5bb8d5f+dirty | 1215.04 ms | 1217.52 ms | 2.48 ms |
acadc0f+dirty | 1271.12 ms | 1272.28 ms | 1.16 ms |
c2a4e9b+dirty | 1247.39 ms | 1243.04 ms | -4.35 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e5bc97b+dirty | 2.92 MiB | 3.66 MiB | 758.40 KiB |
80b2ce3+dirty | 2.92 MiB | 3.40 MiB | 492.75 KiB |
d7401ac+dirty | 2.92 MiB | 3.40 MiB | 488.06 KiB |
b95b8af+dirty | 2.92 MiB | 3.69 MiB | 794.16 KiB |
e540498+dirty | 2.92 MiB | 3.69 MiB | 794.14 KiB |
f06c879+dirty | 2.92 MiB | 3.44 MiB | 533.24 KiB |
e5c9b8b+dirty | 2.92 MiB | 3.43 MiB | 524.50 KiB |
5bb8d5f+dirty | 2.92 MiB | 3.48 MiB | 575.85 KiB |
acadc0f+dirty | 2.92 MiB | 3.39 MiB | 487.34 KiB |
c2a4e9b+dirty | 2.92 MiB | 3.64 MiB | 739.91 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for updating the scripts @krystofwoldrich 🙇
The changes on this PR look good but when I run the script locally I've noticed the following:
- run
yarn export:web
- browse in the
dist
folder and openindex.html
in a browser - notice that the web app is rendering but it is not functional (tabs, buttons etc)
- run
yarn start:web
- notice that the app is functioning as expected
Thank you for pointing that out. I've forgot to include this issue for context #4317, fixed in expo/expo#33344 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've forgot to include this issue for context #4317, fixed in expo/expo#33344
Thank you for the clarification @krystofwoldrich 🙇
LGTM 🚀
This PR adds
export:web
as to deplay it's common to only export web without the mobile js bundles.This PR also removes the
EXPO_SKIP_DURING_EXPORT
since since 5.21.0 release (#3730)___SENTRY_METRO_DEV_SERVER___
is used internally to disable Sentry during the static paths render.