misc: Removes deprecated Sentry.metrics API #4278

antonis · 2024-11-15T09:27:30Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

📜 Description

💡 Motivation and Context

Fixes #4242

💚 How did you test it?

Manual testing

📝 Checklist

I reviewed submitted code
I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
All tests passing
No breaking changes

🔮 Next steps

#skip-changelog

github-actions · 2024-11-15T09:41:22Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	556.69 ms	542.83 ms	-13.86 ms
Size	17.74 MiB	20.08 MiB	2.34 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`63ed251`	457.74 ms	441.54 ms	-16.20 ms
`728164b`	414.34 ms	449.22 ms	34.88 ms
`07e58c9`	495.04 ms	489.73 ms	-5.31 ms
`5a22220`	412.38 ms	447.35 ms	34.97 ms
`34aba08`	328.10 ms	342.84 ms	14.74 ms
`baa882f`	354.93 ms	356.18 ms	1.25 ms
`9a3ca65`+dirty	326.93 ms	330.14 ms	3.21 ms
`c398f67`	449.64 ms	461.38 ms	11.74 ms
`e5bc97b`	438.96 ms	437.39 ms	-1.57 ms
`52a8031`+dirty	311.55 ms	321.37 ms	9.82 ms

App size

Revision	Plain	With Sentry	Diff
`63ed251`	17.74 MiB	20.08 MiB	2.34 MiB
`728164b`	17.73 MiB	19.85 MiB	2.12 MiB
`07e58c9`	17.74 MiB	20.08 MiB	2.34 MiB
`5a22220`	17.73 MiB	19.93 MiB	2.20 MiB
`34aba08`	17.73 MiB	19.80 MiB	2.07 MiB
`baa882f`	17.73 MiB	20.06 MiB	2.33 MiB
`9a3ca65`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`c398f67`	17.73 MiB	19.94 MiB	2.21 MiB
`e5bc97b`	17.74 MiB	20.08 MiB	2.34 MiB
`52a8031`+dirty	17.73 MiB	20.04 MiB	2.31 MiB

github-actions · 2024-11-15T09:48:03Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	417.34 ms	496.54 ms	79.20 ms
Size	7.15 MiB	8.35 MiB	1.20 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`70caa60`+dirty	308.83 ms	393.06 ms	84.23 ms
`2ec71da`+dirty	375.64 ms	431.59 ms	55.95 ms
`8c88ac7`+dirty	402.72 ms	434.32 ms	31.60 ms
`728164b`+dirty	335.93 ms	342.94 ms	7.01 ms
`acadc0f`+dirty	259.04 ms	304.67 ms	45.63 ms
`d0bf494`+dirty	253.73 ms	308.23 ms	54.49 ms
`86d6d2c`+dirty	267.21 ms	325.24 ms	58.04 ms
`e540498`+dirty	408.56 ms	480.00 ms	71.44 ms
`c639edf`+dirty	363.39 ms	414.78 ms	51.39 ms
`6e8584e`+dirty	383.37 ms	400.84 ms	17.47 ms

App size

Revision	Plain	With Sentry	Diff
`70caa60`+dirty	7.15 MiB	8.03 MiB	901.79 KiB
`2ec71da`+dirty	7.15 MiB	8.38 MiB	1.23 MiB
`8c88ac7`+dirty	7.15 MiB	8.35 MiB	1.20 MiB
`728164b`+dirty	7.15 MiB	8.12 MiB	997.71 KiB
`acadc0f`+dirty	7.15 MiB	8.03 MiB	903.20 KiB
`d0bf494`+dirty	7.15 MiB	8.04 MiB	910.85 KiB
`86d6d2c`+dirty	7.15 MiB	8.09 MiB	962.69 KiB
`e540498`+dirty	7.15 MiB	8.38 MiB	1.23 MiB
`c639edf`+dirty	7.15 MiB	8.35 MiB	1.20 MiB
`6e8584e`+dirty	7.15 MiB	8.13 MiB	1002.18 KiB

github-actions · 2024-11-15T09:59:37Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1233.29 ms	1228.58 ms	-4.71 ms
Size	2.36 MiB	3.10 MiB	752.49 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`457e29f`+dirty	1253.94 ms	1269.18 ms	15.24 ms
`d43a46b`+dirty	1219.24 ms	1219.65 ms	0.41 ms
`e5bc97b`+dirty	1230.63 ms	1234.83 ms	4.20 ms
`9c48b2c`+dirty	1246.96 ms	1255.73 ms	8.77 ms
`c639edf`+dirty	1236.18 ms	1235.04 ms	-1.14 ms
`3853f43`+dirty	1221.82 ms	1242.64 ms	20.82 ms
`52c0562`+dirty	1219.34 ms	1221.25 ms	1.91 ms
`5446992`+dirty	1273.28 ms	1276.68 ms	3.40 ms
`0677344`+dirty	1276.70 ms	1300.07 ms	23.37 ms
`8ae23a7`+dirty	1230.02 ms	1227.62 ms	-2.40 ms

App size

Revision	Plain	With Sentry	Diff
`457e29f`+dirty	2.36 MiB	2.87 MiB	520.67 KiB
`d43a46b`+dirty	2.36 MiB	3.08 MiB	734.25 KiB
`e5bc97b`+dirty	2.36 MiB	3.10 MiB	753.14 KiB
`9c48b2c`+dirty	2.36 MiB	2.85 MiB	495.77 KiB
`c639edf`+dirty	2.36 MiB	3.08 MiB	736.63 KiB
`3853f43`+dirty	2.36 MiB	2.85 MiB	499.81 KiB
`52c0562`+dirty	2.36 MiB	3.14 MiB	793.36 KiB
`5446992`+dirty	2.36 MiB	2.88 MiB	531.94 KiB
`0677344`+dirty	2.36 MiB	2.85 MiB	496.81 KiB
`8ae23a7`+dirty	2.36 MiB	3.10 MiB	752.42 KiB

github-actions · 2024-11-15T09:59:47Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1237.12 ms	1244.24 ms	7.12 ms
Size	2.92 MiB	3.66 MiB	756.99 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`457e29f`+dirty	1256.71 ms	1258.50 ms	1.79 ms
`d43a46b`+dirty	1223.31 ms	1230.92 ms	7.61 ms
`e5bc97b`+dirty	1229.17 ms	1227.64 ms	-1.54 ms
`9c48b2c`+dirty	1253.39 ms	1256.30 ms	2.91 ms
`c639edf`+dirty	1223.63 ms	1227.98 ms	4.35 ms
`3853f43`+dirty	1271.74 ms	1278.04 ms	6.30 ms
`52c0562`+dirty	1233.94 ms	1226.29 ms	-7.65 ms
`5446992`+dirty	1249.94 ms	1254.80 ms	4.86 ms
`0677344`+dirty	1252.52 ms	1254.08 ms	1.56 ms
`8ae23a7`+dirty	1233.67 ms	1229.52 ms	-4.15 ms

App size

Revision	Plain	With Sentry	Diff
`457e29f`+dirty	2.92 MiB	3.43 MiB	524.75 KiB
`d43a46b`+dirty	2.92 MiB	3.64 MiB	740.29 KiB
`e5bc97b`+dirty	2.92 MiB	3.66 MiB	758.40 KiB
`9c48b2c`+dirty	2.92 MiB	3.41 MiB	499.97 KiB
`c639edf`+dirty	2.92 MiB	3.64 MiB	742.55 KiB
`3853f43`+dirty	2.92 MiB	3.41 MiB	503.54 KiB
`52c0562`+dirty	2.92 MiB	3.69 MiB	794.15 KiB
`5446992`+dirty	2.92 MiB	3.44 MiB	535.26 KiB
`0677344`+dirty	2.92 MiB	3.41 MiB	500.94 KiB
`8ae23a7`+dirty	2.92 MiB	3.66 MiB	757.67 KiB

lucas-zimerman

LGTM!

antonis added 3 commits November 15, 2024 11:25

Remove metric from the Expo app

616db8c

Remove metric from the MacOS app

e21831e

Remove metric from the RN app

e600300

antonis requested review from krystofwoldrich and lucas-zimerman as code owners November 15, 2024 09:27

antonis changed the title ~~misc: Removes deprecated Sentry.metrics~~ misc: Removes deprecated Sentry.metrics API Nov 15, 2024

lucas-zimerman approved these changes Nov 15, 2024

View reviewed changes

Merge branch 'main' into antonis/remove-deprecated-metrics

3ebf513

antonis mentioned this pull request Nov 18, 2024

Add Release as default tag to Sentry Metrics #3788

Closed

Merge branch 'main' into antonis/remove-deprecated-metrics

c30dae5

lucas-zimerman enabled auto-merge (squash) November 18, 2024 12:20

lucas-zimerman merged commit b53dbe6 into main Nov 18, 2024
54 of 55 checks passed

lucas-zimerman deleted the antonis/remove-deprecated-metrics branch November 18, 2024 12:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

misc: Removes deprecated Sentry.metrics API #4278

misc: Removes deprecated Sentry.metrics API #4278

antonis commented Nov 15, 2024 •

edited

Loading

github-actions bot commented Nov 15, 2024

Baseline results on branch: main

Startup times

App size

github-actions bot commented Nov 15, 2024 •

edited

Loading

Baseline results on branch: main

Startup times

App size

github-actions bot commented Nov 15, 2024 •

edited

Loading

Baseline results on branch: main

Startup times

App size

github-actions bot commented Nov 15, 2024 •

edited

Loading

Baseline results on branch: main

Startup times

App size

lucas-zimerman left a comment

misc: Removes deprecated Sentry.metrics API #4278

misc: Removes deprecated Sentry.metrics API #4278

Conversation

antonis commented Nov 15, 2024 • edited Loading

📢 Type of change

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

github-actions bot commented Nov 15, 2024

Android (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

github-actions bot commented Nov 15, 2024 • edited Loading

Android (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

github-actions bot commented Nov 15, 2024 • edited Loading

iOS (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

github-actions bot commented Nov 15, 2024 • edited Loading

iOS (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

lucas-zimerman left a comment

Choose a reason for hiding this comment

antonis commented Nov 15, 2024 •

edited

Loading

github-actions bot commented Nov 15, 2024 •

edited

Loading

github-actions bot commented Nov 15, 2024 •

edited

Loading

github-actions bot commented Nov 15, 2024 •

edited

Loading