Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tooling): Add clang-format #4229

Merged
merged 4 commits into from
Nov 5, 2024
Merged

Conversation

krystofwoldrich
Copy link
Member

@krystofwoldrich krystofwoldrich commented Nov 4, 2024

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

This PR adds clang-format to yarn lint and yarn fix commands.

First commit adds the formatter.
Second commit changes are from the formatter.

Clang config file is copied from sentry-cocoa as that already uses the formatter. And it's similar mobile code base.

💡 Motivation and Context

There are over 70 clang file in the repository.

💚 How did you test it?

ci, locally

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

#skip-changelog

Copy link
Collaborator

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀
Thank you for improving our tooling @krystofwoldrich 🙇

Only added a suggestion on an extra folder that can be ignored.

Co-authored-by: Antonis Lilis <[email protected]>
@krystofwoldrich krystofwoldrich enabled auto-merge (squash) November 5, 2024 10:21
@krystofwoldrich krystofwoldrich merged commit 08365b9 into main Nov 5, 2024
37 checks passed
@krystofwoldrich krystofwoldrich deleted the kw/internal/clag-format branch November 5, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants