Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Adds macOS privacy info #4174

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Chore: Adds macOS privacy info #4174

merged 1 commit into from
Oct 15, 2024

Conversation

antonis
Copy link
Collaborator

@antonis antonis commented Oct 15, 2024

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Adds macOS PrivacyInfo

💡 Motivation and Context

See #3851 (comment)

💚 How did you test it?

CI, Manual testing

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

@antonis antonis mentioned this pull request Oct 15, 2024
@antonis antonis marked this pull request as ready for review October 15, 2024 10:21
Copy link
Contributor

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1231.59 ms 1240.16 ms 8.57 ms
Size 2.36 MiB 3.09 MiB 742.70 KiB

Baseline results on branch: v6

Startup times

Revision Plain With Sentry Diff
f77a902+dirty 1227.09 ms 1226.74 ms -0.35 ms
2d6b4a9+dirty 1219.80 ms 1229.06 ms 9.26 ms
170d40e+dirty 1232.12 ms 1228.04 ms -4.08 ms
3524c94+dirty 1232.23 ms 1234.77 ms 2.54 ms
1b32c11+dirty 1230.33 ms 1223.96 ms -6.38 ms

App size

Revision Plain With Sentry Diff
f77a902+dirty 2.36 MiB 3.08 MiB 733.32 KiB
2d6b4a9+dirty 2.36 MiB 3.08 MiB 733.23 KiB
170d40e+dirty 2.36 MiB 3.08 MiB 733.66 KiB
3524c94+dirty 2.36 MiB 3.08 MiB 733.61 KiB
1b32c11+dirty 2.36 MiB 3.09 MiB 742.76 KiB

Base automatically changed from v6 to main October 15, 2024 10:54
Copy link
Contributor

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1235.44 ms 1237.43 ms 1.99 ms
Size 2.92 MiB 3.64 MiB 744.11 KiB

Baseline results on branch: v6

Startup times

Revision Plain With Sentry Diff
f77a902+dirty 1223.83 ms 1227.98 ms 4.15 ms
2d6b4a9+dirty 1236.09 ms 1234.84 ms -1.24 ms
170d40e+dirty 1231.92 ms 1226.92 ms -5.00 ms
3524c94+dirty 1230.96 ms 1241.08 ms 10.12 ms
1b32c11+dirty 1235.27 ms 1231.29 ms -3.97 ms

App size

Revision Plain With Sentry Diff
f77a902+dirty 2.92 MiB 3.64 MiB 739.16 KiB
2d6b4a9+dirty 2.92 MiB 3.64 MiB 739.48 KiB
170d40e+dirty 2.92 MiB 3.64 MiB 739.87 KiB
3524c94+dirty 2.92 MiB 3.64 MiB 739.83 KiB
1b32c11+dirty 2.92 MiB 3.64 MiB 744.15 KiB

Copy link
Contributor

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 461.30 ms 455.48 ms -5.82 ms
Size 17.74 MiB 20.07 MiB 2.34 MiB

Baseline results on branch: v6

Startup times

Revision Plain With Sentry Diff
2d6b4a9 484.00 ms 499.49 ms 15.49 ms
f77a902 484.04 ms 487.57 ms 3.53 ms
3524c94 482.39 ms 502.77 ms 20.38 ms
170d40e 442.90 ms 453.70 ms 10.80 ms
1b32c11 433.85 ms 460.04 ms 26.19 ms

App size

Revision Plain With Sentry Diff
2d6b4a9 17.74 MiB 20.06 MiB 2.33 MiB
f77a902 17.74 MiB 20.06 MiB 2.33 MiB
3524c94 17.74 MiB 20.06 MiB 2.33 MiB
170d40e 17.74 MiB 20.06 MiB 2.33 MiB
1b32c11 17.74 MiB 20.07 MiB 2.34 MiB

Copy link
Member

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Contributor

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 479.40 ms 501.35 ms 21.95 ms
Size 7.15 MiB 8.35 MiB 1.20 MiB

Baseline results on branch: v6

Startup times

Revision Plain With Sentry Diff
2d6b4a9+dirty 460.27 ms 519.66 ms 59.39 ms
1b32c11+dirty 418.40 ms 450.74 ms 32.34 ms
3524c94+dirty 389.06 ms 435.58 ms 46.52 ms
170d40e+dirty 430.70 ms 475.38 ms 44.68 ms
f77a902+dirty 478.49 ms 516.40 ms 37.91 ms

App size

Revision Plain With Sentry Diff
2d6b4a9+dirty 7.15 MiB 8.34 MiB 1.19 MiB
1b32c11+dirty 7.15 MiB 8.35 MiB 1.20 MiB
3524c94+dirty 7.15 MiB 8.34 MiB 1.19 MiB
170d40e+dirty 7.15 MiB 8.34 MiB 1.19 MiB
f77a902+dirty 7.15 MiB 8.34 MiB 1.19 MiB

@antonis antonis merged commit 6b07155 into main Oct 15, 2024
63 checks passed
@antonis antonis deleted the antonis/mac-os-privacyinfo branch October 15, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants