Chore: Upgrade sample and E2E tests to RN 0.75 #4155

antonis · 2024-10-07T15:23:54Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

📜 Description

Upgrade E2E tests to RN 0.75
Upgrade sample/react-native to RN 0.75
Removes Flipper from sample/react-native
Fixes an Android legacy sample build issue

⚠️ This PR is based on Release v6 due to the fact that the macOS sample split is needed for the update.

⚠️ We should consider before merging if we want the changes on v6. If not we should wait for the release branch to be merged back on main

💡 Motivation and Context

Fixes #4139 and #4152

💚 How did you test it?

Manual local testing and CI checks

📝 Checklist

I reviewed submitted code
I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
All tests passing
No breaking changes

🔮 Next steps

#skip-changelog

rwachtler · 2024-10-08T10:57:15Z

@antonis 👋 Hey, you might have already noticed this as well, but when executing yarn build (being on 0.75.4) from the main sentry-react-native folder, I run into following TS error.

Type '{ major: number; minor: number; patch: number; prerelease?: string | number | null | undefined; }' is not assignable to type '{ major: number; minor: number; patch: number; prerelease?: number | null | undefined; }'.
  Types of property 'prerelease' are incompatible.
    Type 'string | number | null | undefined' is not assignable to type 'number | null | undefined'.
      Type 'string' is not assignable to type 'number'.

34     version: Platform.constants?.reactNativeVersion,
       ~~~~~~~

  src/js/vendor/react-native/index.ts:76:3
    76   version: {
         ~~~~~~~
    The expected type comes from property 'version' which is declared here on type 'ReactNativeVersion'

Due a type mismatch in here. It looks like the type of the prerelease property has been updated from number | null | undefined; to string | null | undefined; within react-native in this PR.

antonis · 2024-10-08T11:13:43Z

Thank you for the heads up @rwachtler 🙇
I'll look into this along with the upgrade.

# Conflicts: # samples/react-native/package.json

github-actions · 2024-10-08T14:37:54Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	432.67 ms	473.94 ms	41.27 ms
Size	17.74 MiB	20.07 MiB	2.34 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`e73d82f`	475.82 ms	506.55 ms	30.73 ms
`0ebca77`	414.93 ms	444.49 ms	29.56 ms
`484813b`	434.55 ms	452.31 ms	17.75 ms
`e540498`	436.26 ms	433.00 ms	-3.26 ms
`acadc0f`+dirty	373.24 ms	381.51 ms	8.27 ms
`70e6261`	482.65 ms	495.70 ms	13.05 ms
`b1e8712`	462.11 ms	465.71 ms	3.60 ms
`0677344`	327.74 ms	337.14 ms	9.40 ms
`3ffcddd`	302.92 ms	315.80 ms	12.88 ms
`728164b`	414.34 ms	449.22 ms	34.88 ms

App size

Revision	Plain	With Sentry	Diff
`e73d82f`	17.73 MiB	20.07 MiB	2.33 MiB
`0ebca77`	17.73 MiB	19.95 MiB	2.21 MiB
`484813b`	17.73 MiB	20.07 MiB	2.33 MiB
`e540498`	17.73 MiB	20.11 MiB	2.37 MiB
`acadc0f`+dirty	17.73 MiB	19.75 MiB	2.01 MiB
`70e6261`	17.73 MiB	19.94 MiB	2.21 MiB
`b1e8712`	17.73 MiB	19.75 MiB	2.02 MiB
`0677344`	17.73 MiB	19.81 MiB	2.07 MiB
`3ffcddd`	17.73 MiB	19.75 MiB	2.02 MiB
`728164b`	17.73 MiB	19.85 MiB	2.12 MiB

Previous results on branch: antonis/rn-0.75.4-no-flipper

Startup times

Revision	Plain	With Sentry	Diff
`2af07d9`	499.36 ms	503.86 ms	4.50 ms
`5e47d60`	487.96 ms	477.58 ms	-10.38 ms
`09f796f`	481.48 ms	485.34 ms	3.86 ms
`6f56d09`	456.56 ms	460.13 ms	3.57 ms
`8f69ce2`	577.67 ms	598.06 ms	20.40 ms
`03d7842`	345.12 ms	353.26 ms	8.14 ms

App size

Revision	Plain	With Sentry	Diff
`2af07d9`	17.74 MiB	20.06 MiB	2.33 MiB
`5e47d60`	17.74 MiB	20.07 MiB	2.34 MiB
`09f796f`	17.74 MiB	20.06 MiB	2.33 MiB
`6f56d09`	17.74 MiB	20.06 MiB	2.33 MiB
`8f69ce2`	17.74 MiB	20.06 MiB	2.33 MiB
`03d7842`	17.74 MiB	20.06 MiB	2.33 MiB

github-actions · 2024-10-08T14:50:47Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1214.90 ms	1210.11 ms	-4.79 ms
Size	2.36 MiB	3.09 MiB	742.66 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`e5c9b8b`+dirty	1258.57 ms	1267.32 ms	8.75 ms
`0db0c72`+dirty	1275.02 ms	1285.84 ms	10.82 ms
`76d1baf`+dirty	1244.10 ms	1268.52 ms	24.42 ms
`1c65324`+dirty	1235.17 ms	1235.08 ms	-0.09 ms
`e2b64fe`+dirty	1232.22 ms	1255.20 ms	22.98 ms
`8900e1a`+dirty	1210.27 ms	1218.66 ms	8.39 ms
`5571a20`+dirty	1203.57 ms	1204.57 ms	1.00 ms
`e73f4ed`+dirty	1243.27 ms	1244.52 ms	1.25 ms
`e73d82f`+dirty	1207.52 ms	1216.73 ms	9.21 ms
`d7401ac`+dirty	1252.38 ms	1275.04 ms	22.66 ms

App size

Revision	Plain	With Sentry	Diff
`e5c9b8b`+dirty	2.36 MiB	2.87 MiB	520.43 KiB
`0db0c72`+dirty	2.36 MiB	2.84 MiB	487.01 KiB
`76d1baf`+dirty	2.36 MiB	2.82 MiB	469.45 KiB
`1c65324`+dirty	2.36 MiB	3.04 MiB	698.64 KiB
`e2b64fe`+dirty	2.36 MiB	2.85 MiB	495.80 KiB
`8900e1a`+dirty	2.36 MiB	2.83 MiB	479.25 KiB
`5571a20`+dirty	2.36 MiB	2.92 MiB	569.93 KiB
`e73f4ed`+dirty	2.36 MiB	2.82 MiB	469.44 KiB
`e73d82f`+dirty	2.36 MiB	3.08 MiB	734.23 KiB
`d7401ac`+dirty	2.36 MiB	2.83 MiB	481.14 KiB

Previous results on branch: antonis/rn-0.75.4-no-flipper

Startup times

Revision	Plain	With Sentry	Diff
`6f56d09`+dirty	1231.18 ms	1236.79 ms	5.61 ms
`03d7842`+dirty	1222.02 ms	1232.84 ms	10.82 ms
`8f69ce2`+dirty	1211.06 ms	1214.98 ms	3.92 ms
`5e47d60`+dirty	1223.51 ms	1222.85 ms	-0.66 ms
`09f796f`+dirty	1222.62 ms	1224.69 ms	2.07 ms
`2af07d9`+dirty	1230.71 ms	1232.44 ms	1.74 ms

App size

Revision	Plain	With Sentry	Diff
`6f56d09`+dirty	2.36 MiB	3.08 MiB	733.60 KiB
`03d7842`+dirty	2.36 MiB	3.08 MiB	733.56 KiB
`8f69ce2`+dirty	2.36 MiB	3.08 MiB	733.55 KiB
`5e47d60`+dirty	2.36 MiB	3.09 MiB	742.34 KiB
`09f796f`+dirty	2.36 MiB	3.08 MiB	733.51 KiB
`2af07d9`+dirty	2.36 MiB	3.08 MiB	733.57 KiB

github-actions · 2024-10-08T14:55:26Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	417.65 ms	462.39 ms	44.74 ms
Size	7.15 MiB	8.35 MiB	1.20 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`700cbf4`+dirty	411.71 ms	485.52 ms	73.81 ms
`acadc0f`+dirty	259.04 ms	304.67 ms	45.63 ms
`e5c9b8b`+dirty	335.40 ms	360.06 ms	24.67 ms
`728164b`+dirty	335.93 ms	342.94 ms	7.01 ms
`abb7058`+dirty	320.78 ms	324.08 ms	3.30 ms
`27ef4ee`+dirty	296.71 ms	351.00 ms	54.29 ms
`22e31b6`+dirty	295.75 ms	346.73 ms	50.98 ms
`9c48b2c`+dirty	270.82 ms	321.12 ms	50.30 ms
`15c80ab`+dirty	276.38 ms	327.54 ms	51.17 ms
`1d86dd6`+dirty	335.76 ms	371.22 ms	35.46 ms

App size

Revision	Plain	With Sentry	Diff
`700cbf4`+dirty	7.15 MiB	8.34 MiB	1.19 MiB
`acadc0f`+dirty	7.15 MiB	8.03 MiB	903.20 KiB
`e5c9b8b`+dirty	7.15 MiB	8.10 MiB	980.41 KiB
`728164b`+dirty	7.15 MiB	8.12 MiB	997.71 KiB
`abb7058`+dirty	7.15 MiB	8.10 MiB	980.40 KiB
`27ef4ee`+dirty	7.15 MiB	8.08 MiB	959.49 KiB
`22e31b6`+dirty	7.15 MiB	8.10 MiB	981.29 KiB
`9c48b2c`+dirty	7.15 MiB	8.07 MiB	947.16 KiB
`15c80ab`+dirty	7.15 MiB	8.09 MiB	966.13 KiB
`1d86dd6`+dirty	7.15 MiB	8.13 MiB	1002.18 KiB

Previous results on branch: antonis/rn-0.75.4-no-flipper

Startup times

Revision	Plain	With Sentry	Diff
`6f56d09`+dirty	388.76 ms	421.58 ms	32.82 ms
`2af07d9`+dirty	389.92 ms	426.21 ms	36.29 ms
`09f796f`+dirty	391.98 ms	451.30 ms	59.32 ms
`8f69ce2`+dirty	411.39 ms	456.56 ms	45.17 ms
`03d7842`+dirty	382.43 ms	426.12 ms	43.69 ms
`5e47d60`+dirty	402.10 ms	417.96 ms	15.86 ms

App size

Revision	Plain	With Sentry	Diff
`6f56d09`+dirty	7.15 MiB	8.34 MiB	1.19 MiB
`2af07d9`+dirty	7.15 MiB	8.34 MiB	1.19 MiB
`09f796f`+dirty	7.15 MiB	8.34 MiB	1.19 MiB
`8f69ce2`+dirty	7.15 MiB	8.34 MiB	1.19 MiB
`03d7842`+dirty	7.15 MiB	8.34 MiB	1.19 MiB
`5e47d60`+dirty	7.15 MiB	8.35 MiB	1.20 MiB

github-actions · 2024-10-08T15:09:08Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1227.57 ms	1225.27 ms	-2.29 ms
Size	2.92 MiB	3.64 MiB	744.07 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`e5c9b8b`+dirty	1276.90 ms	1280.92 ms	4.02 ms
`0db0c72`+dirty	1258.88 ms	1262.52 ms	3.64 ms
`76d1baf`+dirty	1245.00 ms	1257.76 ms	12.76 ms
`1c65324`+dirty	1239.71 ms	1239.86 ms	0.15 ms
`e2b64fe`+dirty	1285.78 ms	1297.56 ms	11.78 ms
`8900e1a`+dirty	1268.36 ms	1273.04 ms	4.68 ms
`5571a20`+dirty	1228.09 ms	1233.45 ms	5.36 ms
`e73f4ed`+dirty	1282.90 ms	1309.30 ms	26.40 ms
`e73d82f`+dirty	1231.20 ms	1228.81 ms	-2.40 ms
`d7401ac`+dirty	1288.10 ms	1289.54 ms	1.44 ms

App size

Revision	Plain	With Sentry	Diff
`e5c9b8b`+dirty	2.92 MiB	3.43 MiB	524.50 KiB
`0db0c72`+dirty	2.92 MiB	3.40 MiB	492.71 KiB
`76d1baf`+dirty	2.92 MiB	3.38 MiB	475.74 KiB
`1c65324`+dirty	2.92 MiB	3.61 MiB	705.56 KiB
`e2b64fe`+dirty	2.92 MiB	3.41 MiB	499.97 KiB
`8900e1a`+dirty	2.92 MiB	3.39 MiB	485.96 KiB
`5571a20`+dirty	2.92 MiB	3.48 MiB	575.54 KiB
`e73f4ed`+dirty	2.92 MiB	3.38 MiB	475.71 KiB
`e73d82f`+dirty	2.92 MiB	3.64 MiB	740.56 KiB
`d7401ac`+dirty	2.92 MiB	3.40 MiB	488.06 KiB

Previous results on branch: antonis/rn-0.75.4-no-flipper

Startup times

Revision	Plain	With Sentry	Diff
`6f56d09`+dirty	1244.29 ms	1243.61 ms	-0.68 ms
`03d7842`+dirty	1238.23 ms	1241.08 ms	2.85 ms
`8f69ce2`+dirty	1225.96 ms	1235.49 ms	9.53 ms
`5e47d60`+dirty	1233.71 ms	1233.22 ms	-0.49 ms
`09f796f`+dirty	1229.16 ms	1214.74 ms	-14.42 ms
`2af07d9`+dirty	1237.73 ms	1234.75 ms	-2.98 ms

App size

Revision	Plain	With Sentry	Diff
`6f56d09`+dirty	2.92 MiB	3.64 MiB	739.85 KiB
`03d7842`+dirty	2.92 MiB	3.64 MiB	739.81 KiB
`8f69ce2`+dirty	2.92 MiB	3.64 MiB	739.81 KiB
`5e47d60`+dirty	2.92 MiB	3.64 MiB	743.91 KiB
`09f796f`+dirty	2.92 MiB	3.64 MiB	739.84 KiB
`2af07d9`+dirty	2.92 MiB	3.64 MiB	739.88 KiB

.github/workflows/sample-application.yml

samples/react-native/android/app/src/main/jni/CMakeLists.txt

samples/react-native/ios/Podfile

CHANGELOG.md

Co-authored-by: LucasZF <[email protected]>

.github/workflows/testflight.yml

samples/react-native/ios/sentryreactnativesample/PrivacyInfo.xcprivacy

krystofwoldrich · 2024-10-14T15:21:57Z

Let's also update packages/core to RN 0.75

Co-authored-by: Krystof Woldrich <[email protected]>

lucas-zimerman

Looks good to me, LGTM!

krystofwoldrich

Looks good. Thank you!

antonis · 2024-10-15T07:35:12Z

@krystofwoldrich @lucas-zimerman Just a heads up that I haven't wrapped up the packages/core update to RN 0.75 but I think it would be better handled in a separate PR.

Should we wait for #4155 before merging?

Regarding this question from the v6 PR, I think it is safe in the current state that only updates the e2e tests and samples.

antonis · 2024-10-15T08:54:40Z

Let's also update packages/core to RN 0.75

Opened a separate PR for this #4173

antonis · 2024-10-15T10:25:25Z

⚠️ Decided to merge after V6 is merged

krystofwoldrich · 2024-10-15T14:16:19Z

Since V6 is merged in main, we can just resolved the conflict, likely just formatting from the added java lint. And we can merge this as well.

# Conflicts: # samples/react-native/android/app/src/release/java/io/sentry/reactnative/sample/ReactNativeFlipper.java

antonis added 4 commits October 7, 2024 18:20

Updates RN to 0.75.4 in the sample app and E2E test

4a409cb

Removes Flipper from iOS

3ff1e71

Revert changes in the test apps for now

a5ef6c8

Update e2e tests dependencies

a67410e

antonis added 5 commits October 8, 2024 16:00

Updates Android sample

03608cf

Updates iOS sample

44e1e0b

Merge branch 'v6' into antonis/rn-0.75.4-no-flipper

dddcaad

# Conflicts: # samples/react-native/package.json

Updates lockfile

4acda45

Updates changelog

2c6e9e6

antonis added 6 commits October 8, 2024 18:37

Adds codegen missing targetPlatform parameter

2a51888

Fixes lint issue (see facebook/react-native#33955)

86990ed

enable corepack in testflight dependencies step

d0a8a29

Sets the newArchEnabled=false for legacy builds

ce4ed26

enable corepack in testflight build step

9c3480c

Enable corepack in a separate step

21228bd

antonis commented Oct 9, 2024

View reviewed changes

.github/workflows/sample-application.yml Show resolved Hide resolved

antonis added 3 commits October 9, 2024 11:29

Removes corepack step

47d108d

Updates OnLoad.cpp and CMakeList.txt to match the RN version samples

1ca6390

Enable corepack and remove cache check

83169cc

This was linked to issues Oct 9, 2024

Upgrade sample and E2E tests to RN 0.75 #4139

Closed

Remove Flipper #4152

Closed

antonis marked this pull request as ready for review October 9, 2024 12:53

antonis requested a review from lucas-zimerman as a code owner October 9, 2024 12:53

antonis requested a review from krystofwoldrich October 9, 2024 12:53

lucas-zimerman reviewed Oct 11, 2024

View reviewed changes

samples/react-native/android/app/src/main/jni/CMakeLists.txt Outdated Show resolved Hide resolved

lucas-zimerman reviewed Oct 11, 2024

View reviewed changes

samples/react-native/ios/Podfile Show resolved Hide resolved

lucas-zimerman reviewed Oct 11, 2024

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

antonis and others added 3 commits October 11, 2024 10:43

Remove changelog

9b6f84e

Co-authored-by: LucasZF <[email protected]>

Reverts CMakeLists.txt change

3b165dc

Reverts code removal

e5a1bb2

antonis requested a review from lucas-zimerman October 11, 2024 09:07

krystofwoldrich reviewed Oct 14, 2024

View reviewed changes

.github/workflows/testflight.yml Show resolved Hide resolved

antonis mentioned this pull request Oct 14, 2024

Explore using CCache to speed up iOS builds #4170

Open

krystofwoldrich reviewed Oct 14, 2024

View reviewed changes

samples/react-native/ios/sentryreactnativesample/PrivacyInfo.xcprivacy Outdated Show resolved Hide resolved

antonis and others added 3 commits October 14, 2024 18:53

Update yarn cache in testflight build

9497914

Co-authored-by: Krystof Woldrich <[email protected]>

Updates PrivacyInfo

c45761a

Merge branch 'v6' into antonis/rn-0.75.4-no-flipper

9a717b3

lucas-zimerman approved these changes Oct 14, 2024

View reviewed changes

lucas-zimerman mentioned this pull request Oct 14, 2024

V6 Release #3851

Merged

krystofwoldrich approved these changes Oct 15, 2024

View reviewed changes

antonis added a commit that referenced this pull request Oct 15, 2024

Fixes prerelease property type (see #4155 (comment))

c32f8cb

antonis mentioned this pull request Oct 15, 2024

Chore: Upgrade core to RN 0.75 #4173

Open

9 tasks

Base automatically changed from v6 to main October 15, 2024 10:54

krystofwoldrich and others added 2 commits October 15, 2024 16:44

misc(ci): Remove unused testflight node_modules cache (#4178)

f4105bd

Merge branch 'main' into antonis/rn-0.75.4-no-flipper

49408ec

Merge branch 'main' into antonis/rn-0.75.4-no-flipper

31054a9

# Conflicts: # samples/react-native/android/app/src/release/java/io/sentry/reactnative/sample/ReactNativeFlipper.java

antonis merged commit 3b4dd9c into main Oct 16, 2024
65 checks passed

antonis deleted the antonis/rn-0.75.4-no-flipper branch October 16, 2024 04:27

antonis mentioned this pull request Oct 17, 2024

Android Sample Application New Architecture Crash with RN 0.75 when profiling is enabled #4188

Open

Chore: Upgrade sample and E2E tests to RN 0.75 #4155

Chore: Upgrade sample and E2E tests to RN 0.75 #4155

Conversation

antonis commented Oct 7, 2024 • edited Loading

📢 Type of change

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

rwachtler commented Oct 8, 2024 • edited Loading

antonis commented Oct 8, 2024

github-actions bot commented Oct 8, 2024 • edited Loading

Android (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: antonis/rn-0.75.4-no-flipper

Startup times

App size

github-actions bot commented Oct 8, 2024 • edited Loading

iOS (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: antonis/rn-0.75.4-no-flipper

Startup times

App size

github-actions bot commented Oct 8, 2024 • edited Loading

Android (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: antonis/rn-0.75.4-no-flipper

Startup times

App size

github-actions bot commented Oct 8, 2024 • edited Loading

iOS (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: antonis/rn-0.75.4-no-flipper

Startup times

App size

krystofwoldrich commented Oct 14, 2024

lucas-zimerman left a comment

Choose a reason for hiding this comment

krystofwoldrich left a comment

Choose a reason for hiding this comment

antonis commented Oct 15, 2024

antonis commented Oct 15, 2024

antonis commented Oct 15, 2024

krystofwoldrich commented Oct 15, 2024

antonis commented Oct 7, 2024 •

edited

Loading

rwachtler commented Oct 8, 2024 •

edited

Loading

github-actions bot commented Oct 8, 2024 •

edited

Loading

github-actions bot commented Oct 8, 2024 •

edited

Loading

github-actions bot commented Oct 8, 2024 •

edited

Loading

github-actions bot commented Oct 8, 2024 •

edited

Loading