Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(replay): Mask RCTParagraphComponentView when maskAllText enabled #4048

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

krystofwoldrich
Copy link
Member

@krystofwoldrich krystofwoldrich commented Aug 26, 2024

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

This PR adds missing RN text class to array of redacted text classes.

Screenshot 2024-08-26 at 18 10 54

💚 How did you test it?

sample app

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

Copy link
Contributor

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 509.10 ms 616.06 ms 106.96 ms
Size 7.15 MiB 8.34 MiB 1.19 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d197b5c+dirty 258.75 ms 313.61 ms 54.86 ms
70caa60+dirty 308.83 ms 393.06 ms 84.23 ms
80b2ce3+dirty 271.29 ms 316.47 ms 45.18 ms
6e8584e+dirty 383.37 ms 400.84 ms 17.47 ms
62a750b+dirty 370.78 ms 376.73 ms 5.96 ms
15c80ab+dirty 276.38 ms 327.54 ms 51.17 ms
5bb8d5f+dirty 356.71 ms 389.65 ms 32.94 ms
8900e1a+dirty 371.40 ms 377.70 ms 6.31 ms
9c48b2c+dirty 270.82 ms 321.12 ms 50.30 ms
e73f4ed+dirty 262.98 ms 311.02 ms 48.04 ms

App size

Revision Plain With Sentry Diff
d197b5c+dirty 7.15 MiB 8.09 MiB 962.72 KiB
70caa60+dirty 7.15 MiB 8.03 MiB 901.79 KiB
80b2ce3+dirty 7.15 MiB 8.04 MiB 911.02 KiB
6e8584e+dirty 7.15 MiB 8.13 MiB 1002.18 KiB
62a750b+dirty 7.15 MiB 8.21 MiB 1.06 MiB
15c80ab+dirty 7.15 MiB 8.09 MiB 966.13 KiB
5bb8d5f+dirty 7.15 MiB 8.21 MiB 1.06 MiB
8900e1a+dirty 7.15 MiB 8.03 MiB 901.79 KiB
9c48b2c+dirty 7.15 MiB 8.07 MiB 947.16 KiB
e73f4ed+dirty 7.15 MiB 8.09 MiB 965.94 KiB

Copy link
Contributor

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1214.52 ms 1225.19 ms 10.67 ms
Size 2.36 MiB 3.08 MiB 734.00 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
5446992+dirty 1273.28 ms 1276.68 ms 3.40 ms
c398f67+dirty 1219.67 ms 1225.66 ms 5.99 ms
d197b5c+dirty 1217.61 ms 1242.66 ms 25.05 ms
575f9da+dirty 1266.22 ms 1274.84 ms 8.62 ms
9c48b2c+dirty 1246.96 ms 1255.73 ms 8.77 ms
b1e8712+dirty 1256.02 ms 1265.14 ms 9.12 ms
1c65324+dirty 1235.17 ms 1235.08 ms -0.09 ms
76d1baf+dirty 1244.10 ms 1268.52 ms 24.42 ms
62a750b+dirty 1216.60 ms 1229.14 ms 12.54 ms
e5c9b8b+dirty 1258.57 ms 1267.32 ms 8.75 ms

App size

Revision Plain With Sentry Diff
5446992+dirty 2.36 MiB 2.88 MiB 531.94 KiB
c398f67+dirty 2.36 MiB 3.04 MiB 696.27 KiB
d197b5c+dirty 2.36 MiB 2.82 MiB 462.86 KiB
575f9da+dirty 2.36 MiB 2.87 MiB 520.20 KiB
9c48b2c+dirty 2.36 MiB 2.85 MiB 495.77 KiB
b1e8712+dirty 2.36 MiB 2.84 MiB 488.84 KiB
1c65324+dirty 2.36 MiB 3.04 MiB 698.64 KiB
76d1baf+dirty 2.36 MiB 2.82 MiB 469.45 KiB
62a750b+dirty 2.36 MiB 2.92 MiB 570.00 KiB
e5c9b8b+dirty 2.36 MiB 2.87 MiB 520.43 KiB

Copy link
Contributor

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1242.85 ms 1241.50 ms -1.35 ms
Size 2.92 MiB 3.64 MiB 739.75 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
5446992+dirty 1249.94 ms 1254.80 ms 4.86 ms
c398f67+dirty 1227.31 ms 1230.00 ms 2.69 ms
d197b5c+dirty 1234.80 ms 1249.20 ms 14.40 ms
575f9da+dirty 1272.00 ms 1284.38 ms 12.38 ms
9c48b2c+dirty 1253.39 ms 1256.30 ms 2.91 ms
b1e8712+dirty 1284.11 ms 1297.82 ms 13.71 ms
1c65324+dirty 1239.71 ms 1239.86 ms 0.15 ms
76d1baf+dirty 1245.00 ms 1257.76 ms 12.76 ms
62a750b+dirty 1228.12 ms 1230.53 ms 2.41 ms
e5c9b8b+dirty 1276.90 ms 1280.92 ms 4.02 ms

App size

Revision Plain With Sentry Diff
5446992+dirty 2.92 MiB 3.44 MiB 535.26 KiB
c398f67+dirty 2.92 MiB 3.60 MiB 701.89 KiB
d197b5c+dirty 2.92 MiB 3.37 MiB 464.41 KiB
575f9da+dirty 2.92 MiB 3.43 MiB 524.26 KiB
9c48b2c+dirty 2.92 MiB 3.41 MiB 499.97 KiB
b1e8712+dirty 2.92 MiB 3.40 MiB 494.15 KiB
1c65324+dirty 2.92 MiB 3.61 MiB 705.56 KiB
76d1baf+dirty 2.92 MiB 3.38 MiB 475.74 KiB
62a750b+dirty 2.92 MiB 3.48 MiB 575.59 KiB
e5c9b8b+dirty 2.92 MiB 3.43 MiB 524.50 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants