fix(metro): Fix `sourceMapString` is not a function, support `[email protected]` #4004

krystofwoldrich · 2024-08-08T16:57:19Z

📢 Type of change

Bugfix

📜 Description

This PR fixes sourceMapString is not a function error which happens due to changes in [email protected].

The changes facebook/metro@v0.80.9...v0.80.10#diff-1b836d1729e527a725305eef0cec22e44605af2700fa413f4c2489ea1a03aebcL28

At [email protected]

module.exports = sourceMapString;

At [email protected]

module.exports = {
  sourceMapString,
  sourceMapStringNonBlocking,
};

This PR also adds a new error message in case the expor would change in the future.

💚 How did you test it?

sample app, ci

📝 Checklist

I reviewed submitted code
I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
All tests passing
No breaking changes

….80.10`

github-actions · 2024-08-08T17:24:52Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1230.24 ms	1227.68 ms	-2.56 ms
Size	2.92 MiB	3.62 MiB	719.93 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`86d6d2c`+dirty	1291.62 ms	1296.80 ms	5.18 ms
`e2b64fe`+dirty	1285.78 ms	1297.56 ms	11.78 ms
`9433f35`+dirty	1232.24 ms	1232.74 ms	0.50 ms
`4a6664f`+dirty	1218.77 ms	1221.07 ms	2.30 ms
`80b2ce3`+dirty	1245.12 ms	1262.04 ms	16.92 ms
`dadc233`+dirty	1266.52 ms	1282.55 ms	16.03 ms
`f06c879`+dirty	1285.14 ms	1285.86 ms	0.72 ms
`5a22220`+dirty	1246.18 ms	1249.61 ms	3.43 ms
`3853f43`+dirty	1271.74 ms	1278.04 ms	6.30 ms
`8900e1a`+dirty	1268.36 ms	1273.04 ms	4.68 ms

App size

Revision	Plain	With Sentry	Diff
`86d6d2c`+dirty	2.92 MiB	3.37 MiB	464.31 KiB
`e2b64fe`+dirty	2.92 MiB	3.41 MiB	499.97 KiB
`9433f35`+dirty	2.92 MiB	3.41 MiB	503.55 KiB
`4a6664f`+dirty	2.92 MiB	3.60 MiB	702.09 KiB
`80b2ce3`+dirty	2.92 MiB	3.40 MiB	492.75 KiB
`dadc233`+dirty	2.92 MiB	3.40 MiB	492.53 KiB
`f06c879`+dirty	2.92 MiB	3.44 MiB	533.24 KiB
`5a22220`+dirty	2.92 MiB	3.48 MiB	575.81 KiB
`3853f43`+dirty	2.92 MiB	3.41 MiB	503.54 KiB
`8900e1a`+dirty	2.92 MiB	3.39 MiB	485.96 KiB

github-actions · 2024-08-08T17:26:35Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1212.88 ms	1222.71 ms	9.83 ms
Size	2.36 MiB	3.06 MiB	718.26 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`86d6d2c`+dirty	1267.55 ms	1286.21 ms	18.66 ms
`e2b64fe`+dirty	1232.22 ms	1255.20 ms	22.98 ms
`9433f35`+dirty	1246.94 ms	1271.45 ms	24.52 ms
`4a6664f`+dirty	1209.49 ms	1208.63 ms	-0.86 ms
`80b2ce3`+dirty	1265.92 ms	1268.60 ms	2.69 ms
`dadc233`+dirty	1223.20 ms	1236.88 ms	13.68 ms
`f06c879`+dirty	1252.64 ms	1259.66 ms	7.02 ms
`5a22220`+dirty	1209.49 ms	1220.94 ms	11.45 ms
`3853f43`+dirty	1221.82 ms	1242.64 ms	20.82 ms
`8900e1a`+dirty	1210.27 ms	1218.66 ms	8.39 ms

App size

Revision	Plain	With Sentry	Diff
`86d6d2c`+dirty	2.36 MiB	2.82 MiB	462.82 KiB
`e2b64fe`+dirty	2.36 MiB	2.85 MiB	495.80 KiB
`9433f35`+dirty	2.36 MiB	2.85 MiB	499.80 KiB
`4a6664f`+dirty	2.36 MiB	3.04 MiB	696.39 KiB
`80b2ce3`+dirty	2.36 MiB	2.84 MiB	486.98 KiB
`dadc233`+dirty	2.36 MiB	2.84 MiB	486.85 KiB
`f06c879`+dirty	2.36 MiB	2.88 MiB	530.42 KiB
`5a22220`+dirty	2.36 MiB	2.92 MiB	570.21 KiB
`3853f43`+dirty	2.36 MiB	2.85 MiB	499.81 KiB
`8900e1a`+dirty	2.36 MiB	2.83 MiB	479.25 KiB

vaind · 2024-08-08T18:24:56Z

src/js/tools/vendor/metro/utils.ts

+    let sourceMapStringFunction;
+    if (typeof sourceMapString === 'function') {
+      sourceMapStringFunction = sourceMapString;
+    } else if (typeof (sourceMapString as NewSourceMapStringExport).sourceMapString === 'function') {


can (sourceMapString as NewSourceMapStringExport) be undefined here in a future version of metro/RN?

Yes, that's a good one. Ill add a check for it.

github-actions · 2024-08-08T21:51:22Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	333.88 ms	357.20 ms	23.32 ms
Size	17.73 MiB	20.06 MiB	2.33 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`27ef4ee`	317.40 ms	321.70 ms	4.30 ms
`6e8584e`	447.10 ms	474.71 ms	27.61 ms
`148f924`	492.65 ms	500.28 ms	7.63 ms
`34aba08`	328.10 ms	342.84 ms	14.74 ms
`70e6261`	482.65 ms	495.70 ms	13.05 ms
`575f9da`	415.26 ms	422.98 ms	7.72 ms
`1c65324`	426.37 ms	460.36 ms	33.99 ms
`15c80ab`+dirty	336.27 ms	350.58 ms	14.31 ms
`1d86dd6`	405.14 ms	411.06 ms	5.92 ms
`31fcca2`	391.22 ms	414.78 ms	23.56 ms

App size

Revision	Plain	With Sentry	Diff
`27ef4ee`	17.73 MiB	19.82 MiB	2.08 MiB
`6e8584e`	17.73 MiB	19.86 MiB	2.12 MiB
`148f924`	17.73 MiB	19.94 MiB	2.21 MiB
`34aba08`	17.73 MiB	19.80 MiB	2.07 MiB
`70e6261`	17.73 MiB	19.94 MiB	2.21 MiB
`575f9da`	17.73 MiB	19.83 MiB	2.10 MiB
`1c65324`	17.73 MiB	19.95 MiB	2.21 MiB
`15c80ab`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`1d86dd6`	17.73 MiB	19.86 MiB	2.12 MiB
`31fcca2`	17.73 MiB	19.90 MiB	2.17 MiB

lucas-zimerman

LGTM!

….10 (see #4004)

* Bumps cocoa from 8.29.1 to 8.36.0 * removed duplicate SentryTraceHeader definition * Update CHANGELOG.md * fix(metro): Fix sourceMapString is not a function, support [email protected] (see #4004) * misc: Update to RN 0.73.9, fix CI flipper error (see #3981) * use fixed version of react-native-gesture-handler --------- Co-authored-by: lucas <[email protected]>

fix(metro): Fix sourceMapString is not a function, support `metro@0…

c0b4b96

….80.10`

krystofwoldrich requested a review from lucas-zimerman as a code owner August 8, 2024 16:57

add changelog and incompatibility error message

d553969

krystofwoldrich requested a review from vaind August 8, 2024 17:16

vaind reviewed Aug 8, 2024

View reviewed changes

vaind approved these changes Aug 8, 2024

View reviewed changes

fix possible undefined sourceMapString

fb87955

lucas-zimerman approved these changes Aug 9, 2024

View reviewed changes

lucas-zimerman merged commit 2e724f8 into main Aug 9, 2024
59 of 62 checks passed

lucas-zimerman deleted the kw/fix-metro-80-10-source-map-export branch August 9, 2024 01:49

This was referenced Aug 12, 2024

(6) fix(tracing): ReactNativeTracing and initial navigation spans have to be created after integrations setup #4000

Merged

sourceMapString is not a function [v5.28.0] #4005

Closed

antonis mentioned this pull request Sep 19, 2024

chore(deps): Hotfix: update Cocoa SDK from 8.29.1 to 8.36.0 #4102

Merged

antonis pushed a commit that referenced this pull request Sep 19, 2024

fix(metro): Fix sourceMapString is not a function, support [email protected]…

8e75670

….10 (see #4004)

antonis added a commit that referenced this pull request Sep 19, 2024

fix(metro): Fix sourceMapString is not a function, support [email protected]…

2ab5534

….10 (see #4004)

antonis added a commit that referenced this pull request Sep 19, 2024

fix(metro): Fix sourceMapString is not a function, support [email protected]…

a0e0d80

….10 (see #4004)

antonis added a commit that referenced this pull request Sep 19, 2024

fix(metro): Fix sourceMapString is not a function, support [email protected]…

b2c1497

….10 (see #4004)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(metro): Fix `sourceMapString` is not a function, support `[email protected]` #4004

fix(metro): Fix `sourceMapString` is not a function, support `[email protected]` #4004

krystofwoldrich commented Aug 8, 2024

github-actions bot commented Aug 8, 2024 •

edited

Loading

Baseline results on branch: main

Startup times

App size

github-actions bot commented Aug 8, 2024 •

edited

Loading

Baseline results on branch: main

Startup times

App size

vaind Aug 8, 2024

krystofwoldrich Aug 8, 2024

github-actions bot commented Aug 8, 2024

Baseline results on branch: main

Startup times

App size

lucas-zimerman left a comment

fix(metro): Fix sourceMapString is not a function, support [email protected] #4004

fix(metro): Fix sourceMapString is not a function, support [email protected] #4004

Conversation

krystofwoldrich commented Aug 8, 2024

📢 Type of change

📜 Description

💚 How did you test it?

📝 Checklist

github-actions bot commented Aug 8, 2024 • edited Loading

iOS (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

github-actions bot commented Aug 8, 2024 • edited Loading

iOS (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

vaind Aug 8, 2024

Choose a reason for hiding this comment

krystofwoldrich Aug 8, 2024

Choose a reason for hiding this comment

github-actions bot commented Aug 8, 2024

Android (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

lucas-zimerman left a comment

Choose a reason for hiding this comment

fix(metro): Fix `sourceMapString` is not a function, support `[email protected]` #4004

fix(metro): Fix `sourceMapString` is not a function, support `[email protected]` #4004

github-actions bot commented Aug 8, 2024 •

edited

Loading

github-actions bot commented Aug 8, 2024 •

edited

Loading