Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expo: sentry-expo-upload-sourcemaps no longer requires sentry url #3915

Merged
merged 4 commits into from
Jun 26, 2024

Conversation

lucas-zimerman
Copy link
Collaborator

@lucas-zimerman lucas-zimerman commented Jun 25, 2024

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Instead of throwing an error, use https://sentry.io/ when SENTRY_URL is not set.

💡 Motivation and Context

Users want to not define the default url for saas ( I believe this is the same behavior as sentry cli so it is a nice pattern to follow).

💚 How did you test it?

Locally running sentry-expo-upload-sourcemaps without a defined url.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

🔮 Next steps

Closes: #3792

Copy link
Contributor

github-actions bot commented Jun 25, 2024

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 411.82 ms 435.66 ms 23.84 ms
Size 17.73 MiB 19.94 MiB 2.21 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
abb7058 370.27 ms 389.58 ms 19.31 ms
12427f4 393.69 ms 414.84 ms 21.14 ms
86d6d2c+dirty 332.90 ms 352.45 ms 19.55 ms
15c80ab+dirty 336.27 ms 350.58 ms 14.31 ms
2534337 394.15 ms 415.12 ms 20.97 ms
3853f43 329.68 ms 346.32 ms 16.64 ms
457e29f 398.10 ms 421.39 ms 23.29 ms
5571a20 410.55 ms 441.06 ms 30.51 ms
31fcca2 391.22 ms 414.78 ms 23.56 ms
34aba08 328.10 ms 342.84 ms 14.74 ms

App size

Revision Plain With Sentry Diff
abb7058 17.73 MiB 19.83 MiB 2.10 MiB
12427f4 17.73 MiB 19.85 MiB 2.12 MiB
86d6d2c+dirty 17.73 MiB 20.04 MiB 2.31 MiB
15c80ab+dirty 17.73 MiB 20.04 MiB 2.31 MiB
2534337 17.73 MiB 19.84 MiB 2.11 MiB
3853f43 17.73 MiB 19.81 MiB 2.08 MiB
457e29f 17.73 MiB 19.84 MiB 2.10 MiB
5571a20 17.73 MiB 19.93 MiB 2.19 MiB
31fcca2 17.73 MiB 19.90 MiB 2.17 MiB
34aba08 17.73 MiB 19.80 MiB 2.07 MiB

Copy link
Contributor

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1209.43 ms 1212.58 ms 3.15 ms
Size 2.36 MiB 3.04 MiB 696.40 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
34aba08+dirty 1276.78 ms 1308.52 ms 31.74 ms
b1e8712+dirty 1256.02 ms 1265.14 ms 9.12 ms
86d6d2c+dirty 1267.55 ms 1286.21 ms 18.66 ms
70caa60+dirty 1218.27 ms 1230.30 ms 12.03 ms
5571a20+dirty 1203.57 ms 1204.57 ms 1.00 ms
76d1baf+dirty 1244.10 ms 1268.52 ms 24.42 ms
0db0c72+dirty 1275.02 ms 1285.84 ms 10.82 ms
575f9da+dirty 1266.22 ms 1274.84 ms 8.62 ms
d361d38+dirty 1246.04 ms 1267.12 ms 21.08 ms
5a22220+dirty 1209.49 ms 1220.94 ms 11.45 ms

App size

Revision Plain With Sentry Diff
34aba08+dirty 2.36 MiB 2.85 MiB 495.32 KiB
b1e8712+dirty 2.36 MiB 2.84 MiB 488.84 KiB
86d6d2c+dirty 2.36 MiB 2.82 MiB 462.82 KiB
70caa60+dirty 2.36 MiB 2.83 MiB 479.27 KiB
5571a20+dirty 2.36 MiB 2.92 MiB 569.93 KiB
76d1baf+dirty 2.36 MiB 2.82 MiB 469.45 KiB
0db0c72+dirty 2.36 MiB 2.84 MiB 487.01 KiB
575f9da+dirty 2.36 MiB 2.87 MiB 520.20 KiB
d361d38+dirty 2.36 MiB 2.85 MiB 499.84 KiB
5a22220+dirty 2.36 MiB 2.92 MiB 570.21 KiB

Copy link
Contributor

github-actions bot commented Jun 25, 2024

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1234.61 ms 1230.63 ms -3.98 ms
Size 2.92 MiB 3.61 MiB 705.03 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
34aba08+dirty 1268.58 ms 1276.80 ms 8.22 ms
b1e8712+dirty 1284.11 ms 1297.82 ms 13.71 ms
86d6d2c+dirty 1291.62 ms 1296.80 ms 5.18 ms
70caa60+dirty 1279.08 ms 1281.54 ms 2.46 ms
5571a20+dirty 1228.09 ms 1233.45 ms 5.36 ms
76d1baf+dirty 1245.00 ms 1257.76 ms 12.76 ms
0db0c72+dirty 1258.88 ms 1262.52 ms 3.64 ms
575f9da+dirty 1272.00 ms 1284.38 ms 12.38 ms
d361d38+dirty 1272.96 ms 1291.70 ms 18.74 ms
5a22220+dirty 1246.18 ms 1249.61 ms 3.43 ms

App size

Revision Plain With Sentry Diff
34aba08+dirty 2.92 MiB 3.41 MiB 499.03 KiB
b1e8712+dirty 2.92 MiB 3.40 MiB 494.15 KiB
86d6d2c+dirty 2.92 MiB 3.37 MiB 464.31 KiB
70caa60+dirty 2.92 MiB 3.39 MiB 486.04 KiB
5571a20+dirty 2.92 MiB 3.48 MiB 575.54 KiB
76d1baf+dirty 2.92 MiB 3.38 MiB 475.74 KiB
0db0c72+dirty 2.92 MiB 3.40 MiB 492.71 KiB
575f9da+dirty 2.92 MiB 3.43 MiB 524.26 KiB
d361d38+dirty 2.92 MiB 3.41 MiB 503.57 KiB
5a22220+dirty 2.92 MiB 3.48 MiB 575.81 KiB

Copy link
Member

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, nice change make sense.

@krystofwoldrich krystofwoldrich enabled auto-merge (squash) June 26, 2024 11:37
@krystofwoldrich krystofwoldrich merged commit 30e2d76 into main Jun 26, 2024
50 of 52 checks passed
@krystofwoldrich krystofwoldrich deleted the fix/3792 branch June 26, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sentry-expo-upload-sourcemaps requires sentry url set in expo config
2 participants