Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update Cocoa SDK to v8.29.1 #3890

Merged
merged 1 commit into from
Jun 17, 2024
Merged

chore(deps): update Cocoa SDK to v8.29.1 #3890

merged 1 commit into from
Jun 17, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jun 14, 2024 •
edited
Loading

Bumps scripts/update-cocoa.sh from 8.28.0 to 8.29.1.

Auto-generated by a dependency updater.

Changelog

8.29.1

Features

  • Add pause and resume AppHangTracking API (#4077). You can now pause and resume app hang tracking with SentrySDK.pauseAppHangTracking() and SentrySDK.resumeAppHangTracking().

Fixes

  • Fix potential deadlock in app hang detection (#4063)
  • Swizzling of view controllers loadView that dont implement loadView` (#4071)

8.29.0

Features

  • Add a touch tracker for replay (#4041)
  • Add enableMetricKitRawPayload (#4044)
  • Resume session replay when app enters foreground (#4053)

Fixes

  • SentryCrashMonitor_CPPException.cpp compilation using Xcode 16b1 (#4051)

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Jun 14, 2024
@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-cocoa.sh branch from b44f466 to aa82f5d Compare June 14, 2024 03:02
@github-actions GitHub Actions
Copy link
Contributor Author

github-actions bot commented Jun 14, 2024 •
edited
Loading

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 444.88 ms 477.29 ms 32.41 ms
Size 17.73 MiB 19.94 MiB 2.21 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
8900e1a+dirty 430.68 ms 456.13 ms 25.44 ms
d361d38 354.10 ms 381.69 ms 27.59 ms
9c48b2c 349.24 ms 385.96 ms 36.72 ms
9a3ca65+dirty 326.93 ms 330.14 ms 3.21 ms
d197b5c+dirty 338.94 ms 354.87 ms 15.93 ms
457e29f 398.10 ms 421.39 ms 23.29 ms
e5c9b8b 409.02 ms 426.66 ms 17.64 ms
5bb8d5f 431.21 ms 459.40 ms 28.19 ms
31fcca2 391.22 ms 414.78 ms 23.56 ms
abb7058 370.27 ms 389.58 ms 19.31 ms

App size

Revision Plain With Sentry Diff
8900e1a+dirty 17.73 MiB 19.75 MiB 2.01 MiB
d361d38 17.73 MiB 19.81 MiB 2.08 MiB
9c48b2c 17.73 MiB 19.80 MiB 2.07 MiB
9a3ca65+dirty 17.73 MiB 20.04 MiB 2.31 MiB
d197b5c+dirty 17.73 MiB 20.04 MiB 2.31 MiB
457e29f 17.73 MiB 19.84 MiB 2.10 MiB
e5c9b8b 17.73 MiB 19.83 MiB 2.10 MiB
5bb8d5f 17.73 MiB 19.93 MiB 2.20 MiB
31fcca2 17.73 MiB 19.90 MiB 2.17 MiB
abb7058 17.73 MiB 19.83 MiB 2.10 MiB

@github-actions GitHub Actions
Copy link
Contributor Author

github-actions bot commented Jun 14, 2024 •
edited
Loading

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1226.02 ms 1227.80 ms 1.78 ms
Size 2.92 MiB 3.60 MiB 701.87 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
34aba08+dirty 1268.58 ms 1276.80 ms 8.22 ms
1d86dd6+dirty 1289.25 ms 1293.36 ms 4.11 ms
abb7058+dirty 1260.28 ms 1266.56 ms 6.28 ms
70caa60+dirty 1279.08 ms 1281.54 ms 2.46 ms
e73f4ed+dirty 1282.90 ms 1309.30 ms 26.40 ms
22e31b6+dirty 1276.55 ms 1278.12 ms 1.57 ms
27ef4ee+dirty 1236.41 ms 1244.90 ms 8.49 ms
8900e1a+dirty 1268.36 ms 1273.04 ms 4.68 ms
5bb8d5f+dirty 1215.04 ms 1217.52 ms 2.48 ms
6e8584e+dirty 1271.71 ms 1281.26 ms 9.55 ms

App size

Revision Plain With Sentry Diff
34aba08+dirty 2.92 MiB 3.41 MiB 499.03 KiB
1d86dd6+dirty 2.92 MiB 3.44 MiB 538.27 KiB
abb7058+dirty 2.92 MiB 3.43 MiB 524.53 KiB
70caa60+dirty 2.92 MiB 3.39 MiB 486.04 KiB
e73f4ed+dirty 2.92 MiB 3.38 MiB 475.71 KiB
22e31b6+dirty 2.92 MiB 3.43 MiB 524.74 KiB
27ef4ee+dirty 2.92 MiB 3.41 MiB 503.72 KiB
8900e1a+dirty 2.92 MiB 3.39 MiB 485.96 KiB
5bb8d5f+dirty 2.92 MiB 3.48 MiB 575.85 KiB
6e8584e+dirty 2.92 MiB 3.44 MiB 536.52 KiB

@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-cocoa.sh branch from aa82f5d to c48796b Compare June 17, 2024 08:39
@krystofwoldrich krystofwoldrich enabled auto-merge (squash) June 17, 2024 08:42
@github-actions GitHub Actions
Copy link
Contributor Author

github-actions bot commented Jun 17, 2024 •
edited
Loading

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1204.77 ms 1210.29 ms 5.52 ms
Size 2.36 MiB 3.04 MiB 696.28 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
34aba08+dirty 1276.78 ms 1308.52 ms 31.74 ms
1d86dd6+dirty 1249.71 ms 1279.16 ms 29.45 ms
abb7058+dirty 1255.42 ms 1268.86 ms 13.44 ms
70caa60+dirty 1218.27 ms 1230.30 ms 12.03 ms
e73f4ed+dirty 1243.27 ms 1244.52 ms 1.25 ms
22e31b6+dirty 1253.62 ms 1265.96 ms 12.34 ms
27ef4ee+dirty 1293.52 ms 1296.08 ms 2.56 ms
8900e1a+dirty 1210.27 ms 1218.66 ms 8.39 ms
5bb8d5f+dirty 1235.47 ms 1237.39 ms 1.92 ms
6e8584e+dirty 1274.50 ms 1296.82 ms 22.32 ms

App size

Revision Plain With Sentry Diff
34aba08+dirty 2.36 MiB 2.85 MiB 495.32 KiB
1d86dd6+dirty 2.36 MiB 2.89 MiB 535.43 KiB
abb7058+dirty 2.36 MiB 2.87 MiB 520.42 KiB
70caa60+dirty 2.36 MiB 2.83 MiB 479.27 KiB
e73f4ed+dirty 2.36 MiB 2.82 MiB 469.44 KiB
22e31b6+dirty 2.36 MiB 2.87 MiB 520.67 KiB
27ef4ee+dirty 2.36 MiB 2.85 MiB 500.03 KiB
8900e1a+dirty 2.36 MiB 2.83 MiB 479.25 KiB
5bb8d5f+dirty 2.36 MiB 2.92 MiB 570.22 KiB
6e8584e+dirty 2.36 MiB 2.88 MiB 533.17 KiB

@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-cocoa.sh branch 3 times, most recently from bcf6276 to 425ecbb Compare June 17, 2024 13:56
@github-actions GitHub Actions
Copy link
Contributor Author

github-actions bot commented Jun 17, 2024 •
edited
Loading

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 352.27 ms 386.60 ms 34.33 ms
Size 7.15 MiB 8.21 MiB 1.07 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
8900e1a+dirty 371.40 ms 377.70 ms 6.31 ms
5a22220+dirty 384.61 ms 419.06 ms 34.45 ms
9a3ca65+dirty 344.96 ms 358.92 ms 13.96 ms
d197b5c+dirty 258.75 ms 313.61 ms 54.86 ms
5571a20+dirty 359.52 ms 389.80 ms 30.28 ms
3853f43+dirty 278.12 ms 338.72 ms 60.60 ms
62a750b+dirty 370.78 ms 376.73 ms 5.96 ms
d7401ac+dirty 373.98 ms 394.08 ms 20.10 ms
2534337+dirty 597.14 ms 665.04 ms 67.90 ms
22e31b6+dirty 295.75 ms 346.73 ms 50.98 ms

App size

Revision Plain With Sentry Diff
8900e1a+dirty 7.15 MiB 8.03 MiB 901.79 KiB
5a22220+dirty 7.15 MiB 8.21 MiB 1.06 MiB
9a3ca65+dirty 7.15 MiB 8.09 MiB 962.83 KiB
d197b5c+dirty 7.15 MiB 8.09 MiB 962.72 KiB
5571a20+dirty 7.15 MiB 8.20 MiB 1.05 MiB
3853f43+dirty 7.15 MiB 8.08 MiB 959.34 KiB
62a750b+dirty 7.15 MiB 8.21 MiB 1.06 MiB
d7401ac+dirty 7.15 MiB 8.04 MiB 910.85 KiB
2534337+dirty 7.15 MiB 8.11 MiB 988.68 KiB
22e31b6+dirty 7.15 MiB 8.10 MiB 981.29 KiB

@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-cocoa.sh branch from 425ecbb to 44c8c9f Compare June 17, 2024 14:42
@github-actions github-actions bot changed the title chore(deps): update Cocoa SDK to v8.29.0 chore(deps): update Cocoa SDK to v8.29.1 Jun 17, 2024
krystofwoldrich
krystofwoldrich approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@krystofwoldrich krystofwoldrich merged commit c398f67 into main Jun 17, 2024
54 of 55 checks passed
@krystofwoldrich krystofwoldrich deleted the deps/scripts/update-cocoa.sh branch June 17, 2024 14:47
@venables venables mentioned this pull request Jun 17, 2024
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krystofwoldrich krystofwoldrich krystofwoldrich approved these changes

@lucas-zimerman lucas-zimerman Awaiting requested review from lucas-zimerman lucas-zimerman is a code owner

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krystofwoldrich @web-flow