Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update Cocoa SDK to v8.26.0 #3815

Merged
merged 1 commit into from
May 27, 2024
Merged

chore(deps): update Cocoa SDK to v8.26.0 #3815

merged 1 commit into from
May 27, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Bumps scripts/update-cocoa.sh from 8.25.2 to 8.26.0.

Auto-generated by a dependency updater.

Changelog

8.26.0

Features

  • Add SIGTERM support (#3895)

Fixes

  • Fix data race when calling reportFullyDisplayed from a background thread (#3926)
  • Ensure flushing envelopes directly after capturing them (#3915)
  • Unable to find class: SentryCrashExceptionApplication (#3957)
  • Clang error for Xcode 15.4 (#3958)
  • Potential deadlock when starting the SDK (#3970)

Improvements

  • Send Cocoa SDK features (#3948)

@github-actions github-actions bot requested a review from krystofwoldrich as a code owner May 13, 2024 15:23
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label May 13, 2024
@github-actions github-actions bot requested a review from lucas-zimerman as a code owner May 13, 2024 15:23
@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-cocoa.sh branch 2 times, most recently from 660681d to dc36698 Compare May 13, 2024 15:34
@github-actions GitHub Actions
Copy link
Contributor Author

github-actions bot commented May 13, 2024 •
edited
Loading

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 383.33 ms 421.94 ms 38.61 ms
Size 17.73 MiB 19.94 MiB 2.20 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
6e8584e 447.10 ms 474.71 ms 27.61 ms
80b2ce3 385.02 ms 387.36 ms 2.34 ms
728164b 414.34 ms 449.22 ms 34.88 ms
15c80ab+dirty 336.27 ms 350.58 ms 14.31 ms
457e29f 398.10 ms 421.39 ms 23.29 ms
5bb8d5f 431.21 ms 459.40 ms 28.19 ms
d197b5c+dirty 338.94 ms 354.87 ms 15.93 ms
31fcca2 391.22 ms 414.78 ms 23.56 ms
e5c9b8b 409.02 ms 426.66 ms 17.64 ms
12427f4 393.69 ms 414.84 ms 21.14 ms

App size

Revision Plain With Sentry Diff
6e8584e 17.73 MiB 19.86 MiB 2.12 MiB
80b2ce3 17.73 MiB 19.75 MiB 2.02 MiB
728164b 17.73 MiB 19.85 MiB 2.12 MiB
15c80ab+dirty 17.73 MiB 20.04 MiB 2.31 MiB
457e29f 17.73 MiB 19.84 MiB 2.10 MiB
5bb8d5f 17.73 MiB 19.93 MiB 2.20 MiB
d197b5c+dirty 17.73 MiB 20.04 MiB 2.31 MiB
31fcca2 17.73 MiB 19.90 MiB 2.17 MiB
e5c9b8b 17.73 MiB 19.83 MiB 2.10 MiB
12427f4 17.73 MiB 19.85 MiB 2.12 MiB

Previous results on branch: deps/scripts/update-cocoa.sh

Startup times

Revision Plain With Sentry Diff
9af52f2 364.43 ms 379.30 ms 14.87 ms
1573004 381.49 ms 408.94 ms 27.45 ms
8ba8074 326.52 ms 339.04 ms 12.52 ms
adb21f0 395.34 ms 419.46 ms 24.12 ms
7787a29 392.23 ms 411.72 ms 19.49 ms
1dc092f 420.22 ms 434.90 ms 14.68 ms
bcbaefb 386.71 ms 419.33 ms 32.62 ms
8da52c9+dirty 385.21 ms 422.36 ms 37.15 ms
5cca71b 316.82 ms 321.74 ms 4.93 ms
87d728a 426.02 ms 432.73 ms 6.71 ms

App size

Revision Plain With Sentry Diff
9af52f2 17.73 MiB 19.80 MiB 2.07 MiB
1573004 17.73 MiB 19.83 MiB 2.10 MiB
8ba8074 17.73 MiB 19.81 MiB 2.08 MiB
adb21f0 17.73 MiB 19.83 MiB 2.10 MiB
7787a29 17.73 MiB 19.86 MiB 2.12 MiB
1dc092f 17.73 MiB 19.84 MiB 2.10 MiB
bcbaefb 17.73 MiB 19.85 MiB 2.11 MiB
8da52c9+dirty 17.73 MiB 20.04 MiB 2.31 MiB
5cca71b 17.73 MiB 19.83 MiB 2.09 MiB
87d728a 17.73 MiB 19.86 MiB 2.12 MiB

@github-actions GitHub Actions
Copy link
Contributor Author

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 373.71 ms 396.57 ms 22.86 ms
Size 7.15 MiB 8.21 MiB 1.06 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
f06c879+dirty 361.27 ms 407.88 ms 46.61 ms
d197b5c+dirty 258.75 ms 313.61 ms 54.86 ms
1d86dd6+dirty 335.76 ms 371.22 ms 35.46 ms
dadc233+dirty 363.19 ms 370.37 ms 7.18 ms
728164b+dirty 335.93 ms 342.94 ms 7.01 ms
e2b64fe+dirty 258.82 ms 304.26 ms 45.44 ms
0db0c72+dirty 335.20 ms 351.06 ms 15.86 ms
d361d38+dirty 257.72 ms 318.76 ms 61.04 ms
ad6c299+dirty 336.47 ms 362.89 ms 26.42 ms
27ef4ee+dirty 296.71 ms 351.00 ms 54.29 ms

App size

Revision Plain With Sentry Diff
f06c879+dirty 7.15 MiB 8.12 MiB 997.78 KiB
d197b5c+dirty 7.15 MiB 8.09 MiB 962.72 KiB
1d86dd6+dirty 7.15 MiB 8.13 MiB 1002.18 KiB
dadc233+dirty 7.15 MiB 8.04 MiB 910.84 KiB
728164b+dirty 7.15 MiB 8.12 MiB 997.71 KiB
e2b64fe+dirty 7.15 MiB 8.07 MiB 947.16 KiB
0db0c72+dirty 7.15 MiB 8.04 MiB 911.02 KiB
d361d38+dirty 7.15 MiB 8.08 MiB 959.34 KiB
ad6c299+dirty 7.15 MiB 8.04 MiB 912.17 KiB
27ef4ee+dirty 7.15 MiB 8.08 MiB 959.49 KiB

Previous results on branch: deps/scripts/update-cocoa.sh

Startup times

Revision Plain With Sentry Diff
a4302f1+dirty 383.10 ms 405.33 ms 22.23 ms
19e1ada+dirty 366.56 ms 393.32 ms 26.76 ms
5cca71b+dirty 288.29 ms 341.60 ms 53.31 ms
69568a5+dirty 371.27 ms 409.40 ms 38.13 ms
357b71f+dirty 318.48 ms 354.55 ms 36.07 ms
955f10d+dirty 306.27 ms 385.83 ms 79.57 ms
7787a29+dirty 340.33 ms 368.82 ms 28.48 ms
c1659ab+dirty 267.34 ms 337.14 ms 69.80 ms
1573004+dirty 343.73 ms 369.70 ms 25.97 ms
8da52c9+dirty 269.29 ms 290.76 ms 21.47 ms

App size

Revision Plain With Sentry Diff
a4302f1+dirty 7.15 MiB 8.12 MiB 999.45 KiB
19e1ada+dirty 7.15 MiB 8.12 MiB 999.34 KiB
5cca71b+dirty 7.15 MiB 8.10 MiB 972.55 KiB
69568a5+dirty 7.15 MiB 8.18 MiB 1.03 MiB
357b71f+dirty 7.15 MiB 8.13 MiB 1002.12 KiB
955f10d+dirty 7.15 MiB 8.07 MiB 946.13 KiB
7787a29+dirty 7.15 MiB 8.13 MiB 1002.18 KiB
c1659ab+dirty 7.15 MiB 8.10 MiB 972.53 KiB
1573004+dirty 7.15 MiB 8.10 MiB 980.89 KiB
8da52c9+dirty 7.15 MiB 8.09 MiB 962.83 KiB

@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-cocoa.sh branch from dc36698 to 55477db Compare May 22, 2024 08:42
krystofwoldrich
krystofwoldrich approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@krystofwoldrich krystofwoldrich merged commit b888051 into main May 27, 2024
57 of 60 checks passed
@krystofwoldrich krystofwoldrich deleted the deps/scripts/update-cocoa.sh branch May 27, 2024 09:11
krystofwoldrich pushed a commit that referenced this pull request May 27, 2024
@github-actions @web-flow @krystofwoldrich
chore(deps): update Cocoa SDK to v8.26.0 (#3815)
c33581b 
Co-authored-by: GitHub <[email protected]>
This was referenced May 27, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krystofwoldrich krystofwoldrich krystofwoldrich approved these changes

@lucas-zimerman lucas-zimerman Awaiting requested review from lucas-zimerman lucas-zimerman is a code owner

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krystofwoldrich @web-flow