Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: Update VSC settings fixAll option changes #3760

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

krystofwoldrich
Copy link
Member

#skip-changelog

New versions of VSC deprecated the bool option replaced by enum, 'explicit'.

Copy link
Contributor

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 325.38 ms 358.22 ms 32.85 ms
Size 7.15 MiB 8.21 MiB 1.06 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
f06c879+dirty 361.27 ms 407.88 ms 46.61 ms
d197b5c+dirty 258.75 ms 313.61 ms 54.86 ms
1d86dd6+dirty 335.76 ms 371.22 ms 35.46 ms
dadc233+dirty 363.19 ms 370.37 ms 7.18 ms
728164b+dirty 335.93 ms 342.94 ms 7.01 ms
e2b64fe+dirty 258.82 ms 304.26 ms 45.44 ms
0db0c72+dirty 335.20 ms 351.06 ms 15.86 ms
d361d38+dirty 257.72 ms 318.76 ms 61.04 ms
ad6c299+dirty 336.47 ms 362.89 ms 26.42 ms
27ef4ee+dirty 296.71 ms 351.00 ms 54.29 ms

App size

Revision Plain With Sentry Diff
f06c879+dirty 7.15 MiB 8.12 MiB 997.78 KiB
d197b5c+dirty 7.15 MiB 8.09 MiB 962.72 KiB
1d86dd6+dirty 7.15 MiB 8.13 MiB 1002.18 KiB
dadc233+dirty 7.15 MiB 8.04 MiB 910.84 KiB
728164b+dirty 7.15 MiB 8.12 MiB 997.71 KiB
e2b64fe+dirty 7.15 MiB 8.07 MiB 947.16 KiB
0db0c72+dirty 7.15 MiB 8.04 MiB 911.02 KiB
d361d38+dirty 7.15 MiB 8.08 MiB 959.34 KiB
ad6c299+dirty 7.15 MiB 8.04 MiB 912.17 KiB
27ef4ee+dirty 7.15 MiB 8.08 MiB 959.49 KiB

Copy link
Contributor

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1237.19 ms 1240.28 ms 3.09 ms
Size 2.92 MiB 3.49 MiB 583.30 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
6e8584e+dirty 1271.71 ms 1281.26 ms 9.55 ms
d361d38+dirty 1272.96 ms 1291.70 ms 18.74 ms
2534337+dirty 1220.87 ms 1221.47 ms 0.60 ms
5a22220+dirty 1246.18 ms 1249.61 ms 3.43 ms
5bb8d5f+dirty 1215.04 ms 1217.52 ms 2.48 ms
76d1baf+dirty 1245.00 ms 1257.76 ms 12.76 ms
0db0c72+dirty 1258.88 ms 1262.52 ms 3.64 ms
3ffcddd+dirty 1272.22 ms 1273.98 ms 1.76 ms
52a8031+dirty 1255.96 ms 1273.00 ms 17.04 ms
86d6d2c+dirty 1291.62 ms 1296.80 ms 5.18 ms

App size

Revision Plain With Sentry Diff
6e8584e+dirty 2.92 MiB 3.44 MiB 536.52 KiB
d361d38+dirty 2.92 MiB 3.41 MiB 503.57 KiB
2534337+dirty 2.92 MiB 3.43 MiB 529.76 KiB
5a22220+dirty 2.92 MiB 3.48 MiB 575.81 KiB
5bb8d5f+dirty 2.92 MiB 3.48 MiB 575.85 KiB
76d1baf+dirty 2.92 MiB 3.38 MiB 475.74 KiB
0db0c72+dirty 2.92 MiB 3.40 MiB 492.71 KiB
3ffcddd+dirty 2.92 MiB 3.40 MiB 494.39 KiB
52a8031+dirty 2.92 MiB 3.38 MiB 475.71 KiB
86d6d2c+dirty 2.92 MiB 3.37 MiB 464.31 KiB

Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lucas-zimerman lucas-zimerman merged commit aaecd92 into main Apr 19, 2024
55 of 57 checks passed
@lucas-zimerman lucas-zimerman deleted the kw-fix-vsc-settings branch April 19, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants