fix(nativeframes): Do not enable NativeFramesTracking when native is not available #3705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e' into kw-disable-static-web-routes
…hangs" This reverts commit 4a4c27d.
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e73f4ed+dirty | 332.96 ms | 354.33 ms | 21.37 ms |
| 27ef4ee | 317.40 ms | 321.70 ms | 4.30 ms |
| 3ffcddd | 302.92 ms | 315.80 ms | 12.88 ms |
| ad6c299 | 375.94 ms | 382.02 ms | 6.08 ms |
| d0bf494+dirty | 375.37 ms | 395.14 ms | 19.77 ms |
| acadc0f+dirty | 373.24 ms | 381.51 ms | 8.27 ms |
| d361d38 | 354.10 ms | 381.69 ms | 27.59 ms |
| 8900e1a+dirty | 430.68 ms | 456.13 ms | 25.44 ms |
| 0db0c72 | 372.12 ms | 386.00 ms | 13.88 ms |
| 5571a20 | 410.55 ms | 441.06 ms | 30.51 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e73f4ed+dirty | 17.73 MiB | 20.04 MiB | 2.31 MiB |
| 27ef4ee | 17.73 MiB | 19.82 MiB | 2.08 MiB |
| 3ffcddd | 17.73 MiB | 19.75 MiB | 2.02 MiB |
| ad6c299 | 17.73 MiB | 19.75 MiB | 2.02 MiB |
| d0bf494+dirty | 17.73 MiB | 19.75 MiB | 2.02 MiB |
| acadc0f+dirty | 17.73 MiB | 19.75 MiB | 2.01 MiB |
| d361d38 | 17.73 MiB | 19.81 MiB | 2.08 MiB |
| 8900e1a+dirty | 17.73 MiB | 19.75 MiB | 2.01 MiB |
| 0db0c72 | 17.73 MiB | 19.75 MiB | 2.02 MiB |
| 5571a20 | 17.73 MiB | 19.93 MiB | 2.19 MiB |
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 5571a20+dirty | 359.52 ms | 389.80 ms | 30.28 ms |
| e73f4ed+dirty | 262.98 ms | 311.02 ms | 48.04 ms |
| 27ef4ee+dirty | 296.71 ms | 351.00 ms | 54.29 ms |
| d0bf494+dirty | 253.73 ms | 308.23 ms | 54.49 ms |
| acadc0f+dirty | 259.04 ms | 304.67 ms | 45.63 ms |
| 34aba08+dirty | 331.79 ms | 376.69 ms | 44.91 ms |
| 9433f35+dirty | 265.50 ms | 336.08 ms | 70.58 ms |
| ad6c299+dirty | 336.47 ms | 362.89 ms | 26.42 ms |
| 8900e1a+dirty | 371.40 ms | 377.70 ms | 6.31 ms |
| 22e31b6+dirty | 295.75 ms | 346.73 ms | 50.98 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 5571a20+dirty | 7.15 MiB | 8.20 MiB | 1.05 MiB |
| e73f4ed+dirty | 7.15 MiB | 8.09 MiB | 965.94 KiB |
| 27ef4ee+dirty | 7.15 MiB | 8.08 MiB | 959.49 KiB |
| d0bf494+dirty | 7.15 MiB | 8.04 MiB | 910.85 KiB |
| acadc0f+dirty | 7.15 MiB | 8.03 MiB | 903.20 KiB |
| 34aba08+dirty | 7.15 MiB | 8.07 MiB | 946.13 KiB |
| 9433f35+dirty | 7.15 MiB | 8.08 MiB | 959.34 KiB |
| ad6c299+dirty | 7.15 MiB | 8.04 MiB | 912.17 KiB |
| 8900e1a+dirty | 7.15 MiB | 8.03 MiB | 901.79 KiB |
| 22e31b6+dirty | 7.15 MiB | 8.10 MiB | 981.29 KiB |
lucas-zimerman
approved these changes
Mar 21, 2024
Co-authored-by: LucasZF <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Native modules are not expected to be available in Expo Go, we can disable native frames
💡 Motivation and Context
💚 How did you test it?
sample app
📝 Checklist
sendDefaultPIIis enabled