Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(timetodisplay): Change TimeToDisplay unsupported message from error to warning #3699

Merged
merged 5 commits into from
Apr 16, 2024
Merged

fix(timetodisplay): Change TimeToDisplay unsupported message from error to warning #3699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bde51a3
fix(timetodisplay): Change TimeToDisplay unsupported log from error t…
krystofwoldrich Mar 20, 2024
b562766
Update the message to log to remove useless stack trace and update th…
krystofwoldrich Mar 20, 2024
f36f916
Use warn with timeout to remove the stack trace
krystofwoldrich Mar 21, 2024
56d40c9
Merge remote-tracking branch 'origin/main' into kw-ttd-error-to-warning
krystofwoldrich Mar 21, 2024
9f71039
Update src/js/tracing/timetodisplay.tsx
krystofwoldrich Apr 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@

- Add `getDefaultConfig` option to `getSentryExpoConfig` ([#3690](https://github.com/getsentry/sentry-react-native/pull/3690))

### Fixes

- Change TimeToDisplay unsupported log from error to warning level. ([#3699](https://github.com/getsentry/sentry-react-native/pull/3699))

## 5.20.0

### Features
Expand Down
5 changes: 4 additions & 1 deletion src/js/tracing/timetodisplay.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,10 @@ function TimeToDisplay(props: {

if (__DEV__ && !nativeComponentMissingLogged && !nativeComponentExists) {
nativeComponentMissingLogged = true;
logger.error('RNSentryOnDrawReporter is not available on the web, Expo Go and New Architecture. Run native build or report an issue at https://github.com/getsentry/sentry-react-native');
// Using setTimeout with a delay of 0 milliseconds to defer execution and avoid printing the React stack trace.
setTimeout(() => {
krystofwoldrich marked this conversation as resolved.
Show resolved Hide resolved
logger.warn('TimeToInitialDisplay and TimeToFullDisplay are not supported on the web, Expo Go and New Architecture. Run native build or report an issue at https://github.com/getsentry/sentry-react-native');
}, 0);
}

const onDraw = (event: { nativeEvent: RNSentryOnDrawNextFrameEvent }): void => onDrawNextFrame(event);
Expand Down
Loading