misc(sample): Do not execute Sentry in NodeJS during npx expo export #3689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android (legacy) Performance metrics 🚀
|
lucas-zimerman
merged commit 21b4d98
into
kw-add-expo-router-instrumentation-to-sample-app
50 of 54 checks passed
krystofwoldrich
added a commit
that referenced
this pull request
Mar 21, 2024
* misc(sample): Move `Sentry.init` to the root `_layout` * misc(sample): Do not execute Sentry in NodeJS during npx expo export command (#3689) * feat(expo): Add getDefaultConfig option to getSentryExpoConfig (#3690) * misc(sample): Do not execute Sentry in NodeJS during npx expo export command * feat(expo): Add `getDefaultConfig` option to `getSentryExpoConfig` * misc(sample): Enable expo-router auto instrumentation (#3692) * misc(sample): Disable Expo Web static routes, export command hangs * misc(sample): Enable expo-router auto instrumentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During Expo export, the JS code is executed, which spams the export output.
This PR adds env to the sample app to avoid this.
#skip-changelog