-
-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(expo): Added ability to provide sentryUrl for source maps upload #3664
Conversation
scripts/expo-upload-sourcemaps.js
Outdated
if (pluginConfig.url) { | ||
sentryUrl = pluginConfig.url; | ||
} else { | ||
sentryUrl | ||
} | ||
console.log(`${SENTRY_PROJECT} resolved to ${sentryProject} from expo config.`); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although, I agree with loading the URL from the Expo Plugin Configuration.
The current code won't work, as pluginConfig
variable is not in the scope.
This should be under if (!sentryOrg || !sentryProject) {
, which needs to be updated to include sentryUrl
.
@Acetyld Hi, thank you for the PR, this makes sense and is a good addition to the Expo script. But before we can add it the code needs a few fixes that I described in the comments above. |
Hi =) Yhea i used the browser vscode editor, it was a bit wonky. I saw u fixed almost all issue's so i suppose it is fine now? |
@Acetyld There is just this one comment to be resolved. |
Alright i tried to update above, if it still incorrect i will put time into doing this in a real editor instead of the git edit 😜 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Acetyld Thank you, now it's perfect. 🚀
📢 Type of change
📜 Description
Added sentryUrl for people that are self hosting
💡 Motivation and Context
Its also possible to define URL inside app.json and this was missing from the command.
💚 How did you test it?
I tested it locally.
📝 Checklist
sendDefaultPII
is enabled🔮 Next steps