-
-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update Cocoa SDK to v8.21.0 #3651
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
krystofwoldrich and
lucas-zimerman
as code owners
March 5, 2024 03:02
github-actions
bot
added
the
dependencies
Pull requests that update a dependency file
label
Mar 5, 2024
bruno-garcia
force-pushed
the
deps/scripts/update-cocoa.sh
branch
from
March 5, 2024 03:02
9d48c1c
to
43ccbc2
Compare
Android (legacy) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
3853f43 | 329.68 ms | 346.32 ms | 16.64 ms |
e2b64fe | 316.88 ms | 330.23 ms | 13.35 ms |
1d86dd6 | 405.14 ms | 411.06 ms | 5.92 ms |
9433f35 | 347.64 ms | 356.22 ms | 8.58 ms |
34aba08 | 328.10 ms | 342.84 ms | 14.74 ms |
8900e1a+dirty | 430.68 ms | 456.13 ms | 25.44 ms |
e73f4ed+dirty | 332.96 ms | 354.33 ms | 21.37 ms |
e5c9b8b | 409.02 ms | 426.66 ms | 17.64 ms |
acadc0f+dirty | 373.24 ms | 381.51 ms | 8.27 ms |
ad6c299 | 375.94 ms | 382.02 ms | 6.08 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
3853f43 | 17.73 MiB | 19.81 MiB | 2.08 MiB |
e2b64fe | 17.73 MiB | 19.80 MiB | 2.07 MiB |
1d86dd6 | 17.73 MiB | 19.86 MiB | 2.12 MiB |
9433f35 | 17.73 MiB | 19.81 MiB | 2.08 MiB |
34aba08 | 17.73 MiB | 19.80 MiB | 2.07 MiB |
8900e1a+dirty | 17.73 MiB | 19.75 MiB | 2.01 MiB |
e73f4ed+dirty | 17.73 MiB | 20.04 MiB | 2.31 MiB |
e5c9b8b | 17.73 MiB | 19.83 MiB | 2.10 MiB |
acadc0f+dirty | 17.73 MiB | 19.75 MiB | 2.01 MiB |
ad6c299 | 17.73 MiB | 19.75 MiB | 2.02 MiB |
Previous results on branch: deps/scripts/update-cocoa.sh
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
69568a5 | 432.77 ms | 460.94 ms | 28.17 ms |
955f10d | 351.88 ms | 364.50 ms | 12.62 ms |
94f9b87+dirty | 319.37 ms | 330.10 ms | 10.73 ms |
5cca71b | 316.82 ms | 321.74 ms | 4.93 ms |
adb21f0 | 395.34 ms | 419.46 ms | 24.12 ms |
357b71f | 401.70 ms | 415.62 ms | 13.92 ms |
7787a29 | 392.23 ms | 411.72 ms | 19.49 ms |
1573004 | 381.49 ms | 408.94 ms | 27.45 ms |
8ba8074 | 326.52 ms | 339.04 ms | 12.52 ms |
87d728a | 426.02 ms | 432.73 ms | 6.71 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
69568a5 | 17.73 MiB | 19.91 MiB | 2.17 MiB |
955f10d | 17.73 MiB | 19.80 MiB | 2.07 MiB |
94f9b87+dirty | 17.73 MiB | 19.75 MiB | 2.01 MiB |
5cca71b | 17.73 MiB | 19.83 MiB | 2.09 MiB |
adb21f0 | 17.73 MiB | 19.83 MiB | 2.10 MiB |
357b71f | 17.73 MiB | 19.86 MiB | 2.12 MiB |
7787a29 | 17.73 MiB | 19.86 MiB | 2.12 MiB |
1573004 | 17.73 MiB | 19.83 MiB | 2.10 MiB |
8ba8074 | 17.73 MiB | 19.81 MiB | 2.08 MiB |
87d728a | 17.73 MiB | 19.86 MiB | 2.12 MiB |
iOS (legacy) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
80b2ce3+dirty | 1265.92 ms | 1268.60 ms | 2.69 ms |
d7401ac+dirty | 1252.38 ms | 1275.04 ms | 22.66 ms |
e5c9b8b+dirty | 1258.57 ms | 1267.32 ms | 8.75 ms |
acadc0f+dirty | 1264.38 ms | 1290.06 ms | 25.68 ms |
728164b+dirty | 1256.10 ms | 1259.08 ms | 2.98 ms |
3ffcddd+dirty | 1244.47 ms | 1264.14 ms | 19.67 ms |
9a3ca65+dirty | 1247.06 ms | 1274.58 ms | 27.52 ms |
457e29f+dirty | 1253.94 ms | 1269.18 ms | 15.24 ms |
12427f4+dirty | 1267.15 ms | 1271.30 ms | 4.15 ms |
2534337+dirty | 1225.08 ms | 1230.26 ms | 5.17 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
80b2ce3+dirty | 2.36 MiB | 2.84 MiB | 486.98 KiB |
d7401ac+dirty | 2.36 MiB | 2.83 MiB | 481.14 KiB |
e5c9b8b+dirty | 2.36 MiB | 2.87 MiB | 520.43 KiB |
acadc0f+dirty | 2.36 MiB | 2.83 MiB | 480.37 KiB |
728164b+dirty | 2.36 MiB | 2.88 MiB | 530.38 KiB |
3ffcddd+dirty | 2.36 MiB | 2.84 MiB | 489.60 KiB |
9a3ca65+dirty | 2.36 MiB | 2.82 MiB | 462.89 KiB |
457e29f+dirty | 2.36 MiB | 2.87 MiB | 520.67 KiB |
12427f4+dirty | 2.36 MiB | 2.88 MiB | 530.38 KiB |
2534337+dirty | 2.36 MiB | 2.88 MiB | 525.47 KiB |
Previous results on branch: deps/scripts/update-cocoa.sh
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
adb21f0+dirty | 1252.08 ms | 1258.48 ms | 6.40 ms |
94f9b87+dirty | 1260.32 ms | 1283.72 ms | 23.40 ms |
a4302f1+dirty | 1260.92 ms | 1276.94 ms | 16.02 ms |
c1659ab+dirty | 1235.67 ms | 1239.00 ms | 3.33 ms |
1dc092f+dirty | 1281.98 ms | 1282.88 ms | 0.90 ms |
87d728a+dirty | 1234.82 ms | 1246.34 ms | 11.52 ms |
8ba8074+dirty | 1222.44 ms | 1243.82 ms | 21.38 ms |
bcbaefb+dirty | 1210.55 ms | 1216.45 ms | 5.90 ms |
5cca71b+dirty | 1252.70 ms | 1253.74 ms | 1.04 ms |
9af52f2+dirty | 1273.67 ms | 1286.72 ms | 13.05 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
adb21f0+dirty | 2.36 MiB | 2.87 MiB | 522.40 KiB |
94f9b87+dirty | 2.36 MiB | 2.83 MiB | 479.26 KiB |
a4302f1+dirty | 2.36 MiB | 2.89 MiB | 534.32 KiB |
c1659ab+dirty | 2.36 MiB | 2.86 MiB | 512.90 KiB |
1dc092f+dirty | 2.36 MiB | 2.87 MiB | 522.54 KiB |
87d728a+dirty | 2.36 MiB | 2.89 MiB | 535.20 KiB |
8ba8074+dirty | 2.36 MiB | 2.86 MiB | 507.04 KiB |
bcbaefb+dirty | 2.36 MiB | 2.88 MiB | 529.92 KiB |
5cca71b+dirty | 2.36 MiB | 2.86 MiB | 512.94 KiB |
9af52f2+dirty | 2.36 MiB | 2.85 MiB | 497.02 KiB |
bruno-garcia
force-pushed
the
deps/scripts/update-cocoa.sh
branch
4 times, most recently
from
March 5, 2024 16:16
4d3ff5b
to
ff92318
Compare
krystofwoldrich
approved these changes
Mar 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
bruno-garcia
force-pushed
the
deps/scripts/update-cocoa.sh
branch
from
March 5, 2024 19:42
ff92318
to
63f0010
Compare
Android (new) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
abb7058+dirty | 320.78 ms | 324.08 ms | 3.30 ms |
8900e1a+dirty | 371.40 ms | 377.70 ms | 6.31 ms |
e5c9b8b+dirty | 335.40 ms | 360.06 ms | 24.67 ms |
575f9da+dirty | 337.15 ms | 370.47 ms | 33.32 ms |
e73f4ed+dirty | 262.98 ms | 311.02 ms | 48.04 ms |
acadc0f+dirty | 259.04 ms | 304.67 ms | 45.63 ms |
dadc233+dirty | 363.19 ms | 370.37 ms | 7.18 ms |
34aba08+dirty | 331.79 ms | 376.69 ms | 44.91 ms |
12427f4+dirty | 379.48 ms | 400.92 ms | 21.44 ms |
457e29f+dirty | 591.49 ms | 612.96 ms | 21.47 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
abb7058+dirty | 7.15 MiB | 8.10 MiB | 980.40 KiB |
8900e1a+dirty | 7.15 MiB | 8.03 MiB | 901.79 KiB |
e5c9b8b+dirty | 7.15 MiB | 8.10 MiB | 980.41 KiB |
575f9da+dirty | 7.15 MiB | 8.10 MiB | 979.68 KiB |
e73f4ed+dirty | 7.15 MiB | 8.09 MiB | 965.94 KiB |
acadc0f+dirty | 7.15 MiB | 8.03 MiB | 903.20 KiB |
dadc233+dirty | 7.15 MiB | 8.04 MiB | 910.84 KiB |
34aba08+dirty | 7.15 MiB | 8.07 MiB | 946.13 KiB |
12427f4+dirty | 7.15 MiB | 8.12 MiB | 997.78 KiB |
457e29f+dirty | 7.15 MiB | 8.10 MiB | 981.29 KiB |
Previous results on branch: deps/scripts/update-cocoa.sh
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
87d728a+dirty | 362.28 ms | 388.30 ms | 26.02 ms |
69568a5+dirty | 371.27 ms | 409.40 ms | 38.13 ms |
94f9b87+dirty | 300.47 ms | 353.74 ms | 53.27 ms |
7787a29+dirty | 340.33 ms | 368.82 ms | 28.48 ms |
19e1ada+dirty | 366.56 ms | 393.32 ms | 26.76 ms |
bcbaefb+dirty | 384.22 ms | 417.15 ms | 32.92 ms |
5cca71b+dirty | 288.29 ms | 341.60 ms | 53.31 ms |
1362675+dirty | 370.27 ms | 402.51 ms | 32.24 ms |
c1659ab+dirty | 267.34 ms | 337.14 ms | 69.80 ms |
8ba8074+dirty | 264.25 ms | 315.40 ms | 51.15 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
87d728a+dirty | 7.15 MiB | 8.13 MiB | 1001.74 KiB |
69568a5+dirty | 7.15 MiB | 8.18 MiB | 1.03 MiB |
94f9b87+dirty | 7.15 MiB | 8.03 MiB | 901.79 KiB |
7787a29+dirty | 7.15 MiB | 8.13 MiB | 1002.18 KiB |
19e1ada+dirty | 7.15 MiB | 8.12 MiB | 999.34 KiB |
bcbaefb+dirty | 7.15 MiB | 8.12 MiB | 991.49 KiB |
5cca71b+dirty | 7.15 MiB | 8.10 MiB | 972.55 KiB |
1362675+dirty | 7.15 MiB | 8.10 MiB | 981.29 KiB |
c1659ab+dirty | 7.15 MiB | 8.10 MiB | 972.53 KiB |
8ba8074+dirty | 7.15 MiB | 8.08 MiB | 959.34 KiB |
bruno-garcia
force-pushed
the
deps/scripts/update-cocoa.sh
branch
from
March 5, 2024 20:24
63f0010
to
6ee04ec
Compare
iOS (new) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
80b2ce3+dirty | 1245.12 ms | 1262.04 ms | 16.92 ms |
d7401ac+dirty | 1288.10 ms | 1289.54 ms | 1.44 ms |
e5c9b8b+dirty | 1276.90 ms | 1280.92 ms | 4.02 ms |
acadc0f+dirty | 1271.12 ms | 1272.28 ms | 1.16 ms |
728164b+dirty | 1280.06 ms | 1285.26 ms | 5.20 ms |
3ffcddd+dirty | 1272.22 ms | 1273.98 ms | 1.76 ms |
9a3ca65+dirty | 1276.40 ms | 1279.14 ms | 2.74 ms |
457e29f+dirty | 1256.71 ms | 1258.50 ms | 1.79 ms |
12427f4+dirty | 1224.90 ms | 1231.40 ms | 6.50 ms |
2534337+dirty | 1220.87 ms | 1221.47 ms | 0.60 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
80b2ce3+dirty | 2.92 MiB | 3.40 MiB | 492.75 KiB |
d7401ac+dirty | 2.92 MiB | 3.40 MiB | 488.06 KiB |
e5c9b8b+dirty | 2.92 MiB | 3.43 MiB | 524.50 KiB |
acadc0f+dirty | 2.92 MiB | 3.39 MiB | 487.34 KiB |
728164b+dirty | 2.92 MiB | 3.44 MiB | 533.26 KiB |
3ffcddd+dirty | 2.92 MiB | 3.40 MiB | 494.39 KiB |
9a3ca65+dirty | 2.92 MiB | 3.37 MiB | 464.32 KiB |
457e29f+dirty | 2.92 MiB | 3.43 MiB | 524.75 KiB |
12427f4+dirty | 2.92 MiB | 3.44 MiB | 533.29 KiB |
2534337+dirty | 2.92 MiB | 3.43 MiB | 529.76 KiB |
Previous results on branch: deps/scripts/update-cocoa.sh
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
87d728a+dirty | 1239.54 ms | 1244.46 ms | 4.92 ms |
19e1ada+dirty | 1279.37 ms | 1288.34 ms | 8.97 ms |
8ba8074+dirty | 1284.04 ms | 1309.42 ms | 25.38 ms |
bcbaefb+dirty | 1213.90 ms | 1214.78 ms | 0.88 ms |
1362675+dirty | 1264.94 ms | 1271.45 ms | 6.52 ms |
1dc092f+dirty | 1235.00 ms | 1236.54 ms | 1.54 ms |
9af52f2+dirty | 1256.52 ms | 1258.94 ms | 2.42 ms |
c1659ab+dirty | 1256.02 ms | 1257.02 ms | 1.00 ms |
357b71f+dirty | 1277.00 ms | 1286.64 ms | 9.64 ms |
1573004+dirty | 1254.44 ms | 1261.28 ms | 6.84 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
87d728a+dirty | 2.92 MiB | 3.44 MiB | 538.14 KiB |
19e1ada+dirty | 2.92 MiB | 3.44 MiB | 534.41 KiB |
8ba8074+dirty | 2.92 MiB | 3.42 MiB | 510.57 KiB |
bcbaefb+dirty | 2.92 MiB | 3.44 MiB | 534.26 KiB |
1362675+dirty | 2.92 MiB | 3.43 MiB | 525.90 KiB |
1dc092f+dirty | 2.92 MiB | 3.43 MiB | 525.85 KiB |
9af52f2+dirty | 2.92 MiB | 3.41 MiB | 500.73 KiB |
c1659ab+dirty | 2.92 MiB | 3.42 MiB | 516.67 KiB |
357b71f+dirty | 2.92 MiB | 3.44 MiB | 538.23 KiB |
1573004+dirty | 2.92 MiB | 3.43 MiB | 525.73 KiB |
bruno-garcia
force-pushed
the
deps/scripts/update-cocoa.sh
branch
from
March 6, 2024 09:24
6ee04ec
to
b26c270
Compare
bruno-garcia
force-pushed
the
deps/scripts/update-cocoa.sh
branch
from
March 6, 2024 12:34
b26c270
to
db6a256
Compare
krystofwoldrich
approved these changes
Mar 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps scripts/update-cocoa.sh from 8.20.0 to 8.21.0.
Auto-generated by a dependency updater.
Changelog
8.21.0
Features
for development. Read our blog post to find out more.
SentrySDK.detectedStartUpCrash
(#3644)Improvements
Fixes
free_storage
andstorage_size
from the device context (#3627), because Apple forbids sendinginformation retrieved via
NSFileSystemFreeSize
andNSFileSystemSize
off a device; seeApple docs.
8.21.0-beta.0
Features
for development. Read our blog post to find out more.
SentrySDK.detectedStartUpCrash
(#3644)Improvements
Fixes
free_storage
andstorage_size
from the device context (#3627), because Apple forbids sendinginformation retrieved via
NSFileSystemFreeSize
andNSFileSystemSize
off a device; seeApple docs.