fix(expo): Ensure authToken is not written to application package #3630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 80b2ce3+dirty | 1265.92 ms | 1268.60 ms | 2.69 ms |
| d7401ac+dirty | 1252.38 ms | 1275.04 ms | 22.66 ms |
| e5c9b8b+dirty | 1258.57 ms | 1267.32 ms | 8.75 ms |
| acadc0f+dirty | 1264.38 ms | 1290.06 ms | 25.68 ms |
| 728164b+dirty | 1256.10 ms | 1259.08 ms | 2.98 ms |
| 3ffcddd+dirty | 1244.47 ms | 1264.14 ms | 19.67 ms |
| 9a3ca65+dirty | 1247.06 ms | 1274.58 ms | 27.52 ms |
| 457e29f+dirty | 1253.94 ms | 1269.18 ms | 15.24 ms |
| 12427f4+dirty | 1267.15 ms | 1271.30 ms | 4.15 ms |
| 2534337+dirty | 1225.08 ms | 1230.26 ms | 5.17 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 80b2ce3+dirty | 2.36 MiB | 2.84 MiB | 486.98 KiB |
| d7401ac+dirty | 2.36 MiB | 2.83 MiB | 481.14 KiB |
| e5c9b8b+dirty | 2.36 MiB | 2.87 MiB | 520.43 KiB |
| acadc0f+dirty | 2.36 MiB | 2.83 MiB | 480.37 KiB |
| 728164b+dirty | 2.36 MiB | 2.88 MiB | 530.38 KiB |
| 3ffcddd+dirty | 2.36 MiB | 2.84 MiB | 489.60 KiB |
| 9a3ca65+dirty | 2.36 MiB | 2.82 MiB | 462.89 KiB |
| 457e29f+dirty | 2.36 MiB | 2.87 MiB | 520.67 KiB |
| 12427f4+dirty | 2.36 MiB | 2.88 MiB | 530.38 KiB |
| 2534337+dirty | 2.36 MiB | 2.88 MiB | 525.47 KiB |
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3853f43 | 329.68 ms | 346.32 ms | 16.64 ms |
| e2b64fe | 316.88 ms | 330.23 ms | 13.35 ms |
| 1d86dd6 | 405.14 ms | 411.06 ms | 5.92 ms |
| 9433f35 | 347.64 ms | 356.22 ms | 8.58 ms |
| 34aba08 | 328.10 ms | 342.84 ms | 14.74 ms |
| 8900e1a+dirty | 430.68 ms | 456.13 ms | 25.44 ms |
| e73f4ed+dirty | 332.96 ms | 354.33 ms | 21.37 ms |
| e5c9b8b | 409.02 ms | 426.66 ms | 17.64 ms |
| acadc0f+dirty | 373.24 ms | 381.51 ms | 8.27 ms |
| ad6c299 | 375.94 ms | 382.02 ms | 6.08 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3853f43 | 17.73 MiB | 19.81 MiB | 2.08 MiB |
| e2b64fe | 17.73 MiB | 19.80 MiB | 2.07 MiB |
| 1d86dd6 | 17.73 MiB | 19.86 MiB | 2.12 MiB |
| 9433f35 | 17.73 MiB | 19.81 MiB | 2.08 MiB |
| 34aba08 | 17.73 MiB | 19.80 MiB | 2.07 MiB |
| 8900e1a+dirty | 17.73 MiB | 19.75 MiB | 2.01 MiB |
| e73f4ed+dirty | 17.73 MiB | 20.04 MiB | 2.31 MiB |
| e5c9b8b | 17.73 MiB | 19.83 MiB | 2.10 MiB |
| acadc0f+dirty | 17.73 MiB | 19.75 MiB | 2.01 MiB |
| ad6c299 | 17.73 MiB | 19.75 MiB | 2.02 MiB |
kahest
reviewed
Feb 26, 2024
Co-authored-by: Karl Heinz Struggl <[email protected]>
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| abb7058+dirty | 320.78 ms | 324.08 ms | 3.30 ms |
| 8900e1a+dirty | 371.40 ms | 377.70 ms | 6.31 ms |
| e5c9b8b+dirty | 335.40 ms | 360.06 ms | 24.67 ms |
| 575f9da+dirty | 337.15 ms | 370.47 ms | 33.32 ms |
| e73f4ed+dirty | 262.98 ms | 311.02 ms | 48.04 ms |
| acadc0f+dirty | 259.04 ms | 304.67 ms | 45.63 ms |
| dadc233+dirty | 363.19 ms | 370.37 ms | 7.18 ms |
| 34aba08+dirty | 331.79 ms | 376.69 ms | 44.91 ms |
| 12427f4+dirty | 379.48 ms | 400.92 ms | 21.44 ms |
| 457e29f+dirty | 591.49 ms | 612.96 ms | 21.47 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| abb7058+dirty | 7.15 MiB | 8.10 MiB | 980.40 KiB |
| 8900e1a+dirty | 7.15 MiB | 8.03 MiB | 901.79 KiB |
| e5c9b8b+dirty | 7.15 MiB | 8.10 MiB | 980.41 KiB |
| 575f9da+dirty | 7.15 MiB | 8.10 MiB | 979.68 KiB |
| e73f4ed+dirty | 7.15 MiB | 8.09 MiB | 965.94 KiB |
| acadc0f+dirty | 7.15 MiB | 8.03 MiB | 903.20 KiB |
| dadc233+dirty | 7.15 MiB | 8.04 MiB | 910.84 KiB |
| 34aba08+dirty | 7.15 MiB | 8.07 MiB | 946.13 KiB |
| 12427f4+dirty | 7.15 MiB | 8.12 MiB | 997.78 KiB |
| 457e29f+dirty | 7.15 MiB | 8.10 MiB | 981.29 KiB |
kahest
approved these changes
Feb 26, 2024
krystofwoldrich
deleted the
kw-expo-remove-auth-token-from-app-package
branch
krystofwoldrich
added a commit
that referenced
this pull request
Feb 26, 2024
) Co-authored-by: Karl Heinz Struggl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Processed Expo plugin configuration is saved in plain text in the application package.
This PR removes the
authTokenproperty to ensure the value won't be saved in the app package.💚 How did you test it?
expo sample app
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps
SENTRY_AUTH_TOKENenvauthTokenoption from the Expo setup page sentry-docs#9244