Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): TurboModuleRegistry should not be imported in web apps #3610

Merged
merged 8 commits into from
Mar 5, 2024

Conversation

krystofwoldrich
Copy link
Member

@krystofwoldrich krystofwoldrich commented Feb 20, 2024

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

This PR removes TurboModulesRegistry import from react-native-web builds.

💡 Motivation and Context

fixes: #3527

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

🔮 Next steps

@krystofwoldrich krystofwoldrich changed the title fix(web): TurboModuleRegistry should not be imported in web applica… fix(web): TurboModuleRegistry should not be imported in web apps Feb 20, 2024
Copy link
Contributor

github-actions bot commented Feb 20, 2024

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 413.31 ms 435.83 ms 22.52 ms
Size 17.73 MiB 19.91 MiB 2.17 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
3853f43 329.68 ms 346.32 ms 16.64 ms
e2b64fe 316.88 ms 330.23 ms 13.35 ms
1d86dd6 405.14 ms 411.06 ms 5.92 ms
9433f35 347.64 ms 356.22 ms 8.58 ms
34aba08 328.10 ms 342.84 ms 14.74 ms
8900e1a+dirty 430.68 ms 456.13 ms 25.44 ms
e73f4ed+dirty 332.96 ms 354.33 ms 21.37 ms
e5c9b8b 409.02 ms 426.66 ms 17.64 ms
acadc0f+dirty 373.24 ms 381.51 ms 8.27 ms
ad6c299 375.94 ms 382.02 ms 6.08 ms

App size

Revision Plain With Sentry Diff
3853f43 17.73 MiB 19.81 MiB 2.08 MiB
e2b64fe 17.73 MiB 19.80 MiB 2.07 MiB
1d86dd6 17.73 MiB 19.86 MiB 2.12 MiB
9433f35 17.73 MiB 19.81 MiB 2.08 MiB
34aba08 17.73 MiB 19.80 MiB 2.07 MiB
8900e1a+dirty 17.73 MiB 19.75 MiB 2.01 MiB
e73f4ed+dirty 17.73 MiB 20.04 MiB 2.31 MiB
e5c9b8b 17.73 MiB 19.83 MiB 2.10 MiB
acadc0f+dirty 17.73 MiB 19.75 MiB 2.01 MiB
ad6c299 17.73 MiB 19.75 MiB 2.02 MiB

Copy link
Contributor

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1221.76 ms 1221.88 ms 0.12 ms
Size 2.92 MiB 3.47 MiB 562.36 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
80b2ce3+dirty 1245.12 ms 1262.04 ms 16.92 ms
d7401ac+dirty 1288.10 ms 1289.54 ms 1.44 ms
e5c9b8b+dirty 1276.90 ms 1280.92 ms 4.02 ms
acadc0f+dirty 1271.12 ms 1272.28 ms 1.16 ms
728164b+dirty 1280.06 ms 1285.26 ms 5.20 ms
3ffcddd+dirty 1272.22 ms 1273.98 ms 1.76 ms
9a3ca65+dirty 1276.40 ms 1279.14 ms 2.74 ms
457e29f+dirty 1256.71 ms 1258.50 ms 1.79 ms
12427f4+dirty 1224.90 ms 1231.40 ms 6.50 ms
2534337+dirty 1220.87 ms 1221.47 ms 0.60 ms

App size

Revision Plain With Sentry Diff
80b2ce3+dirty 2.92 MiB 3.40 MiB 492.75 KiB
d7401ac+dirty 2.92 MiB 3.40 MiB 488.06 KiB
e5c9b8b+dirty 2.92 MiB 3.43 MiB 524.50 KiB
acadc0f+dirty 2.92 MiB 3.39 MiB 487.34 KiB
728164b+dirty 2.92 MiB 3.44 MiB 533.26 KiB
3ffcddd+dirty 2.92 MiB 3.40 MiB 494.39 KiB
9a3ca65+dirty 2.92 MiB 3.37 MiB 464.32 KiB
457e29f+dirty 2.92 MiB 3.43 MiB 524.75 KiB
12427f4+dirty 2.92 MiB 3.44 MiB 533.29 KiB
2534337+dirty 2.92 MiB 3.43 MiB 529.76 KiB

Copy link
Contributor

github-actions bot commented Feb 26, 2024

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1197.16 ms 1203.80 ms 6.63 ms
Size 2.36 MiB 2.91 MiB 558.18 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
80b2ce3+dirty 1265.92 ms 1268.60 ms 2.69 ms
d7401ac+dirty 1252.38 ms 1275.04 ms 22.66 ms
e5c9b8b+dirty 1258.57 ms 1267.32 ms 8.75 ms
acadc0f+dirty 1264.38 ms 1290.06 ms 25.68 ms
728164b+dirty 1256.10 ms 1259.08 ms 2.98 ms
3ffcddd+dirty 1244.47 ms 1264.14 ms 19.67 ms
9a3ca65+dirty 1247.06 ms 1274.58 ms 27.52 ms
457e29f+dirty 1253.94 ms 1269.18 ms 15.24 ms
12427f4+dirty 1267.15 ms 1271.30 ms 4.15 ms
2534337+dirty 1225.08 ms 1230.26 ms 5.17 ms

App size

Revision Plain With Sentry Diff
80b2ce3+dirty 2.36 MiB 2.84 MiB 486.98 KiB
d7401ac+dirty 2.36 MiB 2.83 MiB 481.14 KiB
e5c9b8b+dirty 2.36 MiB 2.87 MiB 520.43 KiB
acadc0f+dirty 2.36 MiB 2.83 MiB 480.37 KiB
728164b+dirty 2.36 MiB 2.88 MiB 530.38 KiB
3ffcddd+dirty 2.36 MiB 2.84 MiB 489.60 KiB
9a3ca65+dirty 2.36 MiB 2.82 MiB 462.89 KiB
457e29f+dirty 2.36 MiB 2.87 MiB 520.67 KiB
12427f4+dirty 2.36 MiB 2.88 MiB 530.38 KiB
2534337+dirty 2.36 MiB 2.88 MiB 525.47 KiB

Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lucas-zimerman lucas-zimerman merged commit d19819c into main Mar 5, 2024
33 of 52 checks passed
@lucas-zimerman lucas-zimerman deleted the kw-fix-rn-web-turbomoduleregistry branch March 5, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

react-native-web with Webpack warn about TurboModuleRegistry not found
2 participants