-
-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(spotlight): Stop tracing Sidecar network request in JS #3559
Merged
krystofwoldrich
merged 23 commits into
main
from
kw-remove-spotlight-network-requests-from-events
Jan 31, 2024
Merged
fix(spotlight): Stop tracing Sidecar network request in JS #3559
krystofwoldrich
merged 23 commits into
main
from
kw-remove-spotlight-network-requests-from-events
Jan 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android (legacy) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
12427f4 | 393.69 ms | 414.84 ms | 21.14 ms |
5446992 | 403.40 ms | 426.70 ms | 23.30 ms |
dadc233+dirty | 333.78 ms | 343.94 ms | 10.16 ms |
22e31b6 | 396.48 ms | 419.64 ms | 23.16 ms |
f06c879 | 408.41 ms | 424.54 ms | 16.13 ms |
b1e8712 | 462.11 ms | 465.71 ms | 3.60 ms |
34aba08 | 328.10 ms | 342.84 ms | 14.74 ms |
70caa60+dirty | 299.00 ms | 321.02 ms | 22.02 ms |
e73f4ed+dirty | 332.96 ms | 354.33 ms | 21.37 ms |
2534337 | 394.15 ms | 415.12 ms | 20.97 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
12427f4 | 17.73 MiB | 19.85 MiB | 2.12 MiB |
5446992 | 17.73 MiB | 19.85 MiB | 2.12 MiB |
dadc233+dirty | 17.73 MiB | 19.75 MiB | 2.02 MiB |
22e31b6 | 17.73 MiB | 19.84 MiB | 2.10 MiB |
f06c879 | 17.73 MiB | 19.85 MiB | 2.12 MiB |
b1e8712 | 17.73 MiB | 19.75 MiB | 2.02 MiB |
34aba08 | 17.73 MiB | 19.80 MiB | 2.07 MiB |
70caa60+dirty | 17.73 MiB | 19.75 MiB | 2.01 MiB |
e73f4ed+dirty | 17.73 MiB | 20.04 MiB | 2.31 MiB |
2534337 | 17.73 MiB | 19.84 MiB | 2.11 MiB |
iOS (legacy) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
9433f35+dirty | 1246.94 ms | 1271.45 ms | 24.52 ms |
9c48b2c+dirty | 1246.96 ms | 1255.73 ms | 8.77 ms |
1d86dd6+dirty | 1249.71 ms | 1279.16 ms | 29.45 ms |
d361d38+dirty | 1246.04 ms | 1267.12 ms | 21.08 ms |
12427f4+dirty | 1267.15 ms | 1271.30 ms | 4.15 ms |
6e8584e+dirty | 1274.50 ms | 1296.82 ms | 22.32 ms |
3ffcddd+dirty | 1244.47 ms | 1264.14 ms | 19.67 ms |
22e31b6+dirty | 1253.62 ms | 1265.96 ms | 12.34 ms |
0677344+dirty | 1276.70 ms | 1300.07 ms | 23.37 ms |
3853f43+dirty | 1221.82 ms | 1242.64 ms | 20.82 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
9433f35+dirty | 2.36 MiB | 2.85 MiB | 499.80 KiB |
9c48b2c+dirty | 2.36 MiB | 2.85 MiB | 495.77 KiB |
1d86dd6+dirty | 2.36 MiB | 2.89 MiB | 535.43 KiB |
d361d38+dirty | 2.36 MiB | 2.85 MiB | 499.84 KiB |
12427f4+dirty | 2.36 MiB | 2.88 MiB | 530.38 KiB |
6e8584e+dirty | 2.36 MiB | 2.88 MiB | 533.17 KiB |
3ffcddd+dirty | 2.36 MiB | 2.84 MiB | 489.60 KiB |
22e31b6+dirty | 2.36 MiB | 2.87 MiB | 520.67 KiB |
0677344+dirty | 2.36 MiB | 2.85 MiB | 496.81 KiB |
3853f43+dirty | 2.36 MiB | 2.85 MiB | 499.81 KiB |
iOS (new) Performance metrics 🚀
|
…e-spotlight-network-requests-from-events
…ator-source-context
…e-spotlight-network-requests-from-events
Android (new) Performance metrics 🚀
|
…ator-source-context
…e-spotlight-network-requests-from-events
Base automatically changed from
kw-fix-debug-symbolicator-source-context
to
main
January 31, 2024 10:42
…etwork-requests-from-events
mydea
approved these changes
Jan 31, 2024
krystofwoldrich
deleted the
kw-remove-spotlight-network-requests-from-events
branch
January 31, 2024 11:03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
The current approach makes the network request from the Spotlight Integration to the Sidecart visible in breadcrumbs, performance, and errors if one occurs. This PR changes to the StealthXhr implementation which uses the
__sentry_original__
methods, so the calls are not traced by Sentry.💚 How did you test it?
sample app
📝 Checklist
sendDefaultPII
is enabled🔮 Next steps