Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spotlight): Stop tracing Sidecar network request in JS #3559

Merged
merged 23 commits into from
Jan 31, 2024

Conversation

krystofwoldrich
Copy link
Member

@krystofwoldrich krystofwoldrich commented Jan 27, 2024

📢 Type of change

  • Bugfix
  • Enhancement
  • Refactoring

📜 Description

The current approach makes the network request from the Spotlight Integration to the Sidecart visible in breadcrumbs, performance, and errors if one occurs. This PR changes to the StealthXhr implementation which uses the __sentry_original__ methods, so the calls are not traced by Sentry.

💚 How did you test it?

sample app

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

🔮 Next steps

Copy link
Contributor

github-actions bot commented Jan 27, 2024

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 426.68 ms 443.37 ms 16.69 ms
Size 17.73 MiB 19.85 MiB 2.11 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
12427f4 393.69 ms 414.84 ms 21.14 ms
5446992 403.40 ms 426.70 ms 23.30 ms
dadc233+dirty 333.78 ms 343.94 ms 10.16 ms
22e31b6 396.48 ms 419.64 ms 23.16 ms
f06c879 408.41 ms 424.54 ms 16.13 ms
b1e8712 462.11 ms 465.71 ms 3.60 ms
34aba08 328.10 ms 342.84 ms 14.74 ms
70caa60+dirty 299.00 ms 321.02 ms 22.02 ms
e73f4ed+dirty 332.96 ms 354.33 ms 21.37 ms
2534337 394.15 ms 415.12 ms 20.97 ms

App size

Revision Plain With Sentry Diff
12427f4 17.73 MiB 19.85 MiB 2.12 MiB
5446992 17.73 MiB 19.85 MiB 2.12 MiB
dadc233+dirty 17.73 MiB 19.75 MiB 2.02 MiB
22e31b6 17.73 MiB 19.84 MiB 2.10 MiB
f06c879 17.73 MiB 19.85 MiB 2.12 MiB
b1e8712 17.73 MiB 19.75 MiB 2.02 MiB
34aba08 17.73 MiB 19.80 MiB 2.07 MiB
70caa60+dirty 17.73 MiB 19.75 MiB 2.01 MiB
e73f4ed+dirty 17.73 MiB 20.04 MiB 2.31 MiB
2534337 17.73 MiB 19.84 MiB 2.11 MiB

Copy link
Contributor

github-actions bot commented Jan 27, 2024

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1195.77 ms 1206.45 ms 10.68 ms
Size 2.36 MiB 2.88 MiB 527.08 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
9433f35+dirty 1246.94 ms 1271.45 ms 24.52 ms
9c48b2c+dirty 1246.96 ms 1255.73 ms 8.77 ms
1d86dd6+dirty 1249.71 ms 1279.16 ms 29.45 ms
d361d38+dirty 1246.04 ms 1267.12 ms 21.08 ms
12427f4+dirty 1267.15 ms 1271.30 ms 4.15 ms
6e8584e+dirty 1274.50 ms 1296.82 ms 22.32 ms
3ffcddd+dirty 1244.47 ms 1264.14 ms 19.67 ms
22e31b6+dirty 1253.62 ms 1265.96 ms 12.34 ms
0677344+dirty 1276.70 ms 1300.07 ms 23.37 ms
3853f43+dirty 1221.82 ms 1242.64 ms 20.82 ms

App size

Revision Plain With Sentry Diff
9433f35+dirty 2.36 MiB 2.85 MiB 499.80 KiB
9c48b2c+dirty 2.36 MiB 2.85 MiB 495.77 KiB
1d86dd6+dirty 2.36 MiB 2.89 MiB 535.43 KiB
d361d38+dirty 2.36 MiB 2.85 MiB 499.84 KiB
12427f4+dirty 2.36 MiB 2.88 MiB 530.38 KiB
6e8584e+dirty 2.36 MiB 2.88 MiB 533.17 KiB
3ffcddd+dirty 2.36 MiB 2.84 MiB 489.60 KiB
22e31b6+dirty 2.36 MiB 2.87 MiB 520.67 KiB
0677344+dirty 2.36 MiB 2.85 MiB 496.81 KiB
3853f43+dirty 2.36 MiB 2.85 MiB 499.81 KiB

Copy link
Contributor

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1236.06 ms 1237.06 ms 1.00 ms
Size 2.92 MiB 3.44 MiB 531.46 KiB

Copy link
Contributor

github-actions bot commented Jan 29, 2024

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 327.91 ms 353.59 ms 25.68 ms
Size 7.15 MiB 8.12 MiB 991.49 KiB

Baseline results on branch: kw-fix-debug-symbolicator-source-context

Startup times

Revision Plain With Sentry Diff
2eedbc6+dirty 332.49 ms 354.18 ms 21.69 ms

App size

Revision Plain With Sentry Diff
2eedbc6+dirty 7.15 MiB 8.12 MiB 991.19 KiB

@krystofwoldrich krystofwoldrich requested a review from mydea January 29, 2024 13:29
@krystofwoldrich krystofwoldrich marked this pull request as ready for review January 29, 2024 13:29
Base automatically changed from kw-fix-debug-symbolicator-source-context to main January 31, 2024 10:42
@krystofwoldrich krystofwoldrich merged commit 6c91dce into main Jan 31, 2024
43 of 45 checks passed
@krystofwoldrich krystofwoldrich deleted the kw-remove-spotlight-network-requests-from-events branch January 31, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants