fix(debugsymbolicator): Don't trace debug symbolicator source context Metro Dev Server requests #3553

krystofwoldrich · 2024-01-25T21:51:38Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

📜 Description

Example Erro produced by the DebugSymbolicator integration when trying to download the Source Context for Development Builds Symbolication. https://sentry-sdks.sentry.io/issues/4058613036/events/5612d59c349740c79bbd3c01a317ad8e/

These requests should not be traced by Sentry, as they are part of the SDK implementation and present only in dev builds.

💚 How did you test it?

sample apps

📝 Checklist

I reviewed submitted code
I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
All tests passing
No breaking changes

🔮 Next steps

…stname detection

… requests

github-actions · 2024-01-25T22:23:16Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	332.49 ms	354.18 ms	21.69 ms
Size	7.15 MiB	8.12 MiB	991.19 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`abb7058`+dirty	320.78 ms	324.08 ms	3.30 ms
`dadc233`+dirty	363.19 ms	370.37 ms	7.18 ms
`ad6c299`+dirty	336.47 ms	362.89 ms	26.42 ms
`d361d38`+dirty	257.72 ms	318.76 ms	61.04 ms
`e2b64fe`+dirty	258.82 ms	304.26 ms	45.44 ms
`e5c9b8b`+dirty	335.40 ms	360.06 ms	24.67 ms
`457e29f`+dirty	591.49 ms	612.96 ms	21.47 ms
`2534337`+dirty	597.14 ms	665.04 ms	67.90 ms
`70caa60`+dirty	308.83 ms	393.06 ms	84.23 ms
`5446992`+dirty	371.61 ms	390.00 ms	18.39 ms

App size

Revision	Plain	With Sentry	Diff
`abb7058`+dirty	7.15 MiB	8.10 MiB	980.40 KiB
`dadc233`+dirty	7.15 MiB	8.04 MiB	910.84 KiB
`ad6c299`+dirty	7.15 MiB	8.04 MiB	912.17 KiB
`d361d38`+dirty	7.15 MiB	8.08 MiB	959.34 KiB
`e2b64fe`+dirty	7.15 MiB	8.07 MiB	947.16 KiB
`e5c9b8b`+dirty	7.15 MiB	8.10 MiB	980.41 KiB
`457e29f`+dirty	7.15 MiB	8.10 MiB	981.29 KiB
`2534337`+dirty	7.15 MiB	8.11 MiB	988.68 KiB
`70caa60`+dirty	7.15 MiB	8.03 MiB	901.79 KiB
`5446992`+dirty	7.15 MiB	8.12 MiB	999.45 KiB

github-actions · 2024-01-25T22:45:09Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	454.33 ms	475.40 ms	21.07 ms
Size	17.73 MiB	19.85 MiB	2.11 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`12427f4`	393.69 ms	414.84 ms	21.14 ms
`5446992`	403.40 ms	426.70 ms	23.30 ms
`dadc233`+dirty	333.78 ms	343.94 ms	10.16 ms
`22e31b6`	396.48 ms	419.64 ms	23.16 ms
`f06c879`	408.41 ms	424.54 ms	16.13 ms
`b1e8712`	462.11 ms	465.71 ms	3.60 ms
`34aba08`	328.10 ms	342.84 ms	14.74 ms
`70caa60`+dirty	299.00 ms	321.02 ms	22.02 ms
`e73f4ed`+dirty	332.96 ms	354.33 ms	21.37 ms
`2534337`	394.15 ms	415.12 ms	20.97 ms

App size

Revision	Plain	With Sentry	Diff
`12427f4`	17.73 MiB	19.85 MiB	2.12 MiB
`5446992`	17.73 MiB	19.85 MiB	2.12 MiB
`dadc233`+dirty	17.73 MiB	19.75 MiB	2.02 MiB
`22e31b6`	17.73 MiB	19.84 MiB	2.10 MiB
`f06c879`	17.73 MiB	19.85 MiB	2.12 MiB
`b1e8712`	17.73 MiB	19.75 MiB	2.02 MiB
`34aba08`	17.73 MiB	19.80 MiB	2.07 MiB
`70caa60`+dirty	17.73 MiB	19.75 MiB	2.01 MiB
`e73f4ed`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`2534337`	17.73 MiB	19.84 MiB	2.11 MiB

github-actions · 2024-01-25T22:55:24Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1214.50 ms	1218.82 ms	4.32 ms
Size	2.36 MiB	2.88 MiB	527.04 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`9433f35`+dirty	1246.94 ms	1271.45 ms	24.52 ms
`9c48b2c`+dirty	1246.96 ms	1255.73 ms	8.77 ms
`1d86dd6`+dirty	1249.71 ms	1279.16 ms	29.45 ms
`d361d38`+dirty	1246.04 ms	1267.12 ms	21.08 ms
`12427f4`+dirty	1267.15 ms	1271.30 ms	4.15 ms
`6e8584e`+dirty	1274.50 ms	1296.82 ms	22.32 ms
`3ffcddd`+dirty	1244.47 ms	1264.14 ms	19.67 ms
`22e31b6`+dirty	1253.62 ms	1265.96 ms	12.34 ms
`0677344`+dirty	1276.70 ms	1300.07 ms	23.37 ms
`3853f43`+dirty	1221.82 ms	1242.64 ms	20.82 ms

App size

Revision	Plain	With Sentry	Diff
`9433f35`+dirty	2.36 MiB	2.85 MiB	499.80 KiB
`9c48b2c`+dirty	2.36 MiB	2.85 MiB	495.77 KiB
`1d86dd6`+dirty	2.36 MiB	2.89 MiB	535.43 KiB
`d361d38`+dirty	2.36 MiB	2.85 MiB	499.84 KiB
`12427f4`+dirty	2.36 MiB	2.88 MiB	530.38 KiB
`6e8584e`+dirty	2.36 MiB	2.88 MiB	533.17 KiB
`3ffcddd`+dirty	2.36 MiB	2.84 MiB	489.60 KiB
`22e31b6`+dirty	2.36 MiB	2.87 MiB	520.67 KiB
`0677344`+dirty	2.36 MiB	2.85 MiB	496.81 KiB
`3853f43`+dirty	2.36 MiB	2.85 MiB	499.81 KiB

Previous results on branch: kw-fix-debug-symbolicator-source-context

Startup times

Revision	Plain	With Sentry	Diff
`2eedbc6`+dirty	1206.28 ms	1208.86 ms	2.58 ms

App size

Revision	Plain	With Sentry	Diff
`2eedbc6`+dirty	2.36 MiB	2.88 MiB	527.01 KiB

…otlight

…-context

src/js/utils/xhr.ts

…ator-source-context

github-actions · 2024-01-29T13:26:58Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1232.27 ms	1232.53 ms	0.27 ms
Size	2.92 MiB	3.44 MiB	531.41 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`9433f35`+dirty	1232.24 ms	1232.74 ms	0.50 ms
`9c48b2c`+dirty	1253.39 ms	1256.30 ms	2.91 ms
`1d86dd6`+dirty	1289.25 ms	1293.36 ms	4.11 ms
`d361d38`+dirty	1272.96 ms	1291.70 ms	18.74 ms
`12427f4`+dirty	1224.90 ms	1231.40 ms	6.50 ms
`6e8584e`+dirty	1271.71 ms	1281.26 ms	9.55 ms
`3ffcddd`+dirty	1272.22 ms	1273.98 ms	1.76 ms
`22e31b6`+dirty	1276.55 ms	1278.12 ms	1.57 ms
`0677344`+dirty	1252.52 ms	1254.08 ms	1.56 ms
`3853f43`+dirty	1271.74 ms	1278.04 ms	6.30 ms

App size

Revision	Plain	With Sentry	Diff
`9433f35`+dirty	2.92 MiB	3.41 MiB	503.55 KiB
`9c48b2c`+dirty	2.92 MiB	3.41 MiB	499.97 KiB
`1d86dd6`+dirty	2.92 MiB	3.44 MiB	538.27 KiB
`d361d38`+dirty	2.92 MiB	3.41 MiB	503.57 KiB
`12427f4`+dirty	2.92 MiB	3.44 MiB	533.29 KiB
`6e8584e`+dirty	2.92 MiB	3.44 MiB	536.52 KiB
`3ffcddd`+dirty	2.92 MiB	3.40 MiB	494.39 KiB
`22e31b6`+dirty	2.92 MiB	3.43 MiB	524.74 KiB
`0677344`+dirty	2.92 MiB	3.41 MiB	500.94 KiB
`3853f43`+dirty	2.92 MiB	3.41 MiB	503.54 KiB

Previous results on branch: kw-fix-debug-symbolicator-source-context

Startup times

Revision	Plain	With Sentry	Diff
`2eedbc6`+dirty	1214.80 ms	1215.61 ms	0.81 ms

App size

Revision	Plain	With Sentry	Diff
`2eedbc6`+dirty	2.92 MiB	3.44 MiB	531.35 KiB

…ator-source-context

mydea

LGTM!

krystofwoldrich added 5 commits January 25, 2024 00:02

feat(integrations): Add Spotlight integration with auto dev server ho…

fa2b6e9

…stname detection

fix envelope overwrite

cbe8171

add new connection error message

8a02b59

fix(debugsymbolicator): Don't trace debug symbolicator source context…

6c231e6

… requests

add changelog

93f0257

fix lint and add tests

5429005

krystofwoldrich marked this pull request as ready for review January 25, 2024 22:31

krystofwoldrich requested a review from lucas-zimerman as a code owner January 25, 2024 22:31

krystofwoldrich requested a review from mydea January 26, 2024 22:25

krystofwoldrich and others added 6 commits January 26, 2024 17:43

add spotlight changelog

da8c265

Update CHANGELOG.md

955b399

add tests and easy to setup options

4424579

Merge remote-tracking branch 'origin/kw-add-spotlight' into kw-add-sp…

38adefe

…otlight

Merge remote-tracking branch 'origin/main' into kw-add-spotlight

0c2640c

Merge branch 'kw-add-spotlight' into kw-fix-debug-symbolicator-source…

3c47915

…-context

krystofwoldrich changed the base branch from main to kw-add-spotlight January 27, 2024 00:33

mydea reviewed Jan 29, 2024

View reviewed changes

src/js/utils/xhr.ts Outdated Show resolved Hide resolved

Use __sentry_original__ to create stealth xhr

6c7a7bd

krystofwoldrich requested a review from mydea January 29, 2024 12:11

Base automatically changed from kw-add-spotlight to main January 29, 2024 12:16

Merge remote-tracking branch 'origin/main' into kw-fix-debug-symbolic…

bd3de2f

…ator-source-context

krystofwoldrich added 2 commits January 31, 2024 11:21

if xhr not available return null

095bed0

Merge remote-tracking branch 'origin/main' into kw-fix-debug-symbolic…

0587152

…ator-source-context

mydea approved these changes Jan 31, 2024

View reviewed changes

krystofwoldrich merged commit 4e41557 into main Jan 31, 2024
43 of 45 checks passed

krystofwoldrich deleted the kw-fix-debug-symbolicator-source-context branch January 31, 2024 10:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(debugsymbolicator): Don't trace debug symbolicator source context Metro Dev Server requests #3553

fix(debugsymbolicator): Don't trace debug symbolicator source context Metro Dev Server requests #3553

krystofwoldrich commented Jan 25, 2024

github-actions bot commented Jan 25, 2024 •

edited

Loading

Baseline results on branch: main

Startup times

App size

github-actions bot commented Jan 25, 2024 •

edited

Loading

Baseline results on branch: main

Startup times

App size

github-actions bot commented Jan 25, 2024 •

edited

Loading

Baseline results on branch: main

Startup times

App size

Previous results on branch: kw-fix-debug-symbolicator-source-context

Startup times

App size

github-actions bot commented Jan 29, 2024 •

edited

Loading

Baseline results on branch: main

Startup times

App size

Previous results on branch: kw-fix-debug-symbolicator-source-context

Startup times

App size

mydea left a comment

fix(debugsymbolicator): Don't trace debug symbolicator source context Metro Dev Server requests #3553

fix(debugsymbolicator): Don't trace debug symbolicator source context Metro Dev Server requests #3553

Conversation

krystofwoldrich commented Jan 25, 2024

📢 Type of change

📜 Description

💚 How did you test it?

📝 Checklist

🔮 Next steps

github-actions bot commented Jan 25, 2024 • edited Loading

Android (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

github-actions bot commented Jan 25, 2024 • edited Loading

Android (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

github-actions bot commented Jan 25, 2024 • edited Loading

iOS (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: kw-fix-debug-symbolicator-source-context

Startup times

App size

github-actions bot commented Jan 29, 2024 • edited Loading

iOS (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: kw-fix-debug-symbolicator-source-context

Startup times

App size

mydea left a comment

Choose a reason for hiding this comment

github-actions bot commented Jan 25, 2024 •

edited

Loading

github-actions bot commented Jan 25, 2024 •

edited

Loading

github-actions bot commented Jan 25, 2024 •

edited

Loading

github-actions bot commented Jan 29, 2024 •

edited

Loading