Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Auto add release and dist to every artifact upload #3540

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

krystofwoldrich
Copy link
Member

@krystofwoldrich krystofwoldrich commented Jan 22, 2024

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

JS Bundlers Plugins do send the Release and Dist information regardless of the use of Debug IDs.

💡 Motivation and Context

Removal of the Release and Dist breaks compatibility with older Sentry versions without artifacts bundles support, so we will return it for a better user experience.

💚 How did you test it?

sample app

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

🔮 Next steps

Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 402.90 ms 433.89 ms 31.00 ms
Size 17.73 MiB 19.85 MiB 2.11 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
2534337 394.15 ms 415.12 ms 20.97 ms
e2b64fe 316.88 ms 330.23 ms 13.35 ms
12427f4 393.69 ms 414.84 ms 21.14 ms
d361d38 354.10 ms 381.69 ms 27.59 ms
acadc0f+dirty 373.24 ms 381.51 ms 8.27 ms
e73f4ed+dirty 332.96 ms 354.33 ms 21.37 ms
abb7058 370.27 ms 389.58 ms 19.31 ms
34aba08 328.10 ms 342.84 ms 14.74 ms
457e29f 398.10 ms 421.39 ms 23.29 ms
22e31b6 396.48 ms 419.64 ms 23.16 ms

App size

Revision Plain With Sentry Diff
2534337 17.73 MiB 19.84 MiB 2.11 MiB
e2b64fe 17.73 MiB 19.80 MiB 2.07 MiB
12427f4 17.73 MiB 19.85 MiB 2.12 MiB
d361d38 17.73 MiB 19.81 MiB 2.08 MiB
acadc0f+dirty 17.73 MiB 19.75 MiB 2.01 MiB
e73f4ed+dirty 17.73 MiB 20.04 MiB 2.31 MiB
abb7058 17.73 MiB 19.83 MiB 2.10 MiB
34aba08 17.73 MiB 19.80 MiB 2.07 MiB
457e29f 17.73 MiB 19.84 MiB 2.10 MiB
22e31b6 17.73 MiB 19.84 MiB 2.10 MiB

Copy link
Contributor

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1212.79 ms 1217.47 ms 4.68 ms
Size 2.92 MiB 3.44 MiB 530.83 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
9433f35+dirty 1232.24 ms 1232.74 ms 0.50 ms
9c48b2c+dirty 1253.39 ms 1256.30 ms 2.91 ms
1d86dd6+dirty 1289.25 ms 1293.36 ms 4.11 ms
d361d38+dirty 1272.96 ms 1291.70 ms 18.74 ms
12427f4+dirty 1224.90 ms 1231.40 ms 6.50 ms
6e8584e+dirty 1271.71 ms 1281.26 ms 9.55 ms
3ffcddd+dirty 1272.22 ms 1273.98 ms 1.76 ms
22e31b6+dirty 1276.55 ms 1278.12 ms 1.57 ms
0677344+dirty 1252.52 ms 1254.08 ms 1.56 ms
3853f43+dirty 1271.74 ms 1278.04 ms 6.30 ms

App size

Revision Plain With Sentry Diff
9433f35+dirty 2.92 MiB 3.41 MiB 503.55 KiB
9c48b2c+dirty 2.92 MiB 3.41 MiB 499.97 KiB
1d86dd6+dirty 2.92 MiB 3.44 MiB 538.27 KiB
d361d38+dirty 2.92 MiB 3.41 MiB 503.57 KiB
12427f4+dirty 2.92 MiB 3.44 MiB 533.29 KiB
6e8584e+dirty 2.92 MiB 3.44 MiB 536.52 KiB
3ffcddd+dirty 2.92 MiB 3.40 MiB 494.39 KiB
22e31b6+dirty 2.92 MiB 3.43 MiB 524.74 KiB
0677344+dirty 2.92 MiB 3.41 MiB 500.94 KiB
3853f43+dirty 2.92 MiB 3.41 MiB 503.54 KiB

@krystofwoldrich krystofwoldrich merged commit c365469 into main Jan 22, 2024
44 of 48 checks passed
@krystofwoldrich krystofwoldrich deleted the kw-fix-auto-upload-missing-release branch January 22, 2024 18:43
Copy link
Contributor

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Auto add release and dist to every artifact upload ([#3540](https://github.com/getsentry/sentry-react-native/pull/3540))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 318eaed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android app bundle build fails with error message "A release slug is required"
2 participants