Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xcode): node can't be overwritten in sentry-xcode-debug-files.sh #3523

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

krystofwoldrich
Copy link
Member

📢 Type of change

  • Bugfix

📜 Description

Before this PR the $NODE_BINARY could not be overwritten from the with_enviroment script. But only by explicitly setting the $NODE_BINARY env before the build. In new RN versions setting it with in the env script is common.

💚 How did you test it?

sample app

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

🔮 Next steps

Copy link
Contributor

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 398.48 ms 426.81 ms 28.33 ms
Size 17.73 MiB 19.85 MiB 2.11 MiB

Baseline results on branch: expo

Startup times

Revision Plain With Sentry Diff
bc4097b 419.25 ms 458.81 ms 39.56 ms

App size

Revision Plain With Sentry Diff
bc4097b 17.73 MiB 19.84 MiB 2.11 MiB

Base automatically changed from expo to main January 15, 2024 15:35
Copy link

@bitsandfoxes bitsandfoxes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Contributor

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 373.46 ms 408.94 ms 35.48 ms
Size 7.15 MiB 8.11 MiB 990.01 KiB

Baseline results on branch: expo

Startup times

Revision Plain With Sentry Diff
bc4097b+dirty 378.29 ms 413.31 ms 35.01 ms

App size

Revision Plain With Sentry Diff
bc4097b+dirty 7.15 MiB 8.11 MiB 988.88 KiB

@krystofwoldrich krystofwoldrich merged commit 7a6cb59 into main Jan 15, 2024
41 of 45 checks passed
@krystofwoldrich krystofwoldrich deleted the kw-fix-node-overwrite-sh branch January 15, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants