feat(expo): Dynamically resolve sentry-cli path in expo source maps upload script

[krystofwoldrich]

📢 Type of change

• Bugfix
• New feature
• Enhancement
• Refactoring

📜 Description

The hardcoded path could fail for certain mono repo scenarios and also for our own sample application.

💚 How did you test it?

sample app

📝 Checklist

• I reviewed submitted code
• I added tests to verify changes
• No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
• All tests passing
• No breaking changes

🔮 Next steps

[github-actions]

	Messages
📖	Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against ca94e8c

[lucas-zimerman]

Thanks for the PR!

[github-actions]

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	387.44 ms	412.42 ms	24.98 ms
Size	17.73 MiB	19.84 MiB	2.11 MiB

Baseline results on branch: expo

Startup times

Revision	Plain	With Sentry	Diff
bc4097b	419.25 ms	458.81 ms	39.56 ms

App size

Revision	Plain	With Sentry	Diff
bc4097b	17.73 MiB	19.84 MiB	2.11 MiB

[github-actions]

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	591.35 ms	648.80 ms	57.45 ms
Size	7.15 MiB	8.11 MiB	989.57 KiB

Baseline results on branch: expo

Startup times

Revision	Plain	With Sentry	Diff
bc4097b+dirty	378.29 ms	413.31 ms	35.01 ms

App size

Revision	Plain	With Sentry	Diff
bc4097b+dirty	7.15 MiB	8.11 MiB	988.88 KiB

[rklomp]

This is now giving me:

'D:\Development\MyApp\node_modules\@sentry\react-native\node_modules\@sentry\cli\bin\sentry-cli' is not recognized as an internal or external command, 
operable program or batch file.

"@sentry/cli": "^2.25.0" is in my devDependencies and installed. npx sentry-cli command is working.

Using on windows

[JustJoostNL]

@rklomp same issue here unfortunately.

[rklomp]

I am now using SENTRY_CLI_EXECUTABLE and that works. But it should be possible to auto detect sentry cli on windows as well.

[JustJoostNL]

Could you give an example of how you use that?

[rklomp]

I used this command in powershell.
[System.Environment]::SetEnvironmentVariable("SENTRY_CLI_EXECUTABLE","npx sentry-cli","User")

Just google how to set environment variable in windows. You can also set SENTRY_AUTH_TOKEN this way.

[JustJoostNL]

Thanks!