Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update Cocoa SDK to v8.17.1 #3412

Merged
merged 1 commit into from
Dec 4, 2023
Merged

chore(deps): update Cocoa SDK to v8.17.1 #3412

merged 1 commit into from
Dec 4, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 22, 2023 •
edited
Loading

Bumps scripts/update-cocoa.sh from 8.15.2 to 8.17.1.

Auto-generated by a dependency updater.

Changelog

8.17.1

Fixes

  • Crash when UINavigationController doesn't have rootViewController (#3455)
  • Crash when synchronizing invalid JSON breadcrumbs to SentryWatchdogTermination (#3458)
  • Check for NULL in binary image cache (#3469)
  • Threading issues in binary image cache (#3468)
  • Finish transaction for external view controllers (#3440)

8.17.0

Features

  • SwiftUI support is no longer in Beta (#3441)

8.16.1

Fixes

  • Fix inaccurate number of frames for transactions (#3439)

8.16.0

Features

  • Add screen name to app context (#3346)
  • Add cache directory option (#3369)

Fixes

  • Infinite loop when parsing MetricKit data (#3395)
  • Fix incorrect implementation in #3398 to work around a profiling crash (#3405)
  • Fix crash in SentryFramesTracker (#3424)

Improvements

  • Build XCFramework with Xcode 15 (#3415)

The XCFramework attached to GitHub releases is now built with Xcode 15.

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Nov 22, 2023
@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-cocoa.sh branch from 0fa07e9 to 9a9926f Compare November 22, 2023 03:02
@github-actions GitHub Actions
Copy link
Contributor Author

github-actions bot commented Nov 22, 2023 •
edited
Loading

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 332.80 ms 348.34 ms 15.54 ms
Size 17.73 MiB 19.84 MiB 2.11 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e5c9b8b 409.02 ms 426.66 ms 17.64 ms
d0bf494+dirty 375.37 ms 395.14 ms 19.77 ms
575f9da 415.26 ms 422.98 ms 7.72 ms
0db0c72 372.12 ms 386.00 ms 13.88 ms
e73f4ed+dirty 332.96 ms 354.33 ms 21.37 ms
acadc0f+dirty 373.24 ms 381.51 ms 8.27 ms
8900e1a+dirty 430.68 ms 456.13 ms 25.44 ms
3ffcddd 302.92 ms 315.80 ms 12.88 ms
d361d38 354.10 ms 381.69 ms 27.59 ms
f06c879 408.41 ms 424.54 ms 16.13 ms

App size

Revision Plain With Sentry Diff
e5c9b8b 17.73 MiB 19.83 MiB 2.10 MiB
d0bf494+dirty 17.73 MiB 19.75 MiB 2.02 MiB
575f9da 17.73 MiB 19.83 MiB 2.10 MiB
0db0c72 17.73 MiB 19.75 MiB 2.02 MiB
e73f4ed+dirty 17.73 MiB 20.04 MiB 2.31 MiB
acadc0f+dirty 17.73 MiB 19.75 MiB 2.01 MiB
8900e1a+dirty 17.73 MiB 19.75 MiB 2.01 MiB
3ffcddd 17.73 MiB 19.75 MiB 2.02 MiB
d361d38 17.73 MiB 19.81 MiB 2.08 MiB
f06c879 17.73 MiB 19.85 MiB 2.12 MiB

Previous results on branch: deps/scripts/update-cocoa.sh

Startup times

Revision Plain With Sentry Diff
c1659ab 333.94 ms 356.55 ms 22.61 ms
a4302f1 398.60 ms 428.38 ms 29.78 ms
1573004 381.49 ms 408.94 ms 27.45 ms
357b71f 401.70 ms 415.62 ms 13.92 ms
87d728a 426.02 ms 432.73 ms 6.71 ms
955f10d 351.88 ms 364.50 ms 12.62 ms
8da52c9+dirty 385.21 ms 422.36 ms 37.15 ms
94f9b87+dirty 319.37 ms 330.10 ms 10.73 ms
1dc092f 420.22 ms 434.90 ms 14.68 ms
5cca71b 316.82 ms 321.74 ms 4.93 ms

App size

Revision Plain With Sentry Diff
c1659ab 17.73 MiB 19.83 MiB 2.09 MiB
a4302f1 17.73 MiB 19.85 MiB 2.12 MiB
1573004 17.73 MiB 19.83 MiB 2.10 MiB
357b71f 17.73 MiB 19.86 MiB 2.12 MiB
87d728a 17.73 MiB 19.86 MiB 2.12 MiB
955f10d 17.73 MiB 19.80 MiB 2.07 MiB
8da52c9+dirty 17.73 MiB 20.04 MiB 2.31 MiB
94f9b87+dirty 17.73 MiB 19.75 MiB 2.01 MiB
1dc092f 17.73 MiB 19.84 MiB 2.10 MiB
5cca71b 17.73 MiB 19.83 MiB 2.09 MiB

@github-actions GitHub Actions
Copy link
Contributor Author

github-actions bot commented Nov 22, 2023 •
edited
Loading

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1210.85 ms 1214.46 ms 3.60 ms
Size 2.36 MiB 2.88 MiB 524.12 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d0bf494+dirty 1289.40 ms 1298.40 ms 9.00 ms
3853f43+dirty 1221.82 ms 1242.64 ms 20.82 ms
e73f4ed+dirty 1243.27 ms 1244.52 ms 1.25 ms
9c48b2c+dirty 1246.96 ms 1255.73 ms 8.77 ms
27ef4ee+dirty 1293.52 ms 1296.08 ms 2.56 ms
6e8584e+dirty 1274.50 ms 1296.82 ms 22.32 ms
acadc0f+dirty 1264.38 ms 1290.06 ms 25.68 ms
8900e1a+dirty 1210.27 ms 1218.66 ms 8.39 ms
e2b64fe+dirty 1232.22 ms 1255.20 ms 22.98 ms
e5c9b8b+dirty 1258.57 ms 1267.32 ms 8.75 ms

App size

Revision Plain With Sentry Diff
d0bf494+dirty 2.36 MiB 2.83 MiB 481.15 KiB
3853f43+dirty 2.36 MiB 2.85 MiB 499.81 KiB
e73f4ed+dirty 2.36 MiB 2.82 MiB 469.44 KiB
9c48b2c+dirty 2.36 MiB 2.85 MiB 495.77 KiB
27ef4ee+dirty 2.36 MiB 2.85 MiB 500.03 KiB
6e8584e+dirty 2.36 MiB 2.88 MiB 533.17 KiB
acadc0f+dirty 2.36 MiB 2.83 MiB 480.37 KiB
8900e1a+dirty 2.36 MiB 2.83 MiB 479.25 KiB
e2b64fe+dirty 2.36 MiB 2.85 MiB 495.80 KiB
e5c9b8b+dirty 2.36 MiB 2.87 MiB 520.43 KiB

Previous results on branch: deps/scripts/update-cocoa.sh

Startup times

Revision Plain With Sentry Diff
955f10d+dirty 1270.66 ms 1278.60 ms 7.94 ms
357b71f+dirty 1375.20 ms 1386.68 ms 11.48 ms
1362675+dirty 1269.88 ms 1270.82 ms 0.94 ms
9af52f2+dirty 1273.67 ms 1286.72 ms 13.05 ms
adb21f0+dirty 1252.08 ms 1258.48 ms 6.40 ms
19e1ada+dirty 1229.46 ms 1229.66 ms 0.20 ms
7787a29+dirty 1224.74 ms 1257.72 ms 32.98 ms
8da52c9+dirty 1214.59 ms 1224.90 ms 10.31 ms
a4302f1+dirty 1260.92 ms 1276.94 ms 16.02 ms
94f9b87+dirty 1260.32 ms 1283.72 ms 23.40 ms

App size

Revision Plain With Sentry Diff
955f10d+dirty 2.36 MiB 2.85 MiB 496.13 KiB
357b71f+dirty 2.36 MiB 2.89 MiB 535.40 KiB
1362675+dirty 2.36 MiB 2.87 MiB 522.53 KiB
9af52f2+dirty 2.36 MiB 2.85 MiB 497.02 KiB
adb21f0+dirty 2.36 MiB 2.87 MiB 522.40 KiB
19e1ada+dirty 2.36 MiB 2.88 MiB 530.87 KiB
7787a29+dirty 2.36 MiB 2.89 MiB 535.45 KiB
8da52c9+dirty 2.36 MiB 2.82 MiB 468.48 KiB
a4302f1+dirty 2.36 MiB 2.89 MiB 534.32 KiB
94f9b87+dirty 2.36 MiB 2.83 MiB 479.26 KiB

@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-cocoa.sh branch 2 times, most recently from a5d3f58 to a672773 Compare November 22, 2023 09:01
@github-actions GitHub Actions
Copy link
Contributor Author

github-actions bot commented Nov 22, 2023 •
edited
Loading

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1261.12 ms 1261.96 ms 0.84 ms
Size 2.92 MiB 3.43 MiB 526.57 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d0bf494+dirty 1266.20 ms 1267.52 ms 1.32 ms
3853f43+dirty 1271.74 ms 1278.04 ms 6.30 ms
e73f4ed+dirty 1282.90 ms 1309.30 ms 26.40 ms
9c48b2c+dirty 1253.39 ms 1256.30 ms 2.91 ms
27ef4ee+dirty 1236.41 ms 1244.90 ms 8.49 ms
6e8584e+dirty 1271.71 ms 1281.26 ms 9.55 ms
acadc0f+dirty 1271.12 ms 1272.28 ms 1.16 ms
8900e1a+dirty 1268.36 ms 1273.04 ms 4.68 ms
e2b64fe+dirty 1285.78 ms 1297.56 ms 11.78 ms
e5c9b8b+dirty 1276.90 ms 1280.92 ms 4.02 ms

App size

Revision Plain With Sentry Diff
d0bf494+dirty 2.92 MiB 3.40 MiB 488.08 KiB
3853f43+dirty 2.92 MiB 3.41 MiB 503.54 KiB
e73f4ed+dirty 2.92 MiB 3.38 MiB 475.71 KiB
9c48b2c+dirty 2.92 MiB 3.41 MiB 499.97 KiB
27ef4ee+dirty 2.92 MiB 3.41 MiB 503.72 KiB
6e8584e+dirty 2.92 MiB 3.44 MiB 536.52 KiB
acadc0f+dirty 2.92 MiB 3.39 MiB 487.34 KiB
8900e1a+dirty 2.92 MiB 3.39 MiB 485.96 KiB
e2b64fe+dirty 2.92 MiB 3.41 MiB 499.97 KiB
e5c9b8b+dirty 2.92 MiB 3.43 MiB 524.50 KiB

Previous results on branch: deps/scripts/update-cocoa.sh

Startup times

Revision Plain With Sentry Diff
955f10d+dirty 1293.94 ms 1298.86 ms 4.92 ms
357b71f+dirty 1277.00 ms 1286.64 ms 9.64 ms
1362675+dirty 1264.94 ms 1271.45 ms 6.52 ms
9af52f2+dirty 1256.52 ms 1258.94 ms 2.42 ms
adb21f0+dirty 1286.70 ms 1294.84 ms 8.14 ms
19e1ada+dirty 1279.37 ms 1288.34 ms 8.97 ms
7787a29+dirty 1264.62 ms 1267.54 ms 2.92 ms
8da52c9+dirty 1263.68 ms 1273.90 ms 10.22 ms
a4302f1+dirty 1228.08 ms 1230.64 ms 2.56 ms
94f9b87+dirty 1269.94 ms 1273.11 ms 3.17 ms

App size

Revision Plain With Sentry Diff
955f10d+dirty 2.92 MiB 3.41 MiB 499.55 KiB
357b71f+dirty 2.92 MiB 3.44 MiB 538.23 KiB
1362675+dirty 2.92 MiB 3.43 MiB 525.90 KiB
9af52f2+dirty 2.92 MiB 3.41 MiB 500.73 KiB
adb21f0+dirty 2.92 MiB 3.43 MiB 525.69 KiB
19e1ada+dirty 2.92 MiB 3.44 MiB 534.41 KiB
7787a29+dirty 2.92 MiB 3.44 MiB 538.29 KiB
8da52c9+dirty 2.92 MiB 3.38 MiB 474.71 KiB
a4302f1+dirty 2.92 MiB 3.44 MiB 537.56 KiB
94f9b87+dirty 2.92 MiB 3.39 MiB 485.98 KiB

@github-actions github-actions bot changed the title chore(deps): update Cocoa SDK to v8.16.0 chore(deps): update Cocoa SDK to v8.16.1 Nov 23, 2023
@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-cocoa.sh branch 2 times, most recently from 970f561 to dfa1da9 Compare November 23, 2023 11:16
@github-actions GitHub Actions
Copy link
Contributor Author

github-actions bot commented Nov 23, 2023 •
edited
Loading

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 369.71 ms 402.07 ms 32.35 ms
Size 7.15 MiB 8.11 MiB 988.22 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d0bf494+dirty 253.73 ms 308.23 ms 54.49 ms
3853f43+dirty 278.12 ms 338.72 ms 60.60 ms
e73f4ed+dirty 262.98 ms 311.02 ms 48.04 ms
9c48b2c+dirty 270.82 ms 321.12 ms 50.30 ms
27ef4ee+dirty 296.71 ms 351.00 ms 54.29 ms
6e8584e+dirty 383.37 ms 400.84 ms 17.47 ms
acadc0f+dirty 259.04 ms 304.67 ms 45.63 ms
8900e1a+dirty 371.40 ms 377.70 ms 6.31 ms
e2b64fe+dirty 258.82 ms 304.26 ms 45.44 ms
e5c9b8b+dirty 335.40 ms 360.06 ms 24.67 ms

App size

Revision Plain With Sentry Diff
d0bf494+dirty 7.15 MiB 8.04 MiB 910.85 KiB
3853f43+dirty 7.15 MiB 8.08 MiB 959.34 KiB
e73f4ed+dirty 7.15 MiB 8.09 MiB 965.94 KiB
9c48b2c+dirty 7.15 MiB 8.07 MiB 947.16 KiB
27ef4ee+dirty 7.15 MiB 8.08 MiB 959.49 KiB
6e8584e+dirty 7.15 MiB 8.13 MiB 1002.18 KiB
acadc0f+dirty 7.15 MiB 8.03 MiB 903.20 KiB
8900e1a+dirty 7.15 MiB 8.03 MiB 901.79 KiB
e2b64fe+dirty 7.15 MiB 8.07 MiB 947.16 KiB
e5c9b8b+dirty 7.15 MiB 8.10 MiB 980.41 KiB

Previous results on branch: deps/scripts/update-cocoa.sh

Startup times

Revision Plain With Sentry Diff
955f10d+dirty 306.27 ms 385.83 ms 79.57 ms
357b71f+dirty 318.48 ms 354.55 ms 36.07 ms
1362675+dirty 370.27 ms 402.51 ms 32.24 ms
9af52f2+dirty 272.87 ms 305.61 ms 32.74 ms
adb21f0+dirty 284.31 ms 347.06 ms 62.76 ms
19e1ada+dirty 366.56 ms 393.32 ms 26.76 ms
7787a29+dirty 340.33 ms 368.82 ms 28.48 ms
8da52c9+dirty 269.29 ms 290.76 ms 21.47 ms
a4302f1+dirty 383.10 ms 405.33 ms 22.23 ms
94f9b87+dirty 300.47 ms 353.74 ms 53.27 ms

App size

Revision Plain With Sentry Diff
955f10d+dirty 7.15 MiB 8.07 MiB 946.13 KiB
357b71f+dirty 7.15 MiB 8.13 MiB 1002.12 KiB
1362675+dirty 7.15 MiB 8.10 MiB 981.29 KiB
9af52f2+dirty 7.15 MiB 8.07 MiB 947.16 KiB
adb21f0+dirty 7.15 MiB 8.10 MiB 980.72 KiB
19e1ada+dirty 7.15 MiB 8.12 MiB 999.34 KiB
7787a29+dirty 7.15 MiB 8.13 MiB 1002.18 KiB
8da52c9+dirty 7.15 MiB 8.09 MiB 962.83 KiB
a4302f1+dirty 7.15 MiB 8.12 MiB 999.45 KiB
94f9b87+dirty 7.15 MiB 8.03 MiB 901.79 KiB

@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-cocoa.sh branch 3 times, most recently from 86da28e to 80e1555 Compare November 28, 2023 03:02
@github-actions github-actions bot changed the title chore(deps): update Cocoa SDK to v8.16.1 chore(deps): update Cocoa SDK to v8.17.0 Nov 28, 2023
@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-cocoa.sh branch 4 times, most recently from b2ace6c to 1b11d36 Compare December 1, 2023 09:11
@github-actions github-actions bot changed the title chore(deps): update Cocoa SDK to v8.17.0 chore(deps): update Cocoa SDK to v8.17.1 Dec 1, 2023
@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-cocoa.sh branch from 1b11d36 to 973cc4a Compare December 1, 2023 15:47
@krystofwoldrich krystofwoldrich enabled auto-merge (squash) December 4, 2023 09:16
@krystofwoldrich krystofwoldrich merged commit 4b4b999 into main Dec 4, 2023
60 of 61 checks passed
@krystofwoldrich krystofwoldrich deleted the deps/scripts/update-cocoa.sh branch December 4, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krystofwoldrich krystofwoldrich krystofwoldrich approved these changes

@lucas-zimerman lucas-zimerman Awaiting requested review from lucas-zimerman lucas-zimerman is a code owner

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krystofwoldrich @web-flow