feat(performance): Export New JS Performance API #3371

krystofwoldrich · 2023-10-31T15:04:52Z

📢 Type of change

Bugfix
New feature

📜 Description

Re export the New JS Performance API for React Native users.

💡 Motivation and Context

closes: No method named startSpan #3370

💚 How did you test it?

sample app

📝 Checklist

I reviewed submitted code
I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
All tests passing
No breaking changes

🔮 Next steps

github-actions · 2023-10-31T15:06:06Z

	Messages
📖	Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 939842e

github-actions · 2023-10-31T15:19:02Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	417.17 ms	430.96 ms	13.79 ms
Size	17.73 MiB	19.85 MiB	2.12 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`27ef4ee`	317.40 ms	321.70 ms	4.30 ms
`457e29f`	398.10 ms	421.39 ms	23.29 ms
`9c48b2c`	349.24 ms	385.96 ms	36.72 ms
`8900e1a`+dirty	430.68 ms	456.13 ms	25.44 ms
`d361d38`	354.10 ms	381.69 ms	27.59 ms
`9a3ca65`+dirty	326.93 ms	330.14 ms	3.21 ms
`d197b5c`+dirty	338.94 ms	354.87 ms	15.93 ms
`0677344`	327.74 ms	337.14 ms	9.40 ms
`0db0c72`	372.12 ms	386.00 ms	13.88 ms
`e5c9b8b`	409.02 ms	426.66 ms	17.64 ms

App size

Revision	Plain	With Sentry	Diff
`27ef4ee`	17.73 MiB	19.82 MiB	2.08 MiB
`457e29f`	17.73 MiB	19.84 MiB	2.10 MiB
`9c48b2c`	17.73 MiB	19.80 MiB	2.07 MiB
`8900e1a`+dirty	17.73 MiB	19.75 MiB	2.01 MiB
`d361d38`	17.73 MiB	19.81 MiB	2.08 MiB
`9a3ca65`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`d197b5c`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`0677344`	17.73 MiB	19.81 MiB	2.07 MiB
`0db0c72`	17.73 MiB	19.75 MiB	2.02 MiB
`e5c9b8b`	17.73 MiB	19.83 MiB	2.10 MiB

github-actions · 2023-10-31T15:31:23Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1259.42 ms	1261.42 ms	2.00 ms
Size	2.92 MiB	3.44 MiB	533.27 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`8900e1a`+dirty	1268.36 ms	1273.04 ms	4.68 ms
`9a3ca65`+dirty	1276.40 ms	1279.14 ms	2.74 ms
`34aba08`+dirty	1268.58 ms	1276.80 ms	8.22 ms
`d197b5c`+dirty	1234.80 ms	1249.20 ms	14.40 ms
`abb7058`+dirty	1260.28 ms	1266.56 ms	6.28 ms
`80b2ce3`+dirty	1245.12 ms	1262.04 ms	16.92 ms
`0677344`+dirty	1252.52 ms	1254.08 ms	1.56 ms
`3ffcddd`+dirty	1272.22 ms	1273.98 ms	1.76 ms
`728164b`+dirty	1280.06 ms	1285.26 ms	5.20 ms
`ad6c299`+dirty	1248.50 ms	1248.88 ms	0.38 ms

App size

Revision	Plain	With Sentry	Diff
`8900e1a`+dirty	2.92 MiB	3.39 MiB	485.96 KiB
`9a3ca65`+dirty	2.92 MiB	3.37 MiB	464.32 KiB
`34aba08`+dirty	2.92 MiB	3.41 MiB	499.03 KiB
`d197b5c`+dirty	2.92 MiB	3.37 MiB	464.41 KiB
`abb7058`+dirty	2.92 MiB	3.43 MiB	524.53 KiB
`80b2ce3`+dirty	2.92 MiB	3.40 MiB	492.75 KiB
`0677344`+dirty	2.92 MiB	3.41 MiB	500.94 KiB
`3ffcddd`+dirty	2.92 MiB	3.40 MiB	494.39 KiB
`728164b`+dirty	2.92 MiB	3.44 MiB	533.26 KiB
`ad6c299`+dirty	2.92 MiB	3.40 MiB	494.12 KiB

github-actions · 2023-10-31T18:00:52Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1261.33 ms	1267.02 ms	5.69 ms
Size	2.36 MiB	2.88 MiB	530.40 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`8900e1a`+dirty	1210.27 ms	1218.66 ms	8.39 ms
`9a3ca65`+dirty	1247.06 ms	1274.58 ms	27.52 ms
`34aba08`+dirty	1276.78 ms	1308.52 ms	31.74 ms
`d197b5c`+dirty	1217.61 ms	1242.66 ms	25.05 ms
`abb7058`+dirty	1255.42 ms	1268.86 ms	13.44 ms
`80b2ce3`+dirty	1265.92 ms	1268.60 ms	2.69 ms
`0677344`+dirty	1276.70 ms	1300.07 ms	23.37 ms
`3ffcddd`+dirty	1244.47 ms	1264.14 ms	19.67 ms
`728164b`+dirty	1256.10 ms	1259.08 ms	2.98 ms
`ad6c299`+dirty	1244.76 ms	1260.10 ms	15.34 ms

App size

Revision	Plain	With Sentry	Diff
`8900e1a`+dirty	2.36 MiB	2.83 MiB	479.25 KiB
`9a3ca65`+dirty	2.36 MiB	2.82 MiB	462.89 KiB
`34aba08`+dirty	2.36 MiB	2.85 MiB	495.32 KiB
`d197b5c`+dirty	2.36 MiB	2.82 MiB	462.86 KiB
`abb7058`+dirty	2.36 MiB	2.87 MiB	520.42 KiB
`80b2ce3`+dirty	2.36 MiB	2.84 MiB	486.98 KiB
`0677344`+dirty	2.36 MiB	2.85 MiB	496.81 KiB
`3ffcddd`+dirty	2.36 MiB	2.84 MiB	489.60 KiB
`728164b`+dirty	2.36 MiB	2.88 MiB	530.38 KiB
`ad6c299`+dirty	2.36 MiB	2.84 MiB	488.85 KiB

github-actions · 2023-10-31T18:02:41Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	336.69 ms	378.34 ms	41.65 ms
Size	7.15 MiB	8.12 MiB	997.78 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`8900e1a`+dirty	371.40 ms	377.70 ms	6.31 ms
`9a3ca65`+dirty	344.96 ms	358.92 ms	13.96 ms
`34aba08`+dirty	331.79 ms	376.69 ms	44.91 ms
`d197b5c`+dirty	258.75 ms	313.61 ms	54.86 ms
`abb7058`+dirty	320.78 ms	324.08 ms	3.30 ms
`80b2ce3`+dirty	271.29 ms	316.47 ms	45.18 ms
`0677344`+dirty	288.40 ms	391.44 ms	103.04 ms
`3ffcddd`+dirty	244.82 ms	295.47 ms	50.65 ms
`728164b`+dirty	335.93 ms	342.94 ms	7.01 ms
`ad6c299`+dirty	336.47 ms	362.89 ms	26.42 ms

App size

Revision	Plain	With Sentry	Diff
`8900e1a`+dirty	7.15 MiB	8.03 MiB	901.79 KiB
`9a3ca65`+dirty	7.15 MiB	8.09 MiB	962.83 KiB
`34aba08`+dirty	7.15 MiB	8.07 MiB	946.13 KiB
`d197b5c`+dirty	7.15 MiB	8.09 MiB	962.72 KiB
`abb7058`+dirty	7.15 MiB	8.10 MiB	980.40 KiB
`80b2ce3`+dirty	7.15 MiB	8.04 MiB	911.02 KiB
`0677344`+dirty	7.15 MiB	8.07 MiB	949.80 KiB
`3ffcddd`+dirty	7.15 MiB	8.04 MiB	912.17 KiB
`728164b`+dirty	7.15 MiB	8.12 MiB	997.71 KiB
`ad6c299`+dirty	7.15 MiB	8.04 MiB	912.17 KiB

…-performance

feat(performance): Export New JS Performance API

d41c3e6

krystofwoldrich requested a review from lucas-zimerman as a code owner October 31, 2023 15:04

krystofwoldrich requested review from lforst, Lms24 and AbhiPrasad October 31, 2023 17:28

krystofwoldrich added 2 commits October 31, 2023 18:29

Fix lint

9008928

Fix types

9915566

AbhiPrasad approved these changes Oct 31, 2023

View reviewed changes

krystofwoldrich added 2 commits October 31, 2023 19:03

Merge remote-tracking branch 'origin/main' into kw-fix-missing-new-js…

11d31b0

…-performance

fix changelog

939842e

krystofwoldrich merged commit ee1f570 into main Oct 31, 2023
43 of 44 checks passed

krystofwoldrich deleted the kw-fix-missing-new-js-performance branch October 31, 2023 18:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(performance): Export New JS Performance API #3371

feat(performance): Export New JS Performance API #3371

krystofwoldrich commented Oct 31, 2023

github-actions bot commented Oct 31, 2023 •

edited

Loading

github-actions bot commented Oct 31, 2023 •

edited

Loading

Baseline results on branch: main

Startup times

App size

github-actions bot commented Oct 31, 2023 •

edited

Loading

Baseline results on branch: main

Startup times

App size

github-actions bot commented Oct 31, 2023

Baseline results on branch: main

Startup times

App size

github-actions bot commented Oct 31, 2023 •

edited

Loading

Baseline results on branch: main

Startup times

App size

feat(performance): Export New JS Performance API #3371

feat(performance): Export New JS Performance API #3371

Conversation

krystofwoldrich commented Oct 31, 2023

📢 Type of change

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

github-actions bot commented Oct 31, 2023 • edited Loading

github-actions bot commented Oct 31, 2023 • edited Loading

Android (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

github-actions bot commented Oct 31, 2023 • edited Loading

iOS (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

github-actions bot commented Oct 31, 2023

iOS (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

github-actions bot commented Oct 31, 2023 • edited Loading

Android (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

github-actions bot commented Oct 31, 2023 •

edited

Loading

github-actions bot commented Oct 31, 2023 •

edited

Loading

github-actions bot commented Oct 31, 2023 •

edited

Loading

github-actions bot commented Oct 31, 2023 •

edited

Loading