fix(tracing): Use deprecated tracing origins option if set #3331

krystofwoldrich · 2023-10-09T08:48:34Z

📢 Type of change

Bugfix

📜 Description

Until the next major version, where we can remove the deprecated options, there are 3 ways to set trace propagation targets. The oldest tracingOrigins option was not working as the default value of the newer option always overwrote it.

💚 How did you test it?

sample app, unit tests

📝 Checklist

I reviewed submitted code
I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
All tests passing
No breaking changes

🔮 Next steps

… of trace propagation targets

github-actions · 2023-10-09T09:06:46Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	340.23 ms	349.06 ms	8.83 ms
Size	17.73 MiB	19.84 MiB	2.10 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`3ffcddd`	302.92 ms	315.80 ms	12.88 ms
`3853f43`	329.68 ms	346.32 ms	16.64 ms
`0db0c72`	372.12 ms	386.00 ms	13.88 ms
`d197b5c`+dirty	338.94 ms	354.87 ms	15.93 ms
`abb7058`	370.27 ms	389.58 ms	19.31 ms
`76d1baf`+dirty	335.72 ms	355.52 ms	19.80 ms
`0677344`	327.74 ms	337.14 ms	9.40 ms
`9c48b2c`	349.24 ms	385.96 ms	36.72 ms
`457e29f`	398.10 ms	421.39 ms	23.29 ms
`8900e1a`+dirty	430.68 ms	456.13 ms	25.44 ms

App size

Revision	Plain	With Sentry	Diff
`3ffcddd`	17.73 MiB	19.75 MiB	2.02 MiB
`3853f43`	17.73 MiB	19.81 MiB	2.08 MiB
`0db0c72`	17.73 MiB	19.75 MiB	2.02 MiB
`d197b5c`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`abb7058`	17.73 MiB	19.83 MiB	2.10 MiB
`76d1baf`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`0677344`	17.73 MiB	19.81 MiB	2.07 MiB
`9c48b2c`	17.73 MiB	19.80 MiB	2.07 MiB
`457e29f`	17.73 MiB	19.84 MiB	2.10 MiB
`8900e1a`+dirty	17.73 MiB	19.75 MiB	2.01 MiB

Previous results on branch: kw-fix-trace-propagation-options-deprecated-was-ignored

Startup times

Revision	Plain	With Sentry	Diff
`5439073`	337.57 ms	352.00 ms	14.43 ms

App size

Revision	Plain	With Sentry	Diff
`5439073`	17.73 MiB	19.84 MiB	2.10 MiB

github-actions · 2023-10-09T09:12:52Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1247.45 ms	1255.44 ms	7.99 ms
Size	2.36 MiB	2.87 MiB	520.76 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`27ef4ee`+dirty	1293.52 ms	1296.08 ms	2.56 ms
`0677344`+dirty	1276.70 ms	1300.07 ms	23.37 ms
`3853f43`+dirty	1221.82 ms	1242.64 ms	20.82 ms
`ad6c299`+dirty	1244.76 ms	1260.10 ms	15.34 ms
`34aba08`+dirty	1276.78 ms	1308.52 ms	31.74 ms
`d197b5c`+dirty	1217.61 ms	1242.66 ms	25.05 ms
`9433f35`+dirty	1246.94 ms	1271.45 ms	24.52 ms
`76d1baf`+dirty	1244.10 ms	1268.52 ms	24.42 ms
`80b2ce3`+dirty	1265.92 ms	1268.60 ms	2.69 ms
`457e29f`+dirty	1253.94 ms	1269.18 ms	15.24 ms

App size

Revision	Plain	With Sentry	Diff
`27ef4ee`+dirty	2.36 MiB	2.85 MiB	500.03 KiB
`0677344`+dirty	2.36 MiB	2.85 MiB	496.81 KiB
`3853f43`+dirty	2.36 MiB	2.85 MiB	499.81 KiB
`ad6c299`+dirty	2.36 MiB	2.84 MiB	488.85 KiB
`34aba08`+dirty	2.36 MiB	2.85 MiB	495.32 KiB
`d197b5c`+dirty	2.36 MiB	2.82 MiB	462.86 KiB
`9433f35`+dirty	2.36 MiB	2.85 MiB	499.80 KiB
`76d1baf`+dirty	2.36 MiB	2.82 MiB	469.45 KiB
`80b2ce3`+dirty	2.36 MiB	2.84 MiB	486.98 KiB
`457e29f`+dirty	2.36 MiB	2.87 MiB	520.67 KiB

Previous results on branch: kw-fix-trace-propagation-options-deprecated-was-ignored

Startup times

Revision	Plain	With Sentry	Diff
`5439073`+dirty	1267.84 ms	1271.62 ms	3.78 ms

App size

Revision	Plain	With Sentry	Diff
`5439073`+dirty	2.36 MiB	2.87 MiB	520.74 KiB

github-actions · 2023-10-09T09:24:18Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1260.98 ms	1268.50 ms	7.52 ms
Size	2.92 MiB	3.43 MiB	524.80 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`27ef4ee`+dirty	1236.41 ms	1244.90 ms	8.49 ms
`0677344`+dirty	1252.52 ms	1254.08 ms	1.56 ms
`3853f43`+dirty	1271.74 ms	1278.04 ms	6.30 ms
`ad6c299`+dirty	1248.50 ms	1248.88 ms	0.38 ms
`34aba08`+dirty	1268.58 ms	1276.80 ms	8.22 ms
`d197b5c`+dirty	1234.80 ms	1249.20 ms	14.40 ms
`9433f35`+dirty	1232.24 ms	1232.74 ms	0.50 ms
`76d1baf`+dirty	1245.00 ms	1257.76 ms	12.76 ms
`80b2ce3`+dirty	1245.12 ms	1262.04 ms	16.92 ms
`457e29f`+dirty	1256.71 ms	1258.50 ms	1.79 ms

App size

Revision	Plain	With Sentry	Diff
`27ef4ee`+dirty	2.92 MiB	3.41 MiB	503.72 KiB
`0677344`+dirty	2.92 MiB	3.41 MiB	500.94 KiB
`3853f43`+dirty	2.92 MiB	3.41 MiB	503.54 KiB
`ad6c299`+dirty	2.92 MiB	3.40 MiB	494.12 KiB
`34aba08`+dirty	2.92 MiB	3.41 MiB	499.03 KiB
`d197b5c`+dirty	2.92 MiB	3.37 MiB	464.41 KiB
`9433f35`+dirty	2.92 MiB	3.41 MiB	503.55 KiB
`76d1baf`+dirty	2.92 MiB	3.38 MiB	475.74 KiB
`80b2ce3`+dirty	2.92 MiB	3.40 MiB	492.75 KiB
`457e29f`+dirty	2.92 MiB	3.43 MiB	524.75 KiB

Previous results on branch: kw-fix-trace-propagation-options-deprecated-was-ignored

Startup times

Revision	Plain	With Sentry	Diff
`5439073`+dirty	1271.94 ms	1277.22 ms	5.28 ms

App size

Revision	Plain	With Sentry	Diff
`5439073`+dirty	2.92 MiB	3.43 MiB	524.83 KiB

github-actions · 2023-10-09T09:34:38Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	336.27 ms	369.20 ms	32.93 ms
Size	7.15 MiB	8.11 MiB	983.73 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`27ef4ee`+dirty	296.71 ms	351.00 ms	54.29 ms
`0677344`+dirty	288.40 ms	391.44 ms	103.04 ms
`3853f43`+dirty	278.12 ms	338.72 ms	60.60 ms
`ad6c299`+dirty	336.47 ms	362.89 ms	26.42 ms
`34aba08`+dirty	331.79 ms	376.69 ms	44.91 ms
`d197b5c`+dirty	258.75 ms	313.61 ms	54.86 ms
`9433f35`+dirty	265.50 ms	336.08 ms	70.58 ms
`76d1baf`+dirty	339.02 ms	408.65 ms	69.63 ms
`80b2ce3`+dirty	271.29 ms	316.47 ms	45.18 ms
`457e29f`+dirty	591.49 ms	612.96 ms	21.47 ms

App size

Revision	Plain	With Sentry	Diff
`27ef4ee`+dirty	7.15 MiB	8.08 MiB	959.49 KiB
`0677344`+dirty	7.15 MiB	8.07 MiB	949.80 KiB
`3853f43`+dirty	7.15 MiB	8.08 MiB	959.34 KiB
`ad6c299`+dirty	7.15 MiB	8.04 MiB	912.17 KiB
`34aba08`+dirty	7.15 MiB	8.07 MiB	946.13 KiB
`d197b5c`+dirty	7.15 MiB	8.09 MiB	962.72 KiB
`9433f35`+dirty	7.15 MiB	8.08 MiB	959.34 KiB
`76d1baf`+dirty	7.15 MiB	8.09 MiB	964.41 KiB
`80b2ce3`+dirty	7.15 MiB	8.04 MiB	911.02 KiB
`457e29f`+dirty	7.15 MiB	8.10 MiB	981.29 KiB

Lms24

LGTM, one optional suggestion.

Lms24 · 2023-10-09T10:35:23Z

test/tracing/reactnativetracing.test.ts

@@ -117,6 +119,98 @@ describe('ReactNativeTracing', () => {
    jest.clearAllMocks();
  });

+  describe('trace propagation targets', () => {


l/recommendation: Afaik, in the JS SDK we have tests that show which option is taken if multiple of these properties are specified. Admittedly it's an edge case, so feel free to disregard (not a blocker).

…ion-options-deprecated-was-ignored

krystofwoldrich added 2 commits October 6, 2023 16:58

fix(tracing): Ignore defaults when warning about duplicate definition…

d599fd1

… of trace propagation targets

fix(tracing): Use deprecated tracing origins option if set

0c5faff

krystofwoldrich requested a review from lucas-zimerman as a code owner October 9, 2023 08:48

krystofwoldrich requested review from lforst, Lms24 and AbhiPrasad October 9, 2023 10:18

Lms24 approved these changes Oct 9, 2023

View reviewed changes

krystofwoldrich added 2 commits October 9, 2023 14:57

Merge remote-tracking branch 'origin/main' into kw-fix-trace-propagat…

c42f575

…ion-options-deprecated-was-ignored

Add more tests

f28690c

krystofwoldrich merged commit 0ebefdf into main Oct 9, 2023
43 of 44 checks passed

krystofwoldrich deleted the kw-fix-trace-propagation-options-deprecated-was-ignored branch October 9, 2023 13:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(tracing): Use deprecated tracing origins option if set #3331

fix(tracing): Use deprecated tracing origins option if set #3331

krystofwoldrich commented Oct 9, 2023

github-actions bot commented Oct 9, 2023 •

edited

Loading

Baseline results on branch: main

Startup times

App size

Previous results on branch: kw-fix-trace-propagation-options-deprecated-was-ignored

Startup times

App size

github-actions bot commented Oct 9, 2023 •

edited

Loading

Baseline results on branch: main

Startup times

App size

Previous results on branch: kw-fix-trace-propagation-options-deprecated-was-ignored

Startup times

App size

github-actions bot commented Oct 9, 2023 •

edited

Loading

Baseline results on branch: main

Startup times

App size

Previous results on branch: kw-fix-trace-propagation-options-deprecated-was-ignored

Startup times

App size

github-actions bot commented Oct 9, 2023

Baseline results on branch: main

Startup times

App size

Lms24 left a comment

Lms24 Oct 9, 2023

fix(tracing): Use deprecated tracing origins option if set #3331

fix(tracing): Use deprecated tracing origins option if set #3331

Conversation

krystofwoldrich commented Oct 9, 2023

📢 Type of change

📜 Description

💚 How did you test it?

📝 Checklist

🔮 Next steps

github-actions bot commented Oct 9, 2023 • edited Loading

Android (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: kw-fix-trace-propagation-options-deprecated-was-ignored

Startup times

App size

github-actions bot commented Oct 9, 2023 • edited Loading

iOS (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: kw-fix-trace-propagation-options-deprecated-was-ignored

Startup times

App size

github-actions bot commented Oct 9, 2023 • edited Loading

iOS (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: kw-fix-trace-propagation-options-deprecated-was-ignored

Startup times

App size

github-actions bot commented Oct 9, 2023

Android (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Lms24 left a comment

Choose a reason for hiding this comment

Lms24 Oct 9, 2023

Choose a reason for hiding this comment

github-actions bot commented Oct 9, 2023 •

edited

Loading

github-actions bot commented Oct 9, 2023 •

edited

Loading

github-actions bot commented Oct 9, 2023 •

edited

Loading