Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update CLI to v2.21.2 #3301

Merged
merged 1 commit into from
Oct 4, 2023
Merged

chore(deps): update CLI to v2.21.2 #3301

merged 1 commit into from
Oct 4, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 22, 2023 •
edited
Loading

Bumps scripts/update-cli.sh from 2.20.7 to 2.21.2.

Auto-generated by a dependency updater.

Changelog

2.21.2

Various fixes & improvements

  • fix(rn): Remove hermesc envs if hermes is disabled (#1754) by krystofwoldrich
  • fix: Don't fail on duplicate proguard release association (#1762) by loewenheim
  • fix: Make URL in org auth tokens optional (#1766) by loewenheim
  • Explain how to update in the README (#1767) by philipphofmann

2.21.1

Various fixes & improvements

  • fix: Strip /api/0 prefix from endpoint URLs (#1752) by loewenheim

2.21.0

Various fixes and improvements

  • feat: login now opens the org auth token creation page (#1737) by loewenheim
  • feat: Debug IDs are now supported in Hermes bundles (#1667) by krystofwoldrich
  • feat: The root sourcemap for RAM bundles is now uploaded, improving support for preloaded modules (#1743) by krystofwoldrich
  • feat: Commands with a --wait flag now also have a --wait-for <SECS> option that additionally puts a limit on the wait time. (#1748) by loewenheim
  • deps: symbolic updated to 12.4.1 (#1749) by loewenheim

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Sep 22, 2023
@github-actions
Copy link
Contributor Author

github-actions bot commented Sep 22, 2023 •
edited
Loading

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 366.23 ms 393.37 ms 27.13 ms
Size 17.73 MiB 19.84 MiB 2.10 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e5c9b8b 409.02 ms 426.66 ms 17.64 ms
86d6d2c+dirty 332.90 ms 352.45 ms 19.55 ms
9c48b2c 349.24 ms 385.96 ms 36.72 ms
8900e1a+dirty 430.68 ms 456.13 ms 25.44 ms
e73f4ed+dirty 332.96 ms 354.33 ms 21.37 ms
76d1baf+dirty 335.72 ms 355.52 ms 19.80 ms
3ffcddd 302.92 ms 315.80 ms 12.88 ms
9a3ca65+dirty 326.93 ms 330.14 ms 3.21 ms
70caa60+dirty 299.00 ms 321.02 ms 22.02 ms
52a8031+dirty 311.55 ms 321.37 ms 9.82 ms

App size

Revision Plain With Sentry Diff
e5c9b8b 17.73 MiB 19.83 MiB 2.10 MiB
86d6d2c+dirty 17.73 MiB 20.04 MiB 2.31 MiB
9c48b2c 17.73 MiB 19.80 MiB 2.07 MiB
8900e1a+dirty 17.73 MiB 19.75 MiB 2.01 MiB
e73f4ed+dirty 17.73 MiB 20.04 MiB 2.31 MiB
76d1baf+dirty 17.73 MiB 20.04 MiB 2.31 MiB
3ffcddd 17.73 MiB 19.75 MiB 2.02 MiB
9a3ca65+dirty 17.73 MiB 20.04 MiB 2.31 MiB
70caa60+dirty 17.73 MiB 19.75 MiB 2.01 MiB
52a8031+dirty 17.73 MiB 20.04 MiB 2.31 MiB

Previous results on branch: deps/scripts/update-cli.sh

Startup times

Revision Plain With Sentry Diff
49dc79a 314.65 ms 326.36 ms 11.71 ms
b5d860e+dirty 346.87 ms 391.02 ms 44.15 ms
c9a9e60 340.32 ms 353.98 ms 13.66 ms
563dbcd 383.08 ms 386.57 ms 3.49 ms
7bf2a82 320.73 ms 330.15 ms 9.42 ms
81747a7+dirty 338.02 ms 360.96 ms 22.94 ms
7297826+dirty 324.73 ms 352.69 ms 27.96 ms
d53a041 337.20 ms 358.47 ms 21.27 ms

App size

Revision Plain With Sentry Diff
49dc79a 17.73 MiB 19.80 MiB 2.07 MiB
b5d860e+dirty 17.73 MiB 20.04 MiB 2.31 MiB
c9a9e60 17.73 MiB 19.80 MiB 2.07 MiB
563dbcd 17.73 MiB 19.75 MiB 2.02 MiB
7bf2a82 17.73 MiB 19.81 MiB 2.07 MiB
81747a7+dirty 17.73 MiB 20.05 MiB 2.32 MiB
7297826+dirty 17.73 MiB 19.75 MiB 2.02 MiB
d53a041 17.73 MiB 19.83 MiB 2.10 MiB

@github-actions
Copy link
Contributor Author

github-actions bot commented Sep 22, 2023 •
edited
Loading

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1232.46 ms 1239.52 ms 7.06 ms
Size 2.36 MiB 2.87 MiB 520.64 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d197b5c+dirty 1217.61 ms 1242.66 ms 25.05 ms
15c80ab+dirty 1223.74 ms 1228.96 ms 5.22 ms
0db0c72+dirty 1275.02 ms 1285.84 ms 10.82 ms
d0bf494+dirty 1289.40 ms 1298.40 ms 9.00 ms
52a8031+dirty 1280.88 ms 1289.78 ms 8.90 ms
70caa60+dirty 1218.27 ms 1230.30 ms 12.03 ms
e5c9b8b+dirty 1258.57 ms 1267.32 ms 8.75 ms
b1e8712+dirty 1256.02 ms 1265.14 ms 9.12 ms
acadc0f+dirty 1264.38 ms 1290.06 ms 25.68 ms
0677344+dirty 1276.70 ms 1300.07 ms 23.37 ms

App size

Revision Plain With Sentry Diff
d197b5c+dirty 2.36 MiB 2.82 MiB 462.86 KiB
15c80ab+dirty 2.36 MiB 2.83 MiB 474.49 KiB
0db0c72+dirty 2.36 MiB 2.84 MiB 487.01 KiB
d0bf494+dirty 2.36 MiB 2.83 MiB 481.15 KiB
52a8031+dirty 2.36 MiB 2.82 MiB 469.44 KiB
70caa60+dirty 2.36 MiB 2.83 MiB 479.27 KiB
e5c9b8b+dirty 2.36 MiB 2.87 MiB 520.43 KiB
b1e8712+dirty 2.36 MiB 2.84 MiB 488.84 KiB
acadc0f+dirty 2.36 MiB 2.83 MiB 480.37 KiB
0677344+dirty 2.36 MiB 2.85 MiB 496.81 KiB

Previous results on branch: deps/scripts/update-cli.sh

Startup times

Revision Plain With Sentry Diff
49dc79a+dirty 1263.92 ms 1275.28 ms 11.36 ms
d53a041+dirty 1264.92 ms 1272.28 ms 7.36 ms
b5d860e+dirty 1262.92 ms 1276.10 ms 13.18 ms
7bf2a82+dirty 1261.53 ms 1270.22 ms 8.69 ms
563dbcd+dirty 1276.28 ms 1290.15 ms 13.87 ms
81747a7+dirty 1226.60 ms 1246.62 ms 20.02 ms
c9a9e60+dirty 1271.12 ms 1279.68 ms 8.56 ms
7297826+dirty 1244.12 ms 1276.61 ms 32.49 ms

App size

Revision Plain With Sentry Diff
49dc79a+dirty 2.36 MiB 2.85 MiB 495.31 KiB
d53a041+dirty 2.36 MiB 2.87 MiB 518.81 KiB
b5d860e+dirty 2.36 MiB 2.82 MiB 469.15 KiB
7bf2a82+dirty 2.36 MiB 2.85 MiB 496.85 KiB
563dbcd+dirty 2.36 MiB 2.84 MiB 488.84 KiB
81747a7+dirty 2.36 MiB 2.83 MiB 478.50 KiB
c9a9e60+dirty 2.36 MiB 2.85 MiB 495.34 KiB
7297826+dirty 2.36 MiB 2.83 MiB 481.14 KiB

@github-actions
Copy link
Contributor Author

github-actions bot commented Sep 22, 2023 •
edited
Loading

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 345.87 ms 360.68 ms 14.81 ms
Size 7.15 MiB 8.10 MiB 981.29 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d197b5c+dirty 258.75 ms 313.61 ms 54.86 ms
15c80ab+dirty 276.38 ms 327.54 ms 51.17 ms
0db0c72+dirty 335.20 ms 351.06 ms 15.86 ms
d0bf494+dirty 253.73 ms 308.23 ms 54.49 ms
52a8031+dirty 330.72 ms 358.76 ms 28.03 ms
70caa60+dirty 308.83 ms 393.06 ms 84.23 ms
e5c9b8b+dirty 335.40 ms 360.06 ms 24.67 ms
b1e8712+dirty 322.55 ms 331.84 ms 9.29 ms
acadc0f+dirty 259.04 ms 304.67 ms 45.63 ms
0677344+dirty 288.40 ms 391.44 ms 103.04 ms

App size

Revision Plain With Sentry Diff
d197b5c+dirty 7.15 MiB 8.09 MiB 962.72 KiB
15c80ab+dirty 7.15 MiB 8.09 MiB 966.13 KiB
0db0c72+dirty 7.15 MiB 8.04 MiB 911.02 KiB
d0bf494+dirty 7.15 MiB 8.04 MiB 910.85 KiB
52a8031+dirty 7.15 MiB 8.09 MiB 965.95 KiB
70caa60+dirty 7.15 MiB 8.03 MiB 901.79 KiB
e5c9b8b+dirty 7.15 MiB 8.10 MiB 980.41 KiB
b1e8712+dirty 7.15 MiB 8.04 MiB 912.27 KiB
acadc0f+dirty 7.15 MiB 8.03 MiB 903.20 KiB
0677344+dirty 7.15 MiB 8.07 MiB 949.80 KiB

Previous results on branch: deps/scripts/update-cli.sh

Startup times

Revision Plain With Sentry Diff
49dc79a+dirty 267.29 ms 318.94 ms 51.65 ms
d53a041+dirty 280.71 ms 337.12 ms 56.41 ms
b5d860e+dirty 300.50 ms 327.07 ms 26.57 ms
7bf2a82+dirty 268.90 ms 311.79 ms 42.89 ms
563dbcd+dirty 299.66 ms 333.24 ms 33.58 ms
81747a7+dirty 327.18 ms 339.42 ms 12.24 ms
c9a9e60+dirty 373.73 ms 381.29 ms 7.55 ms
7297826+dirty 341.22 ms 352.34 ms 11.12 ms

App size

Revision Plain With Sentry Diff
49dc79a+dirty 7.15 MiB 8.07 MiB 946.13 KiB
d53a041+dirty 7.15 MiB 8.10 MiB 975.99 KiB
b5d860e+dirty 7.15 MiB 8.09 MiB 963.80 KiB
7bf2a82+dirty 7.15 MiB 8.07 MiB 949.80 KiB
563dbcd+dirty 7.15 MiB 8.04 MiB 912.27 KiB
81747a7+dirty 7.15 MiB 8.10 MiB 973.55 KiB
c9a9e60+dirty 7.15 MiB 8.07 MiB 946.13 KiB
7297826+dirty 7.15 MiB 8.04 MiB 910.85 KiB

krystofwoldrich
krystofwoldrich requested changes Sep 22, 2023
View reviewed changes
Copy link
Member

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build RN 0.65.3 legacy ios production fails, hermesc is beiing execute but the app uses JSC, fails on missing hermesc executable and then on missing bundle file caused by the prev error.

@github-actions github-actions bot changed the title chore(deps): update CLI to v2.21.0 chore(deps): update CLI to v2.21.1 Sep 23, 2023
@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-cli.sh branch 4 times, most recently from 119ed20 to 36e7ba7 Compare September 29, 2023 07:42
@github-actions
Copy link
Contributor Author

github-actions bot commented Sep 29, 2023 •
edited
Loading

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1287.42 ms 1293.59 ms 6.17 ms
Size 2.92 MiB 3.43 MiB 524.71 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d197b5c+dirty 1234.80 ms 1249.20 ms 14.40 ms
15c80ab+dirty 1248.41 ms 1251.24 ms 2.83 ms
0db0c72+dirty 1258.88 ms 1262.52 ms 3.64 ms
d0bf494+dirty 1266.20 ms 1267.52 ms 1.32 ms
52a8031+dirty 1255.96 ms 1273.00 ms 17.04 ms
70caa60+dirty 1279.08 ms 1281.54 ms 2.46 ms
e5c9b8b+dirty 1276.90 ms 1280.92 ms 4.02 ms
b1e8712+dirty 1284.11 ms 1297.82 ms 13.71 ms
acadc0f+dirty 1271.12 ms 1272.28 ms 1.16 ms
0677344+dirty 1252.52 ms 1254.08 ms 1.56 ms

App size

Revision Plain With Sentry Diff
d197b5c+dirty 2.92 MiB 3.37 MiB 464.41 KiB
15c80ab+dirty 2.92 MiB 3.39 MiB 481.56 KiB
0db0c72+dirty 2.92 MiB 3.40 MiB 492.71 KiB
d0bf494+dirty 2.92 MiB 3.40 MiB 488.08 KiB
52a8031+dirty 2.92 MiB 3.38 MiB 475.71 KiB
70caa60+dirty 2.92 MiB 3.39 MiB 486.04 KiB
e5c9b8b+dirty 2.92 MiB 3.43 MiB 524.50 KiB
b1e8712+dirty 2.92 MiB 3.40 MiB 494.15 KiB
acadc0f+dirty 2.92 MiB 3.39 MiB 487.34 KiB
0677344+dirty 2.92 MiB 3.41 MiB 500.94 KiB

Previous results on branch: deps/scripts/update-cli.sh

Startup times

Revision Plain With Sentry Diff
49dc79a+dirty 1269.10 ms 1273.92 ms 4.82 ms
d53a041+dirty 1228.78 ms 1229.58 ms 0.80 ms
b5d860e+dirty 1262.49 ms 1282.84 ms 20.35 ms
7bf2a82+dirty 1287.16 ms 1292.26 ms 5.10 ms
563dbcd+dirty 1248.98 ms 1267.08 ms 18.10 ms
81747a7+dirty 1227.10 ms 1243.40 ms 16.30 ms
c9a9e60+dirty 1276.65 ms 1288.74 ms 12.09 ms
7297826+dirty 1235.14 ms 1244.18 ms 9.04 ms

App size

Revision Plain With Sentry Diff
49dc79a+dirty 2.92 MiB 3.41 MiB 499.49 KiB
d53a041+dirty 2.92 MiB 3.43 MiB 522.92 KiB
b5d860e+dirty 2.92 MiB 3.38 MiB 475.38 KiB
7bf2a82+dirty 2.92 MiB 3.41 MiB 501.01 KiB
563dbcd+dirty 2.92 MiB 3.40 MiB 494.10 KiB
81747a7+dirty 2.92 MiB 3.39 MiB 485.59 KiB
c9a9e60+dirty 2.92 MiB 3.41 MiB 499.05 KiB
7297826+dirty 2.92 MiB 3.40 MiB 488.13 KiB

@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-cli.sh branch 2 times, most recently from 51a33ce to 5d420f3 Compare October 3, 2023 12:05
@github-actions github-actions bot changed the title chore(deps): update CLI to v2.21.1 chore(deps): update CLI to v2.21.2 Oct 4, 2023
krystofwoldrich
krystofwoldrich approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@krystofwoldrich krystofwoldrich merged commit 457e29f into main Oct 4, 2023
46 of 50 checks passed
@krystofwoldrich krystofwoldrich deleted the deps/scripts/update-cli.sh branch October 4, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krystofwoldrich krystofwoldrich krystofwoldrich approved these changes

@lucas-zimerman lucas-zimerman Awaiting requested review from lucas-zimerman lucas-zimerman is a code owner

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krystofwoldrich @web-flow