Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(profiling): Create profiles for start up transactions #3281

Merged
merged 4 commits into from
Sep 15, 2023

Conversation

krystofwoldrich
Copy link
Member

📢 Type of change

  • Bugfix

📜 Description

💡 Motivation and Context

Currently start-up transactions don't have profiles attached.

💚 How did you test it?

sample app, ci

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

🔮 Next steps

@krystofwoldrich krystofwoldrich self-assigned this Sep 14, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2023

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 336.41 ms 353.35 ms 16.94 ms
Size 17.73 MiB 19.83 MiB 2.10 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e2b64fe 316.88 ms 330.23 ms 13.35 ms
86d6d2c+dirty 332.90 ms 352.45 ms 19.55 ms
d7401ac+dirty 375.20 ms 383.51 ms 8.31 ms
76d1baf+dirty 335.72 ms 355.52 ms 19.80 ms
dadc233+dirty 333.78 ms 343.94 ms 10.16 ms
3853f43 329.68 ms 346.32 ms 16.64 ms
3ffcddd 302.92 ms 315.80 ms 12.88 ms
e73f4ed+dirty 332.96 ms 354.33 ms 21.37 ms
0db0c72 372.12 ms 386.00 ms 13.88 ms
8900e1a+dirty 430.68 ms 456.13 ms 25.44 ms

App size

Revision Plain With Sentry Diff
e2b64fe 17.73 MiB 19.80 MiB 2.07 MiB
86d6d2c+dirty 17.73 MiB 20.04 MiB 2.31 MiB
d7401ac+dirty 17.73 MiB 19.75 MiB 2.02 MiB
76d1baf+dirty 17.73 MiB 20.04 MiB 2.31 MiB
dadc233+dirty 17.73 MiB 19.75 MiB 2.02 MiB
3853f43 17.73 MiB 19.81 MiB 2.08 MiB
3ffcddd 17.73 MiB 19.75 MiB 2.02 MiB
e73f4ed+dirty 17.73 MiB 20.04 MiB 2.31 MiB
0db0c72 17.73 MiB 19.75 MiB 2.02 MiB
8900e1a+dirty 17.73 MiB 19.75 MiB 2.01 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2023

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1253.15 ms 1256.28 ms 3.13 ms
Size 2.36 MiB 2.87 MiB 520.42 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
86d6d2c+dirty 1267.55 ms 1286.21 ms 18.66 ms
d7401ac+dirty 1252.38 ms 1275.04 ms 22.66 ms
76d1baf+dirty 1244.10 ms 1268.52 ms 24.42 ms
e2b64fe+dirty 1232.22 ms 1255.20 ms 22.98 ms
ad6c299+dirty 1244.76 ms 1260.10 ms 15.34 ms
dadc233+dirty 1223.20 ms 1236.88 ms 13.68 ms
27ef4ee+dirty 1293.52 ms 1296.08 ms 2.56 ms
3853f43+dirty 1221.82 ms 1242.64 ms 20.82 ms
9c48b2c+dirty 1246.96 ms 1255.73 ms 8.77 ms
e73f4ed+dirty 1243.27 ms 1244.52 ms 1.25 ms

App size

Revision Plain With Sentry Diff
86d6d2c+dirty 2.36 MiB 2.82 MiB 462.82 KiB
d7401ac+dirty 2.36 MiB 2.83 MiB 481.14 KiB
76d1baf+dirty 2.36 MiB 2.82 MiB 469.45 KiB
e2b64fe+dirty 2.36 MiB 2.85 MiB 495.80 KiB
ad6c299+dirty 2.36 MiB 2.84 MiB 488.85 KiB
dadc233+dirty 2.36 MiB 2.84 MiB 486.85 KiB
27ef4ee+dirty 2.36 MiB 2.85 MiB 500.03 KiB
3853f43+dirty 2.36 MiB 2.85 MiB 499.81 KiB
9c48b2c+dirty 2.36 MiB 2.85 MiB 495.77 KiB
e73f4ed+dirty 2.36 MiB 2.82 MiB 469.44 KiB

@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2023

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 374.90 ms 405.62 ms 30.72 ms
Size 7.15 MiB 8.10 MiB 980.38 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
86d6d2c+dirty 267.21 ms 325.24 ms 58.04 ms
d7401ac+dirty 373.98 ms 394.08 ms 20.10 ms
76d1baf+dirty 339.02 ms 408.65 ms 69.63 ms
e2b64fe+dirty 258.82 ms 304.26 ms 45.44 ms
ad6c299+dirty 336.47 ms 362.89 ms 26.42 ms
dadc233+dirty 363.19 ms 370.37 ms 7.18 ms
27ef4ee+dirty 296.71 ms 351.00 ms 54.29 ms
3853f43+dirty 278.12 ms 338.72 ms 60.60 ms
9c48b2c+dirty 270.82 ms 321.12 ms 50.30 ms
e73f4ed+dirty 262.98 ms 311.02 ms 48.04 ms

App size

Revision Plain With Sentry Diff
86d6d2c+dirty 7.15 MiB 8.09 MiB 962.69 KiB
d7401ac+dirty 7.15 MiB 8.04 MiB 910.85 KiB
76d1baf+dirty 7.15 MiB 8.09 MiB 964.41 KiB
e2b64fe+dirty 7.15 MiB 8.07 MiB 947.16 KiB
ad6c299+dirty 7.15 MiB 8.04 MiB 912.17 KiB
dadc233+dirty 7.15 MiB 8.04 MiB 910.84 KiB
27ef4ee+dirty 7.15 MiB 8.08 MiB 959.49 KiB
3853f43+dirty 7.15 MiB 8.08 MiB 959.34 KiB
9c48b2c+dirty 7.15 MiB 8.07 MiB 947.16 KiB
e73f4ed+dirty 7.15 MiB 8.09 MiB 965.94 KiB

@krystofwoldrich krystofwoldrich marked this pull request as ready for review September 14, 2023 14:25
@krystofwoldrich krystofwoldrich changed the title fix(profiling): Create profile for start up transactions fix(profiling): Create profiles for start up transactions Sep 14, 2023
@krystofwoldrich krystofwoldrich merged commit 4cc74aa into main Sep 15, 2023
@krystofwoldrich krystofwoldrich deleted the kw-fix-profiling-start-up branch September 15, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants