Fix bug preventing native SDK from being called after reinitialization #3200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses a bug in the Sentry React Native integration that occurs when calling `Sentry.init({ enableNative: true })`, followed by `Sentry.close()`, and then re-calling `Sentry.init({ enableNative: true })`. The bug prevents the native SDK from being invoked after the reinitialization.
The issue resides in the closeNativeSdk() method, where the enableNative flag is incorrectly used to determine whether the native SDK should be closed. This flag is not being updated correctly after reinitialization, causing the SDK to remain disabled.
With this change, the nativeIsReady flag is used to determine whether the native SDK should be closed, ensuring that subsequent reinitialization correctly enables the native SDK functionality.
This fix ensures that the native SDK will be called as expected after reinitializing with enableNative: true, resolving the issue where the SDK was not invoked due to the bug in the closeNativeSdk() method.
mateioprea
requested review from
marandaneto,
krystofwoldrich and
lucas-zimerman
as code owners
|
Hi, I believe the fix should be in the The |
|
Fair enough! I will change it there |
|
@krystofwoldrich done! |
|
@mateioprea Looks good, I'm thinking about some tests to prevent this in the future, but nothing comes to mind. Can you update the changelog? |
mateioprea
force-pushed
the
mateioprea-patch-2
branch
from
b8199ef to
073ded8
Compare
|
@krystofwoldrich done. I had my previous PR opened and I made a mistake in the CHANGELOG file, but i fixed it. I cannot think of any test cases for now as well. Thank you! |
|
@krystofwoldrich any news here? :D |
krystofwoldrich
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
This commit addresses a bug in the Sentry React Native integration that occurs when calling
Sentry.init({ enableNative: true }), followed bySentry.close(), and then re-callingSentry.init({ enableNative: true }). The bug prevents the native SDK from being invoked after the reinitialization.The issue resides in the
closeNativeSdk()method, where theenableNativeflag is incorrectly used to determine whether the native SDK should be closed. This flag is not being updated correctly after reinitialization, causing the SDK to remain disabled.With this change, the
nativeIsReadyflag is used to determine whether the native SDK should be closed, ensuring that subsequent reinitialization correctly enables the native SDK functionality.This fix ensures that the native SDK will be called as expected after reinitializing with enableNative: true, resolving the issue where the SDK was not invoked due to the bug in the
closeNativeSdk()method.💡 Motivation and Context
💚 How did you test it?
In my App.
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps