-
-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update Cocoa SDK to v8.8.0 #3123
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
marandaneto,
krystofwoldrich and
lucas-zimerman
as code owners
June 14, 2023 12:02
github-actions
bot
added
the
dependencies
Pull requests that update a dependency file
label
Jun 14, 2023
bruno-garcia
force-pushed
the
deps/scripts/update-cocoa.sh
branch
from
June 14, 2023 12:03
5785d34
to
be263a6
Compare
Android (legacy) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
b1e8712 | 462.11 ms | 465.71 ms | 3.60 ms |
acadc0f+dirty | 373.24 ms | 381.51 ms | 8.27 ms |
ad6c299 | 375.94 ms | 382.02 ms | 6.08 ms |
34aba08 | 328.10 ms | 342.84 ms | 14.74 ms |
80b2ce3 | 385.02 ms | 387.36 ms | 2.34 ms |
dadc233+dirty | 333.78 ms | 343.94 ms | 10.16 ms |
d197b5c+dirty | 338.94 ms | 354.87 ms | 15.93 ms |
15c80ab+dirty | 336.27 ms | 350.58 ms | 14.31 ms |
70caa60+dirty | 299.00 ms | 321.02 ms | 22.02 ms |
52a8031+dirty | 311.55 ms | 321.37 ms | 9.82 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
b1e8712 | 17.73 MiB | 19.75 MiB | 2.02 MiB |
acadc0f+dirty | 17.73 MiB | 19.75 MiB | 2.01 MiB |
ad6c299 | 17.73 MiB | 19.75 MiB | 2.02 MiB |
34aba08 | 17.73 MiB | 19.80 MiB | 2.07 MiB |
80b2ce3 | 17.73 MiB | 19.75 MiB | 2.02 MiB |
dadc233+dirty | 17.73 MiB | 19.75 MiB | 2.02 MiB |
d197b5c+dirty | 17.73 MiB | 20.04 MiB | 2.31 MiB |
15c80ab+dirty | 17.73 MiB | 20.04 MiB | 2.31 MiB |
70caa60+dirty | 17.73 MiB | 19.75 MiB | 2.01 MiB |
52a8031+dirty | 17.73 MiB | 20.04 MiB | 2.31 MiB |
Previous results on branch: deps/scripts/update-cocoa.sh
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
94f9b87+dirty | 319.37 ms | 330.10 ms | 10.73 ms |
9af52f2 | 364.43 ms | 379.30 ms | 14.87 ms |
955f10d | 351.88 ms | 364.50 ms | 12.62 ms |
8da52c9+dirty | 385.21 ms | 422.36 ms | 37.15 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
94f9b87+dirty | 17.73 MiB | 19.75 MiB | 2.01 MiB |
9af52f2 | 17.73 MiB | 19.80 MiB | 2.07 MiB |
955f10d | 17.73 MiB | 19.80 MiB | 2.07 MiB |
8da52c9+dirty | 17.73 MiB | 20.04 MiB | 2.31 MiB |
iOS (legacy) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
70caa60+dirty | 1218.27 ms | 1230.30 ms | 12.03 ms |
9a3ca65+dirty | 1247.06 ms | 1274.58 ms | 27.52 ms |
e2b64fe+dirty | 1232.22 ms | 1255.20 ms | 22.98 ms |
d197b5c+dirty | 1217.61 ms | 1242.66 ms | 25.05 ms |
15c80ab+dirty | 1223.74 ms | 1228.96 ms | 5.22 ms |
0db0c72+dirty | 1275.02 ms | 1285.84 ms | 10.82 ms |
b1e8712+dirty | 1256.02 ms | 1265.14 ms | 9.12 ms |
8900e1a+dirty | 1210.27 ms | 1218.66 ms | 8.39 ms |
76d1baf+dirty | 1244.10 ms | 1268.52 ms | 24.42 ms |
52a8031+dirty | 1280.88 ms | 1289.78 ms | 8.90 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
70caa60+dirty | 2.36 MiB | 2.83 MiB | 479.27 KiB |
9a3ca65+dirty | 2.36 MiB | 2.82 MiB | 462.89 KiB |
e2b64fe+dirty | 2.36 MiB | 2.85 MiB | 495.80 KiB |
d197b5c+dirty | 2.36 MiB | 2.82 MiB | 462.86 KiB |
15c80ab+dirty | 2.36 MiB | 2.83 MiB | 474.49 KiB |
0db0c72+dirty | 2.36 MiB | 2.84 MiB | 487.01 KiB |
b1e8712+dirty | 2.36 MiB | 2.84 MiB | 488.84 KiB |
8900e1a+dirty | 2.36 MiB | 2.83 MiB | 479.25 KiB |
76d1baf+dirty | 2.36 MiB | 2.82 MiB | 469.45 KiB |
52a8031+dirty | 2.36 MiB | 2.82 MiB | 469.44 KiB |
Previous results on branch: deps/scripts/update-cocoa.sh
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
94f9b87+dirty | 1260.32 ms | 1283.72 ms | 23.40 ms |
955f10d+dirty | 1270.66 ms | 1278.60 ms | 7.94 ms |
9af52f2+dirty | 1273.67 ms | 1286.72 ms | 13.05 ms |
8da52c9+dirty | 1214.59 ms | 1224.90 ms | 10.31 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
94f9b87+dirty | 2.36 MiB | 2.83 MiB | 479.26 KiB |
955f10d+dirty | 2.36 MiB | 2.85 MiB | 496.13 KiB |
9af52f2+dirty | 2.36 MiB | 2.85 MiB | 497.02 KiB |
8da52c9+dirty | 2.36 MiB | 2.82 MiB | 468.48 KiB |
iOS (new) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
70caa60+dirty | 1279.08 ms | 1281.54 ms | 2.46 ms |
9a3ca65+dirty | 1276.40 ms | 1279.14 ms | 2.74 ms |
e2b64fe+dirty | 1285.78 ms | 1297.56 ms | 11.78 ms |
d197b5c+dirty | 1234.80 ms | 1249.20 ms | 14.40 ms |
15c80ab+dirty | 1248.41 ms | 1251.24 ms | 2.83 ms |
0db0c72+dirty | 1258.88 ms | 1262.52 ms | 3.64 ms |
b1e8712+dirty | 1284.11 ms | 1297.82 ms | 13.71 ms |
8900e1a+dirty | 1268.36 ms | 1273.04 ms | 4.68 ms |
76d1baf+dirty | 1245.00 ms | 1257.76 ms | 12.76 ms |
52a8031+dirty | 1255.96 ms | 1273.00 ms | 17.04 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
70caa60+dirty | 2.92 MiB | 3.39 MiB | 486.04 KiB |
9a3ca65+dirty | 2.92 MiB | 3.37 MiB | 464.32 KiB |
e2b64fe+dirty | 2.92 MiB | 3.41 MiB | 499.97 KiB |
d197b5c+dirty | 2.92 MiB | 3.37 MiB | 464.41 KiB |
15c80ab+dirty | 2.92 MiB | 3.39 MiB | 481.56 KiB |
0db0c72+dirty | 2.92 MiB | 3.40 MiB | 492.71 KiB |
b1e8712+dirty | 2.92 MiB | 3.40 MiB | 494.15 KiB |
8900e1a+dirty | 2.92 MiB | 3.39 MiB | 485.96 KiB |
76d1baf+dirty | 2.92 MiB | 3.38 MiB | 475.74 KiB |
52a8031+dirty | 2.92 MiB | 3.38 MiB | 475.71 KiB |
Previous results on branch: deps/scripts/update-cocoa.sh
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
94f9b87+dirty | 1269.94 ms | 1273.11 ms | 3.17 ms |
955f10d+dirty | 1293.94 ms | 1298.86 ms | 4.92 ms |
9af52f2+dirty | 1256.52 ms | 1258.94 ms | 2.42 ms |
8da52c9+dirty | 1263.68 ms | 1273.90 ms | 10.22 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
94f9b87+dirty | 2.92 MiB | 3.39 MiB | 485.98 KiB |
955f10d+dirty | 2.92 MiB | 3.41 MiB | 499.55 KiB |
9af52f2+dirty | 2.92 MiB | 3.41 MiB | 500.73 KiB |
8da52c9+dirty | 2.92 MiB | 3.38 MiB | 474.71 KiB |
github-actions
bot
changed the title
chore(deps): update Cocoa SDK to v8.7.4
chore(deps): update Cocoa SDK to v8.8.0
Jun 16, 2023
bruno-garcia
force-pushed
the
deps/scripts/update-cocoa.sh
branch
from
June 16, 2023 03:03
be263a6
to
1fa603a
Compare
Android (new) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
70caa60+dirty | 308.83 ms | 393.06 ms | 84.23 ms |
9a3ca65+dirty | 344.96 ms | 358.92 ms | 13.96 ms |
e2b64fe+dirty | 258.82 ms | 304.26 ms | 45.44 ms |
d197b5c+dirty | 258.75 ms | 313.61 ms | 54.86 ms |
15c80ab+dirty | 276.38 ms | 327.54 ms | 51.17 ms |
0db0c72+dirty | 335.20 ms | 351.06 ms | 15.86 ms |
b1e8712+dirty | 322.55 ms | 331.84 ms | 9.29 ms |
8900e1a+dirty | 371.40 ms | 377.70 ms | 6.31 ms |
76d1baf+dirty | 339.02 ms | 408.65 ms | 69.63 ms |
52a8031+dirty | 330.72 ms | 358.76 ms | 28.03 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
70caa60+dirty | 7.15 MiB | 8.03 MiB | 901.79 KiB |
9a3ca65+dirty | 7.15 MiB | 8.09 MiB | 962.83 KiB |
e2b64fe+dirty | 7.15 MiB | 8.07 MiB | 947.16 KiB |
d197b5c+dirty | 7.15 MiB | 8.09 MiB | 962.72 KiB |
15c80ab+dirty | 7.15 MiB | 8.09 MiB | 966.13 KiB |
0db0c72+dirty | 7.15 MiB | 8.04 MiB | 911.02 KiB |
b1e8712+dirty | 7.15 MiB | 8.04 MiB | 912.27 KiB |
8900e1a+dirty | 7.15 MiB | 8.03 MiB | 901.79 KiB |
76d1baf+dirty | 7.15 MiB | 8.09 MiB | 964.41 KiB |
52a8031+dirty | 7.15 MiB | 8.09 MiB | 965.95 KiB |
Previous results on branch: deps/scripts/update-cocoa.sh
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
94f9b87+dirty | 300.47 ms | 353.74 ms | 53.27 ms |
955f10d+dirty | 306.27 ms | 385.83 ms | 79.57 ms |
9af52f2+dirty | 272.87 ms | 305.61 ms | 32.74 ms |
8da52c9+dirty | 269.29 ms | 290.76 ms | 21.47 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
94f9b87+dirty | 7.15 MiB | 8.03 MiB | 901.79 KiB |
955f10d+dirty | 7.15 MiB | 8.07 MiB | 946.13 KiB |
9af52f2+dirty | 7.15 MiB | 8.07 MiB | 947.16 KiB |
8da52c9+dirty | 7.15 MiB | 8.09 MiB | 962.83 KiB |
bruno-garcia
force-pushed
the
deps/scripts/update-cocoa.sh
branch
4 times, most recently
from
June 26, 2023 09:54
46937c7
to
eec3e12
Compare
bruno-garcia
force-pushed
the
deps/scripts/update-cocoa.sh
branch
2 times, most recently
from
June 27, 2023 13:06
15fa492
to
b20a767
Compare
bruno-garcia
force-pushed
the
deps/scripts/update-cocoa.sh
branch
from
June 27, 2023 13:18
b20a767
to
1092442
Compare
krystofwoldrich
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps scripts/update-cocoa.sh from 8.7.3 to 8.8.0.
Auto-generated by a dependency updater.
Changelog
8.8.0
Features
Fixes
SentryId.empty
(#3072)--no-use-binaries
option (#3071)sprintf
call tosnprintf
(#3077)8.7.4
Fixes
Trace
serialized value ofsampled
from string to boolean (#3067)Breaking Changes
nameForSentrySampleDecision
which shouldn't have been public (#3067)