Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): Don't pass enableTracing from RN to sentry-cocoa options #3042

Merged
merged 10 commits into from
May 5, 2023

Conversation

krystofwoldrich
Copy link
Member

📢 Type of change

  • Bugfix
  • Refactoring

📜 Description

Performance should be disabled on the native SDK to avoid duplicated and unuseful information for RN users.

💚 How did you test it?

sample app

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1234.92 ms 1237.64 ms 2.72 ms
Size 2.36 MiB 2.85 MiB 495.23 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
76d1baf+dirty 1244.10 ms 1268.52 ms 24.42 ms
15c80ab+dirty 1223.74 ms 1228.96 ms 5.22 ms
d197b5c+dirty 1217.61 ms 1242.66 ms 25.05 ms
86d6d2c+dirty 1267.55 ms 1286.21 ms 18.66 ms
acadc0f+dirty 1264.38 ms 1290.06 ms 25.68 ms
52a8031+dirty 1280.88 ms 1289.78 ms 8.90 ms
70caa60+dirty 1218.27 ms 1230.30 ms 12.03 ms
d0bf494+dirty 1289.40 ms 1298.40 ms 9.00 ms
d7401ac+dirty 1252.38 ms 1275.04 ms 22.66 ms
80b2ce3+dirty 1265.92 ms 1268.60 ms 2.69 ms

App size

Revision Plain With Sentry Diff
76d1baf+dirty 2.36 MiB 2.82 MiB 469.45 KiB
15c80ab+dirty 2.36 MiB 2.83 MiB 474.49 KiB
d197b5c+dirty 2.36 MiB 2.82 MiB 462.86 KiB
86d6d2c+dirty 2.36 MiB 2.82 MiB 462.82 KiB
acadc0f+dirty 2.36 MiB 2.83 MiB 480.37 KiB
52a8031+dirty 2.36 MiB 2.82 MiB 469.44 KiB
70caa60+dirty 2.36 MiB 2.83 MiB 479.27 KiB
d0bf494+dirty 2.36 MiB 2.83 MiB 481.15 KiB
d7401ac+dirty 2.36 MiB 2.83 MiB 481.14 KiB
80b2ce3+dirty 2.36 MiB 2.84 MiB 486.98 KiB

@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 257.43 ms 316.90 ms 59.47 ms
Size 7.15 MiB 8.04 MiB 919.16 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
76d1baf+dirty 339.02 ms 408.65 ms 69.63 ms
15c80ab+dirty 276.38 ms 327.54 ms 51.17 ms
d197b5c+dirty 258.75 ms 313.61 ms 54.86 ms
86d6d2c+dirty 267.21 ms 325.24 ms 58.04 ms
acadc0f+dirty 259.04 ms 304.67 ms 45.63 ms
52a8031+dirty 330.72 ms 358.76 ms 28.03 ms
70caa60+dirty 308.83 ms 393.06 ms 84.23 ms
d0bf494+dirty 253.73 ms 308.23 ms 54.49 ms
d7401ac+dirty 373.98 ms 394.08 ms 20.10 ms
80b2ce3+dirty 271.29 ms 316.47 ms 45.18 ms

App size

Revision Plain With Sentry Diff
76d1baf+dirty 7.15 MiB 8.09 MiB 964.41 KiB
15c80ab+dirty 7.15 MiB 8.09 MiB 966.13 KiB
d197b5c+dirty 7.15 MiB 8.09 MiB 962.72 KiB
86d6d2c+dirty 7.15 MiB 8.09 MiB 962.69 KiB
acadc0f+dirty 7.15 MiB 8.03 MiB 903.20 KiB
52a8031+dirty 7.15 MiB 8.09 MiB 965.95 KiB
70caa60+dirty 7.15 MiB 8.03 MiB 901.79 KiB
d0bf494+dirty 7.15 MiB 8.04 MiB 910.85 KiB
d7401ac+dirty 7.15 MiB 8.04 MiB 910.85 KiB
80b2ce3+dirty 7.15 MiB 8.04 MiB 911.02 KiB

@krystofwoldrich krystofwoldrich changed the title fix(ios): Add origin and environment tags to cocoa events fix(ios): Don't pass enableTracing from RN to sentry-cocoa options May 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2023

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 358.80 ms 402.60 ms 43.80 ms
Size 17.73 MiB 19.76 MiB 2.03 MiB

@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2023

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1230.40 ms 1233.46 ms 3.06 ms
Size 2.92 MiB 3.41 MiB 498.52 KiB

Base automatically changed from kw-fix-origin-environment-tags to main May 5, 2023 16:42
@krystofwoldrich krystofwoldrich merged commit 27d9ece into main May 5, 2023
@krystofwoldrich krystofwoldrich deleted the kw-fix-tracing-enabled branch May 5, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants