Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update Cocoa SDK to v8.4.0 #2954

Merged
merged 1 commit into from
Apr 7, 2023
Merged

chore(deps): update Cocoa SDK to v8.4.0 #2954

merged 1 commit into from
Apr 7, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Apr 4, 2023 •
edited
Loading

Bumps scripts/update-cocoa.sh from 8.3.3 to 8.4.0.

Auto-generated by a dependency updater.

Changelog

8.4.0

Features

  • Time to initial and full display (#2724)
  • Add time-to-initial-display and time-to-full-display measurements to ViewController transactions (#2843)
  • Add name and geo to User (#2710)

Fixes

  • Correctly track and send GPU frame render data in profiles (#2823)
  • Xcode 14.3 compiling issue regarding functions declaration with no prototype (#2852)

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Apr 4, 2023
@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-cocoa.sh branch from a9a0747 to adef3a0 Compare April 4, 2023 03:03
@github-actions
Copy link
Contributor Author

github-actions bot commented Apr 4, 2023 •
edited
Loading

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 341.72 ms 346.10 ms 4.39 ms
Size 17.73 MiB 19.75 MiB 2.02 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
15c80ab+dirty 336.27 ms 350.58 ms 14.31 ms
70caa60+dirty 299.00 ms 321.02 ms 22.02 ms
52a8031+dirty 311.55 ms 321.37 ms 9.82 ms
e73f4ed+dirty 332.96 ms 354.33 ms 21.37 ms
8900e1a+dirty 430.68 ms 456.13 ms 25.44 ms
76d1baf+dirty 335.72 ms 355.52 ms 19.80 ms
d0bf494+dirty 375.37 ms 395.14 ms 19.77 ms
86d6d2c+dirty 332.90 ms 352.45 ms 19.55 ms
d7401ac+dirty 375.20 ms 383.51 ms 8.31 ms
9a3ca65+dirty 326.93 ms 330.14 ms 3.21 ms

App size

Revision Plain With Sentry Diff
15c80ab+dirty 17.73 MiB 20.04 MiB 2.31 MiB
70caa60+dirty 17.73 MiB 19.75 MiB 2.01 MiB
52a8031+dirty 17.73 MiB 20.04 MiB 2.31 MiB
e73f4ed+dirty 17.73 MiB 20.04 MiB 2.31 MiB
8900e1a+dirty 17.73 MiB 19.75 MiB 2.01 MiB
76d1baf+dirty 17.73 MiB 20.04 MiB 2.31 MiB
d0bf494+dirty 17.73 MiB 19.75 MiB 2.02 MiB
86d6d2c+dirty 17.73 MiB 20.04 MiB 2.31 MiB
d7401ac+dirty 17.73 MiB 19.75 MiB 2.02 MiB
9a3ca65+dirty 17.73 MiB 20.04 MiB 2.31 MiB

Previous results on branch: deps/scripts/update-cocoa.sh

Startup times

Revision Plain With Sentry Diff
8da52c9+dirty 385.21 ms 422.36 ms 37.15 ms
94f9b87+dirty 319.37 ms 330.10 ms 10.73 ms

App size

Revision Plain With Sentry Diff
8da52c9+dirty 17.73 MiB 20.04 MiB 2.31 MiB
94f9b87+dirty 17.73 MiB 19.75 MiB 2.01 MiB

@github-actions
Copy link
Contributor Author

github-actions bot commented Apr 4, 2023

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1259.76 ms 1264.82 ms 5.06 ms
Size 2.92 MiB 3.40 MiB 492.51 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d197b5c+dirty 1234.80 ms 1249.20 ms 14.40 ms
acadc0f+dirty 1271.12 ms 1272.28 ms 1.16 ms
70caa60+dirty 1279.08 ms 1281.54 ms 2.46 ms
52a8031+dirty 1255.96 ms 1273.00 ms 17.04 ms
15c80ab+dirty 1248.41 ms 1251.24 ms 2.83 ms
9a3ca65+dirty 1276.40 ms 1279.14 ms 2.74 ms
76d1baf+dirty 1245.00 ms 1257.76 ms 12.76 ms
8900e1a+dirty 1268.36 ms 1273.04 ms 4.68 ms
e73f4ed+dirty 1282.90 ms 1309.30 ms 26.40 ms
86d6d2c+dirty 1291.62 ms 1296.80 ms 5.18 ms

App size

Revision Plain With Sentry Diff
d197b5c+dirty 2.92 MiB 3.37 MiB 464.41 KiB
acadc0f+dirty 2.92 MiB 3.39 MiB 487.34 KiB
70caa60+dirty 2.92 MiB 3.39 MiB 486.04 KiB
52a8031+dirty 2.92 MiB 3.38 MiB 475.71 KiB
15c80ab+dirty 2.92 MiB 3.39 MiB 481.56 KiB
9a3ca65+dirty 2.92 MiB 3.37 MiB 464.32 KiB
76d1baf+dirty 2.92 MiB 3.38 MiB 475.74 KiB
8900e1a+dirty 2.92 MiB 3.39 MiB 485.96 KiB
e73f4ed+dirty 2.92 MiB 3.38 MiB 475.71 KiB
86d6d2c+dirty 2.92 MiB 3.37 MiB 464.31 KiB

Previous results on branch: deps/scripts/update-cocoa.sh

Startup times

Revision Plain With Sentry Diff
8da52c9+dirty 1263.68 ms 1273.90 ms 10.22 ms
94f9b87+dirty 1269.94 ms 1273.11 ms 3.17 ms

App size

Revision Plain With Sentry Diff
8da52c9+dirty 2.92 MiB 3.38 MiB 474.71 KiB
94f9b87+dirty 2.92 MiB 3.39 MiB 485.98 KiB

@github-actions
Copy link
Contributor Author

github-actions bot commented Apr 4, 2023 •
edited
Loading

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 267.43 ms 312.55 ms 45.12 ms
Size 7.15 MiB 8.04 MiB 910.85 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
15c80ab+dirty 276.38 ms 327.54 ms 51.17 ms
70caa60+dirty 308.83 ms 393.06 ms 84.23 ms
52a8031+dirty 330.72 ms 358.76 ms 28.03 ms
e73f4ed+dirty 262.98 ms 311.02 ms 48.04 ms
8900e1a+dirty 371.40 ms 377.70 ms 6.31 ms
76d1baf+dirty 339.02 ms 408.65 ms 69.63 ms
d0bf494+dirty 253.73 ms 308.23 ms 54.49 ms
86d6d2c+dirty 267.21 ms 325.24 ms 58.04 ms
d7401ac+dirty 373.98 ms 394.08 ms 20.10 ms
9a3ca65+dirty 344.96 ms 358.92 ms 13.96 ms

App size

Revision Plain With Sentry Diff
15c80ab+dirty 7.15 MiB 8.09 MiB 966.13 KiB
70caa60+dirty 7.15 MiB 8.03 MiB 901.79 KiB
52a8031+dirty 7.15 MiB 8.09 MiB 965.95 KiB
e73f4ed+dirty 7.15 MiB 8.09 MiB 965.94 KiB
8900e1a+dirty 7.15 MiB 8.03 MiB 901.79 KiB
76d1baf+dirty 7.15 MiB 8.09 MiB 964.41 KiB
d0bf494+dirty 7.15 MiB 8.04 MiB 910.85 KiB
86d6d2c+dirty 7.15 MiB 8.09 MiB 962.69 KiB
d7401ac+dirty 7.15 MiB 8.04 MiB 910.85 KiB
9a3ca65+dirty 7.15 MiB 8.09 MiB 962.83 KiB

Previous results on branch: deps/scripts/update-cocoa.sh

Startup times

Revision Plain With Sentry Diff
8da52c9+dirty 269.29 ms 290.76 ms 21.47 ms
94f9b87+dirty 300.47 ms 353.74 ms 53.27 ms

App size

Revision Plain With Sentry Diff
8da52c9+dirty 7.15 MiB 8.09 MiB 962.83 KiB
94f9b87+dirty 7.15 MiB 8.03 MiB 901.79 KiB

@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-cocoa.sh branch from adef3a0 to 95650ed Compare April 6, 2023 13:01
@github-actions
Copy link
Contributor Author

github-actions bot commented Apr 6, 2023

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1289.78 ms 1301.02 ms 11.24 ms
Size 2.36 MiB 2.84 MiB 486.59 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
acadc0f+dirty 1264.38 ms 1290.06 ms 25.68 ms
15c80ab+dirty 1223.74 ms 1228.96 ms 5.22 ms
70caa60+dirty 1218.27 ms 1230.30 ms 12.03 ms
52a8031+dirty 1280.88 ms 1289.78 ms 8.90 ms
9a3ca65+dirty 1247.06 ms 1274.58 ms 27.52 ms
86d6d2c+dirty 1267.55 ms 1286.21 ms 18.66 ms
d7401ac+dirty 1252.38 ms 1275.04 ms 22.66 ms
e73f4ed+dirty 1243.27 ms 1244.52 ms 1.25 ms
8900e1a+dirty 1210.27 ms 1218.66 ms 8.39 ms
76d1baf+dirty 1244.10 ms 1268.52 ms 24.42 ms

App size

Revision Plain With Sentry Diff
acadc0f+dirty 2.36 MiB 2.83 MiB 480.37 KiB
15c80ab+dirty 2.36 MiB 2.83 MiB 474.49 KiB
70caa60+dirty 2.36 MiB 2.83 MiB 479.27 KiB
52a8031+dirty 2.36 MiB 2.82 MiB 469.44 KiB
9a3ca65+dirty 2.36 MiB 2.82 MiB 462.89 KiB
86d6d2c+dirty 2.36 MiB 2.82 MiB 462.82 KiB
d7401ac+dirty 2.36 MiB 2.83 MiB 481.14 KiB
e73f4ed+dirty 2.36 MiB 2.82 MiB 469.44 KiB
8900e1a+dirty 2.36 MiB 2.83 MiB 479.25 KiB
76d1baf+dirty 2.36 MiB 2.82 MiB 469.45 KiB

Previous results on branch: deps/scripts/update-cocoa.sh

Startup times

Revision Plain With Sentry Diff
8da52c9+dirty 1214.59 ms 1224.90 ms 10.31 ms
94f9b87+dirty 1260.32 ms 1283.72 ms 23.40 ms

App size

Revision Plain With Sentry Diff
8da52c9+dirty 2.36 MiB 2.82 MiB 468.48 KiB
94f9b87+dirty 2.36 MiB 2.83 MiB 479.26 KiB

@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-cocoa.sh branch from 95650ed to 34cb88f Compare April 7, 2023 09:55
@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-cocoa.sh branch from 34cb88f to 238b532 Compare April 7, 2023 10:35
krystofwoldrich
krystofwoldrich approved these changes Apr 7, 2023
View reviewed changes
Copy link
Member

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@krystofwoldrich krystofwoldrich merged commit 458e78a into main Apr 7, 2023
@krystofwoldrich krystofwoldrich deleted the deps/scripts/update-cocoa.sh branch April 7, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krystofwoldrich krystofwoldrich krystofwoldrich approved these changes

@marandaneto marandaneto Awaiting requested review from marandaneto

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krystofwoldrich @web-flow