fix(android): `sentry.gradle` Gracefully skip modules collecting if the script doesn't exist #2952

krystofwoldrich · 2023-04-03T09:11:58Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

📜 Description

The modules collecting task should not fail the build if the collect modules script doesn't exist. The modules won't be collected but the app build will be successful.

💡 Motivation and Context

Make collecting modules on Android mono repo friendly #2740 (comment)

💚 How did you test it?

build sample app

📝 Checklist

I reviewed submitted code
I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
All tests passing
No breaking changes

🔮 Next steps

…exist

CHANGELOG.md

github-actions · 2023-04-03T09:51:30Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1244.17 ms	1261.88 ms	17.71 ms
Size	2.36 MiB	2.83 MiB	481.12 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`15c80ab`+dirty	1223.74 ms	1228.96 ms	5.22 ms
`70caa60`+dirty	1218.27 ms	1230.30 ms	12.03 ms
`52a8031`+dirty	1280.88 ms	1289.78 ms	8.90 ms
`e73f4ed`+dirty	1243.27 ms	1244.52 ms	1.25 ms
`8900e1a`+dirty	1210.27 ms	1218.66 ms	8.39 ms
`76d1baf`+dirty	1244.10 ms	1268.52 ms	24.42 ms
`d0bf494`+dirty	1289.40 ms	1298.40 ms	9.00 ms
`86d6d2c`+dirty	1267.55 ms	1286.21 ms	18.66 ms
`d7401ac`+dirty	1252.38 ms	1275.04 ms	22.66 ms
`9a3ca65`+dirty	1247.06 ms	1274.58 ms	27.52 ms

App size

Revision	Plain	With Sentry	Diff
`15c80ab`+dirty	2.36 MiB	2.83 MiB	474.49 KiB
`70caa60`+dirty	2.36 MiB	2.83 MiB	479.27 KiB
`52a8031`+dirty	2.36 MiB	2.82 MiB	469.44 KiB
`e73f4ed`+dirty	2.36 MiB	2.82 MiB	469.44 KiB
`8900e1a`+dirty	2.36 MiB	2.83 MiB	479.25 KiB
`76d1baf`+dirty	2.36 MiB	2.82 MiB	469.45 KiB
`d0bf494`+dirty	2.36 MiB	2.83 MiB	481.15 KiB
`86d6d2c`+dirty	2.36 MiB	2.82 MiB	462.82 KiB
`d7401ac`+dirty	2.36 MiB	2.83 MiB	481.14 KiB
`9a3ca65`+dirty	2.36 MiB	2.82 MiB	462.89 KiB

github-actions · 2023-04-03T09:54:34Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1234.61 ms	1247.04 ms	12.43 ms
Size	2.92 MiB	3.40 MiB	488.12 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`15c80ab`+dirty	1248.41 ms	1251.24 ms	2.83 ms
`70caa60`+dirty	1279.08 ms	1281.54 ms	2.46 ms
`52a8031`+dirty	1255.96 ms	1273.00 ms	17.04 ms
`e73f4ed`+dirty	1282.90 ms	1309.30 ms	26.40 ms
`8900e1a`+dirty	1268.36 ms	1273.04 ms	4.68 ms
`76d1baf`+dirty	1245.00 ms	1257.76 ms	12.76 ms
`d0bf494`+dirty	1266.20 ms	1267.52 ms	1.32 ms
`86d6d2c`+dirty	1291.62 ms	1296.80 ms	5.18 ms
`d7401ac`+dirty	1288.10 ms	1289.54 ms	1.44 ms
`9a3ca65`+dirty	1276.40 ms	1279.14 ms	2.74 ms

App size

Revision	Plain	With Sentry	Diff
`15c80ab`+dirty	2.92 MiB	3.39 MiB	481.56 KiB
`70caa60`+dirty	2.92 MiB	3.39 MiB	486.04 KiB
`52a8031`+dirty	2.92 MiB	3.38 MiB	475.71 KiB
`e73f4ed`+dirty	2.92 MiB	3.38 MiB	475.71 KiB
`8900e1a`+dirty	2.92 MiB	3.39 MiB	485.96 KiB
`76d1baf`+dirty	2.92 MiB	3.38 MiB	475.74 KiB
`d0bf494`+dirty	2.92 MiB	3.40 MiB	488.08 KiB
`86d6d2c`+dirty	2.92 MiB	3.37 MiB	464.31 KiB
`d7401ac`+dirty	2.92 MiB	3.40 MiB	488.06 KiB
`9a3ca65`+dirty	2.92 MiB	3.37 MiB	464.32 KiB

github-actions · 2023-04-03T10:10:09Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	435.78 ms	445.27 ms	9.50 ms
Size	7.15 MiB	8.04 MiB	910.85 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`15c80ab`+dirty	276.38 ms	327.54 ms	51.17 ms
`70caa60`+dirty	308.83 ms	393.06 ms	84.23 ms
`52a8031`+dirty	330.72 ms	358.76 ms	28.03 ms
`e73f4ed`+dirty	262.98 ms	311.02 ms	48.04 ms
`8900e1a`+dirty	371.40 ms	377.70 ms	6.31 ms
`76d1baf`+dirty	339.02 ms	408.65 ms	69.63 ms
`d0bf494`+dirty	253.73 ms	308.23 ms	54.49 ms
`86d6d2c`+dirty	267.21 ms	325.24 ms	58.04 ms
`d7401ac`+dirty	373.98 ms	394.08 ms	20.10 ms
`9a3ca65`+dirty	344.96 ms	358.92 ms	13.96 ms

App size

Revision	Plain	With Sentry	Diff
`15c80ab`+dirty	7.15 MiB	8.09 MiB	966.13 KiB
`70caa60`+dirty	7.15 MiB	8.03 MiB	901.79 KiB
`52a8031`+dirty	7.15 MiB	8.09 MiB	965.95 KiB
`e73f4ed`+dirty	7.15 MiB	8.09 MiB	965.94 KiB
`8900e1a`+dirty	7.15 MiB	8.03 MiB	901.79 KiB
`76d1baf`+dirty	7.15 MiB	8.09 MiB	964.41 KiB
`d0bf494`+dirty	7.15 MiB	8.04 MiB	910.85 KiB
`86d6d2c`+dirty	7.15 MiB	8.09 MiB	962.69 KiB
`d7401ac`+dirty	7.15 MiB	8.04 MiB	910.85 KiB
`9a3ca65`+dirty	7.15 MiB	8.09 MiB	962.83 KiB

brustolin

LGTM

github-actions · 2023-04-06T14:52:42Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	329.45 ms	352.29 ms	22.84 ms
Size	17.73 MiB	19.75 MiB	2.02 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`15c80ab`+dirty	336.27 ms	350.58 ms	14.31 ms
`70caa60`+dirty	299.00 ms	321.02 ms	22.02 ms
`52a8031`+dirty	311.55 ms	321.37 ms	9.82 ms
`e73f4ed`+dirty	332.96 ms	354.33 ms	21.37 ms
`8900e1a`+dirty	430.68 ms	456.13 ms	25.44 ms
`76d1baf`+dirty	335.72 ms	355.52 ms	19.80 ms
`d0bf494`+dirty	375.37 ms	395.14 ms	19.77 ms
`86d6d2c`+dirty	332.90 ms	352.45 ms	19.55 ms
`d7401ac`+dirty	375.20 ms	383.51 ms	8.31 ms
`9a3ca65`+dirty	326.93 ms	330.14 ms	3.21 ms

App size

Revision	Plain	With Sentry	Diff
`15c80ab`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`70caa60`+dirty	17.73 MiB	19.75 MiB	2.01 MiB
`52a8031`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`e73f4ed`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`8900e1a`+dirty	17.73 MiB	19.75 MiB	2.01 MiB
`76d1baf`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`d0bf494`+dirty	17.73 MiB	19.75 MiB	2.02 MiB
`86d6d2c`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`d7401ac`+dirty	17.73 MiB	19.75 MiB	2.02 MiB
`9a3ca65`+dirty	17.73 MiB	20.04 MiB	2.31 MiB

github-actions · 2023-04-07T09:55:03Z

	Fails
🚫	Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- `sentry.gradle` Gracefully skip modules collecting if the script doesn't exist ([#2952](https://github.com/getsentry/sentry-react-native/pull/2952))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 60b1556

krystofwoldrich added 2 commits April 3, 2023 11:08

sentry.gradle Gracefully skip modules collecting if script doesn't …

6a24524

…exist

Update changelog

2d35e07

krystofwoldrich requested a review from marandaneto as a code owner April 3, 2023 09:11

krystofwoldrich changed the title ~~sentry.gradle Gracefully skip modules collecting if script doesn't …~~ sentry.gradle Gracefully skip modules collecting if the script doesn't exist Apr 3, 2023

krystofwoldrich commented Apr 3, 2023

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

Update CHANGELOG.md

905f6e5

brustolin approved these changes Apr 5, 2023

View reviewed changes

Merge branch 'main' into kw-fix-collect-modules-check-file-exists

60b1556

krystofwoldrich changed the title ~~sentry.gradle Gracefully skip modules collecting if the script doesn't exist~~ fix(android): sentry.gradle Gracefully skip modules collecting if the script doesn't exist Apr 7, 2023

krystofwoldrich merged commit 5d2393f into main Apr 7, 2023

krystofwoldrich deleted the kw-fix-collect-modules-check-file-exists branch April 7, 2023 09:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(android): `sentry.gradle` Gracefully skip modules collecting if the script doesn't exist #2952

fix(android): `sentry.gradle` Gracefully skip modules collecting if the script doesn't exist #2952

krystofwoldrich commented Apr 3, 2023 •

edited

Loading

github-actions bot commented Apr 3, 2023 •

edited

Loading

Baseline results on branch: main

Startup times

App size

github-actions bot commented Apr 3, 2023 •

edited

Loading

Baseline results on branch: main

Startup times

App size

github-actions bot commented Apr 3, 2023 •

edited

Loading

Baseline results on branch: main

Startup times

App size

brustolin left a comment

github-actions bot commented Apr 6, 2023

Baseline results on branch: main

Startup times

App size

github-actions bot commented Apr 7, 2023

fix(android): sentry.gradle Gracefully skip modules collecting if the script doesn't exist #2952

fix(android): sentry.gradle Gracefully skip modules collecting if the script doesn't exist #2952

Conversation

krystofwoldrich commented Apr 3, 2023 • edited Loading

📢 Type of change

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

github-actions bot commented Apr 3, 2023 • edited Loading

iOS (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

github-actions bot commented Apr 3, 2023 • edited Loading

iOS (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

github-actions bot commented Apr 3, 2023 • edited Loading

Android (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

brustolin left a comment

Choose a reason for hiding this comment

github-actions bot commented Apr 6, 2023

Android (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

github-actions bot commented Apr 7, 2023

Instructions and example for changelog

fix(android): `sentry.gradle` Gracefully skip modules collecting if the script doesn't exist #2952

fix(android): `sentry.gradle` Gracefully skip modules collecting if the script doesn't exist #2952

krystofwoldrich commented Apr 3, 2023 •

edited

Loading

github-actions bot commented Apr 3, 2023 •

edited

Loading

github-actions bot commented Apr 3, 2023 •

edited

Loading

github-actions bot commented Apr 3, 2023 •

edited

Loading