Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for NODE_BINARY for xcode script to collect modules #2805

Merged
merged 2 commits into from
Feb 3, 2023

Conversation

krystofwoldrich
Copy link
Member

@krystofwoldrich krystofwoldrich commented Feb 3, 2023

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Depending on the setup node can't be always located automatically in the XCode builds.

Therefore it's handy to support a simple way to set your own node path. As React Native scripts do.

Screenshot 2023-02-03 at 17 30 07

💡 Motivation and Context

💚 How did you test it?

sample app

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

🔮 Next steps

@krystofwoldrich krystofwoldrich merged commit d22ef34 into main Feb 3, 2023
@krystofwoldrich krystofwoldrich deleted the node-binary-collect-modules-support branch February 3, 2023 17:38
jmatsushita added a commit to jmatsushita/sentry-expo that referenced this pull request Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants