Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modules): Modules loaders integration handles native error and event modules are prioritised over native #2730

Merged
merged 2 commits into from
Jan 4, 2023

Conversation

krystofwoldrich
Copy link
Member

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

The modules loader would throw an error if the native layer was unavailable.
Also, the native event modules were overwriting the event modules.

💡 Motivation and Context

closes: #2718

💚 How did you test it?

unit tests and sentry-testkit

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

Ttechnically the event modules prioritization is breaking change but it never should be like that so I consider that a fix

🔮 Next steps

@krystofwoldrich krystofwoldrich changed the title fix(modules): Modules loaders integration handles native error fix(modules): Modules loaders integration handles native error and event modules are prioritised over native Jan 4, 2023
@krystofwoldrich krystofwoldrich merged commit c35c86b into main Jan 4, 2023
@krystofwoldrich krystofwoldrich deleted the fix-modules-loader-native-error branch January 4, 2023 09:55
@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2023

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Modules loaders integration handles native error and event modules are prioritised over native ([#2730](https://github.com/getsentry/sentry-react-native/pull/2730))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against e467c06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: after upgrade to version >= 4.10 - sentry-testkit stopped getting reports through transport option
2 participants