Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Stop updating wizard and cli on main (v4) branch #2728

Merged
merged 6 commits into from
Jan 16, 2023

Conversation

krystofwoldrich
Copy link
Member

Temporarily remove wizard and cli updater.

When v5 is merged to the main these jobs will be back from that branch and PR will be opened automatically again.

#skip-changelog

This CI jobs will be added back to main when v5 is merged.
@marandaneto
Copy link
Contributor

@krystofwoldrich What's the reason for removing it?

@krystofwoldrich
Copy link
Member Author

@marandaneto To clean up the PRs, if we remove it from the main branch it will pause the PRs (which can't be closed at the moment, since the updater is opening them), and then when v5 will be merged back the updater will be back.

@marandaneto
Copy link
Contributor

@marandaneto To clean up the PRs, if we remove it from the main branch it will pause the PRs (which can't be closed at the moment, since the updater is opening them), and then when v5 will be merged back the updater will be back.

Maybe just comment out then? When merging v5, it might be that it is removed in the diff, with a comment, you can undo at least.

@krystofwoldrich
Copy link
Member Author

@marandaneto To clean up the PRs, if we remove it from the main branch it will pause the PRs (which can't be closed at the moment, since the updater is opening them), and then when v5 will be merged back the updater will be back.

Maybe just comment out then? When merging v5, it might be that it is removed in the diff, with a comment, you can undo at least.

Okay, that makes sense, it will be easier to return it.

@krystofwoldrich krystofwoldrich merged commit 44b02a7 into main Jan 16, 2023
@krystofwoldrich krystofwoldrich deleted the clean-up-ci-jobs branch January 16, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants