Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transaction op default #2691

Merged
merged 7 commits into from
Dec 14, 2022
Merged

Add transaction op default #2691

merged 7 commits into from
Dec 14, 2022

Conversation

krystofwoldrich
Copy link
Member

@krystofwoldrich krystofwoldrich commented Dec 12, 2022

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

transaction.op is required on Android.

💡 Motivation and Context

closes: #2682

💚 How did you test it?

tests and sample app

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

🔮 Next steps

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
src/js/measurements.ts Outdated Show resolved Hide resolved
src/js/measurements.ts Outdated Show resolved Hide resolved
src/js/measurements.ts Outdated Show resolved Hide resolved
@marandaneto
Copy link
Contributor

Let's double check if startIdleTransaction has to be patched as well, if its an internal and not documented API, we dont need to do that since we always have an op.

@krystofwoldrich
Copy link
Member Author

@marandaneto Checked. startIdleTransaction is not documented and it's only used by the SDKs.

@krystofwoldrich krystofwoldrich merged commit bc60bc6 into main Dec 14, 2022
@krystofwoldrich krystofwoldrich deleted the add-transaction-op-default branch December 14, 2022 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance monitoring (Custom Instrumentation) logs are not sent on Android
2 participants