Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upd build tools #266

Closed
wants to merge 2 commits into from
Closed

upd build tools #266

wants to merge 2 commits into from

Conversation

kesha-antonov
Copy link

No description provided.

@kesha-antonov kesha-antonov reopened this Oct 13, 2017
@HazAT
Copy link
Member

HazAT commented Oct 16, 2017

Hey, thanks for submitting this PR, we've changed this already back and forth a few times 😅
I think Facebook still recommends using version 23.0.1 see:
https://facebook.github.io/react-native/docs/android-building-from-source.html
So before they don't update, we really can't since people who create new projects get 23.0.1 by default.

@HazAT HazAT self-requested a review October 16, 2017 06:40
@jan-auer jan-auer mentioned this pull request Nov 17, 2017
Merged
@HazAT
Copy link
Member

HazAT commented Nov 21, 2017

So thx for contributing but I will close this for now.
Whenever facebook decides to bump their build tools we will be on board.

@HazAT HazAT closed this Nov 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HazAT HazAT Awaiting requested review from HazAT

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kesha-antonov @HazAT