Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(modules): Android builds without ext config, auto create assets dir for modules #2652

Merged
merged 6 commits into from
Nov 30, 2022
Merged

fix(modules): Android builds without ext config, auto create assets dir for modules #2652

merged 6 commits into from
Nov 30, 2022

Conversation

krystofwoldrich
Copy link
Member

@krystofwoldrich krystofwoldrich commented Nov 30, 2022 •
edited
Loading

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

💡 Motivation and Context

fixes: #2650
fixes: #2642

No signature of method: java.util.ArrayList.containsKey() is applicable for argument types: (String) values: [collectModulesScript]
Possible solutions: contains(java.lang.Object), containsAll(java.util.Collection), contains(java.lang.Object), containsAll([Ljava.lang.Object;)

This happens when project.ext.sentryCli is not defined in sample/android/app/build.gradle.

💚 How did you test it?

Sample app

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

🔮 Next steps

@krystofwoldrich krystofwoldrich marked this pull request as draft November 30, 2022 10:06
@krystofwoldrich krystofwoldrich changed the title fix(modules): Don't use containsKey as it's not available on all the types fix(modules): Android builds without ext config, auto create assets dir for modules Nov 30, 2022
@krystofwoldrich krystofwoldrich marked this pull request as ready for review November 30, 2022 10:51
marandaneto
marandaneto reviewed Nov 30, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@krystofwoldrich @marandaneto
Update CHANGELOG.md
927e385 
Co-authored-by: Manoel Aranda Neto <[email protected]>
@krystofwoldrich krystofwoldrich enabled auto-merge (squash) November 30, 2022 12:25
@krystofwoldrich krystofwoldrich merged commit 5add8d1 into main Nov 30, 2022
@krystofwoldrich krystofwoldrich deleted the fix-collect-modules branch November 30, 2022 12:26
@krystofwoldrich krystofwoldrich mentioned this pull request Dec 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marandaneto marandaneto marandaneto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gradle sync failure Auto create assets folder if missing when generating modules.json on Android
2 participants
@krystofwoldrich @marandaneto