Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(new_arch): Add missing sources for Codegen #2639

Merged
merged 2 commits into from
Nov 25, 2022

Conversation

krystofwoldrich
Copy link
Member

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

The source file based on which native interfaces are generated is missing in the package, therefore users opting in for the new architecture would not be able to generate the native interfaces during their app build.

💡 Motivation and Context

Failing new arch build with sentry SDK.

💚 How did you test it?

Using yalc store.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

🔮 Next steps

@krystofwoldrich krystofwoldrich changed the base branch from main to 5.0.0 November 25, 2022 13:07
@krystofwoldrich krystofwoldrich changed the title Fix new arch missing sources fix(new_arch): Add missing sources for Codegen Nov 25, 2022
@krystofwoldrich krystofwoldrich merged commit d5a5308 into 5.0.0 Nov 25, 2022
@krystofwoldrich krystofwoldrich deleted the fix-new-arch-missing-sources branch November 25, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants