chore: Add Sentry/HybridSDK as dependency #2592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
brustolin
changed the title
brustolin
commented
Nov 10, 2022
brustolin
requested review from
marandaneto and
krystofwoldrich
as code owners
brustolin
commented
Nov 10, 2022
marandaneto
reviewed
Nov 10, 2022
|
@krystofwoldrich iOS is failing for some reason, maybe a dependency update broke it or CI flakiness? can you take a quick look? |
|
@marandaneto It's just CI, it's failing on all PRs. |
krystofwoldrich
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Add a dependency to "Sentry/HybridSDK" in the podspec to be able to use
PrivateSentrySDKOnly.h.This pr should be merged only after the next cocoa release.
💡 Motivation and Context
getsentry/team-mobile#66
📝 Checklist
#skip-changelog