Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(transport): Add buffer size option to native transport #2578

Merged
merged 15 commits into from
Nov 4, 2022

Conversation

krystofwoldrich
Copy link
Member

@krystofwoldrich krystofwoldrich commented Oct 27, 2022

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

iOS Doesn't have an option for maxQueueSize, therefore the option is only passed to Java and JS layers.

💡 Motivation and Context

Fixes: #2497

💚 How did you test it?

Sample app.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2022

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 54a79ae

CHANGELOG.md Outdated Show resolved Hide resolved
src/js/sdk.tsx Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
src/js/options.ts Outdated Show resolved Hide resolved
Co-authored-by: Manoel Aranda Neto <[email protected]>
src/js/options.ts Outdated Show resolved Hide resolved
@krystofwoldrich krystofwoldrich merged commit bb28fb1 into main Nov 4, 2022
@krystofwoldrich krystofwoldrich deleted the fix-buffer-size-option branch November 4, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BufferSize TransportOptions doesn't work
2 participants