fix(envelope): Remove duplicate sdk package record from envelope #2570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marandaneto
approved these changes
Oct 25, 2022
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -2,6 +2,10 @@ | |||
|
|
|||
| ## 4.7.0 | |||
|
|
|||
| ### Fixes | |||
|
|
|||
| - Remove duplicate sdk package record from envelope ([#2570](https://github.com/getsentry/sentry-react-native/pull/2570)) | |||
There was a problem hiding this comment.
- 🚫 The changelog entry seems to be part of an already released section
## 4.7.0.
Consider moving the entry to the## Unreleasedsection, please.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
I've introduced this bug in #2492 while fixing missing SDK information in the envelope header. I didn't know that the JS SDK adds information from metadata also to the packages as RN does in SdkInfo integration, therefore this needed to be removed.
💡 Motivation and Context
Closes: #2531
💚 How did you test it?
Sample app and integrations tests
📝 Checklist
🔮 Next steps