Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kw/bundle size check #2560

Closed
wants to merge 2 commits into from
Closed

Kw/bundle size check #2560

wants to merge 2 commits into from

Conversation

krystofwoldrich
Copy link
Member

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

🔮 Next steps

@krystofwoldrich krystofwoldrich changed the base branch from main to 5.0.0 October 19, 2022 15:11
@github-actions
Copy link
Contributor

github-actions bot commented Oct 19, 2022

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Kw/bundle size check ([#2560](https://github.com/getsentry/sentry-react-native/pull/2560))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against a79b08b

@github-actions
Copy link
Contributor

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 368.71 ms 374.80 ms 6.09 ms
Size 25.82 MiB 27.83 MiB 2.01 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Oct 19, 2022

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1257.35 ms 1262.04 ms 4.69 ms
Size 1.08 MiB 1.44 MiB 371.66 KiB

Baseline results on branch: 5.0.0

Startup times

Revision Plain With Sentry Diff
70013c7 1237.84 ms 1258.46 ms 20.62 ms
b5eddfa 1252.54 ms 1254.76 ms 2.22 ms
b9ac2e8 1229.71 ms 1249.82 ms 20.11 ms
17717b8 1264.14 ms 1269.94 ms 5.80 ms
3dd1a5b 1272.44 ms 1292.88 ms 20.44 ms
2a133c2 1232.78 ms 1238.56 ms 5.78 ms
cc863df 1256.06 ms 1263.54 ms 7.48 ms
b4d768b 1236.63 ms 1257.16 ms 20.53 ms

App size

Revision Plain With Sentry Diff
70013c7 1.08 MiB 1.44 MiB 371.41 KiB
b5eddfa 1.08 MiB 1.44 MiB 367.28 KiB
b9ac2e8 1.08 MiB 1.45 MiB 376.28 KiB
17717b8 1.08 MiB 1.44 MiB 363.17 KiB
3dd1a5b 1.08 MiB 1.44 MiB 371.41 KiB
2a133c2 1.08 MiB 1.44 MiB 370.49 KiB
cc863df 1.08 MiB 1.44 MiB 371.41 KiB
b4d768b 1.08 MiB 1.44 MiB 370.50 KiB

@krystofwoldrich
Copy link
Member Author

No size differences have been found.

@krystofwoldrich krystofwoldrich deleted the kw/bundle-size-check branch October 24, 2022 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant