Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sdk): Add ClientReports #2496

Merged
merged 12 commits into from
Sep 27, 2022
Merged

feat(sdk): Add ClientReports #2496

merged 12 commits into from
Sep 27, 2022

Conversation

krystofwoldrich
Copy link
Member

@krystofwoldrich krystofwoldrich commented Sep 26, 2022 •
edited
Loading

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

If clientReport exists it will be send with the next envelope.

💡 Motivation and Context

Closes: #2034

💚 How did you test it?

Unit tests, sample app, checked the client dropped in the graph

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2022 •
edited
Loading

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 4529d27

@krystofwoldrich krystofwoldrich marked this pull request as ready for review September 27, 2022 09:11
marandaneto
marandaneto reviewed Sep 27, 2022
View reviewed changes
src/js/client.ts Outdated Show resolved Hide resolved
marandaneto
marandaneto approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @krystofwoldrich
LGTM.

@krystofwoldrich krystofwoldrich merged commit 7122f76 into main Sep 27, 2022
@krystofwoldrich krystofwoldrich deleted the krystofwoldrich/addClientReports branch September 27, 2022 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marandaneto marandaneto marandaneto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add 'Client Reports' to the React Native SDK
2 participants
@krystofwoldrich @marandaneto